diff options
-rw-r--r-- | src/server/game/Guilds/Guild.cpp | 9 | ||||
-rw-r--r-- | src/tools/map_extractor/loadlib.cpp | 2 | ||||
-rw-r--r-- | src/tools/map_extractor/mpq_libmpq.cpp | 2 | ||||
-rw-r--r-- | src/tools/vmap4_extractor/mpq_libmpq.cpp | 2 |
4 files changed, 9 insertions, 6 deletions
diff --git a/src/server/game/Guilds/Guild.cpp b/src/server/game/Guilds/Guild.cpp index 88f08676bd2..5dcfeac8c2c 100644 --- a/src/server/game/Guilds/Guild.cpp +++ b/src/server/game/Guilds/Guild.cpp @@ -2400,9 +2400,12 @@ void Guild::DeleteMember(SQLTransaction& trans, ObjectGuid guid, bool isDisbandi // Call script on remove before member is actually removed from guild (and database) sScriptMgr->OnGuildRemoveMember(this, player, isDisbanding, isKicked); - if (Member* member = GetMember(guid)) - delete member; - m_members.erase(lowguid); + auto memberItr = m_members.find(guid); + if (memberItr != m_members.end()) + { + delete memberItr->second; + m_members.erase(memberItr); + } // If player not online data in data field will be loaded from guild tabs no need to update it !! if (player) diff --git a/src/tools/map_extractor/loadlib.cpp b/src/tools/map_extractor/loadlib.cpp index 5efade41588..72c6b73e38c 100644 --- a/src/tools/map_extractor/loadlib.cpp +++ b/src/tools/map_extractor/loadlib.cpp @@ -75,7 +75,7 @@ bool FileLoader::prepareLoadedData() void FileLoader::free() { - if (data) delete[] data; + delete[] data; data = 0; data_size = 0; version = 0; diff --git a/src/tools/map_extractor/mpq_libmpq.cpp b/src/tools/map_extractor/mpq_libmpq.cpp index 737b4f4563e..d4766b27a58 100644 --- a/src/tools/map_extractor/mpq_libmpq.cpp +++ b/src/tools/map_extractor/mpq_libmpq.cpp @@ -122,7 +122,7 @@ void MPQFile::seekRelative(int offset) void MPQFile::close() { - if (buffer) delete[] buffer; + delete[] buffer; buffer = 0; eof = true; } diff --git a/src/tools/vmap4_extractor/mpq_libmpq.cpp b/src/tools/vmap4_extractor/mpq_libmpq.cpp index b18b4995fe1..16a866a15f2 100644 --- a/src/tools/vmap4_extractor/mpq_libmpq.cpp +++ b/src/tools/vmap4_extractor/mpq_libmpq.cpp @@ -128,7 +128,7 @@ void MPQFile::seekRelative(int offset) void MPQFile::close() { - if (buffer) delete[] buffer; + delete[] buffer; buffer = 0; eof = true; } |