aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--src/server/game/Entities/Player/Player.cpp5
-rw-r--r--src/server/game/Entities/Unit/Unit.cpp19
-rw-r--r--src/server/game/Entities/Unit/Unit.h12
3 files changed, 26 insertions, 10 deletions
diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp
index b06e1eb5d1f..e334cdf5c97 100644
--- a/src/server/game/Entities/Player/Player.cpp
+++ b/src/server/game/Entities/Player/Player.cpp
@@ -28397,8 +28397,9 @@ void Player::ExecutePendingSpellCastRequest()
}
// Check possible spell cast overrides
- GetCastSpellInfoContext overrideContext;
- spellInfo = castingUnit->GetCastSpellInfo(spellInfo, triggerFlag, &overrideContext);
+ auto [overrideSpellInfo, overrideTriggerFlag] = castingUnit->GetCastSpellInfo(spellInfo);
+ spellInfo = overrideSpellInfo;
+ triggerFlag |= overrideTriggerFlag;
if (spellInfo->IsPassive())
{
CancelPendingCastRequest();
diff --git a/src/server/game/Entities/Unit/Unit.cpp b/src/server/game/Entities/Unit/Unit.cpp
index 555920f4237..28d39abd70c 100644
--- a/src/server/game/Entities/Unit/Unit.cpp
+++ b/src/server/game/Entities/Unit/Unit.cpp
@@ -14084,16 +14084,19 @@ void Unit::ClearBossEmotes(Optional<uint32> zoneId, Player const* target) const
bool Unit::GetCastSpellInfoContext::AddSpell(uint32 spellId)
{
- auto itr = std::ranges::find(VisitedSpells, spellId);
- if (itr != VisitedSpells.end())
- return false; // already exists
+ for (uint32& slot : VisitedSpells)
+ {
+ if (slot == spellId)
+ return false; // already exists
- itr = std::ranges::find(VisitedSpells, 0u);
- if (itr == VisitedSpells.end())
- return false; // no free slots left
+ if (!slot)
+ {
+ slot = spellId;
+ return true;
+ }
+ }
- *itr = spellId;
- return true;
+ return false; // no free slots left
}
SpellInfo const* Unit::GetCastSpellInfo(SpellInfo const* spellInfo, TriggerCastFlags& triggerFlag, GetCastSpellInfoContext* context) const
diff --git a/src/server/game/Entities/Unit/Unit.h b/src/server/game/Entities/Unit/Unit.h
index 67bb1acd327..1804a8cfb19 100644
--- a/src/server/game/Entities/Unit/Unit.h
+++ b/src/server/game/Entities/Unit/Unit.h
@@ -1454,6 +1454,18 @@ class TC_GAME_API Unit : public WorldObject
std::array<uint32, 5> VisitedSpells = { };
bool AddSpell(uint32 spellId);
};
+ struct GetCastSpellInfoResult
+ {
+ ::SpellInfo const* SpellInfo = nullptr;
+ TriggerCastFlags TriggerFlag = TRIGGERED_NONE;
+ };
+ GetCastSpellInfoResult GetCastSpellInfo(SpellInfo const* spellInfo) const
+ {
+ GetCastSpellInfoContext context;
+ GetCastSpellInfoResult result;
+ result.SpellInfo = GetCastSpellInfo(spellInfo, result.TriggerFlag, &context);
+ return result;
+ }
virtual SpellInfo const* GetCastSpellInfo(SpellInfo const* spellInfo, TriggerCastFlags& triggerFlag, GetCastSpellInfoContext* context) const;
uint32 GetCastSpellXSpellVisualId(SpellInfo const* spellInfo) const override;