| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Restore 2 disabled warnings, 1 already disabled in CMake with the WITH_WARNINGS flag set to False and the other disabled by default as stated in VS documentation http://msdn.microsoft.com/en-us/library/aa984150.aspx
|
|
Tools/VMAP: Fix not null terminated string
|
|
Scripts/HoR: Fix possible array overflow
|
|
|
|
Fix possible array overflow reported by coverity, issue id 1062436 .
|
|
Fix not null terminated string in vmap assembler tool, fix coverity issue id 1010351 .
|
|
Core/Misc: Fixed some more issues found by static code analysis tools.
|
|
|
|
Core/Spell: Fix Blood Tap array overflow
|
|
Fix Blood Tap spellid 45529 accessing the 7th element of a size 6 array.
Coverity issue id 1023095.
|
|
Closes #10807
|
|
Fixes #10804
|
|
Core/Logs: Fix race condition in Log
|
|
Core/Commands: Fix NULL dereference crash in .account password
|
|
Fix NULL dereference crash in .account password added in bd8d0cfbce9a38e0f2fc8b6903434c3553faf143
Fixes #10791
|
|
Fix race condition in Log by using atomic operators.
Helgrind log:
Possible data race during read of size 8 at 0x7379D98 by thread #1
Locks held: none
at 0x15AE9C7: AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:59)
by 0x15ADFF8: Appender::write(LogMessage&) (Appender.cpp:106)
by 0x159F14E: Logger::write(LogMessage&) (Logger.cpp:83)
by 0x15A215B: Log::write(LogMessage*) (Log.cpp:290)
by 0x15A200F: Log::vlog(LogFilterType, LogLevel, char const*, __va_list_tag*) (Log.cpp:272)
by 0x15A2682: Log::outInfo(LogFilterType, char const*, ...) (Log.cpp:364)
by 0xF7DA28: Master::Run() (Master.cpp:296)
by 0xF835E8: main (Main.cpp:142)
This conflicts with a previous write of size 8 by thread #10
Locks held: none
at 0x15AE9D7: AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:59)
by 0x15ADFF8: Appender::write(LogMessage&) (Appender.cpp:106)
by 0x159F14E: Logger::write(LogMessage&) (Logger.cpp:83)
by 0x15A215B: Log::write(LogMessage*) (Log.cpp:290)
by 0x15A200F: Log::vlog(LogFilterType, LogLevel, char const*, __va_list_tag*) (Log.cpp:272)
by 0x15A2682: Log::outInfo(LogFilterType, char const*, ...) (Log.cpp:364)
by 0xF7EC1F: FreezeDetectorRunnable::run() (Master.cpp:98)
by 0x15A5B3E: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186)
Address 0x7379D98 is 88 bytes inside a block of size 96 alloc'd
at 0x4C2C857: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_helgrind-amd64-linux.so)
by 0x15A0FE3: Log::CreateAppenderFromConfig(char const*) (Log.cpp:150)
by 0x15A1AED: Log::ReadAppendersFromConfig() (Log.cpp:244)
by 0x15A31B4: Log::LoadFromConfig() (Log.cpp:469)
by 0x15A053B: Log::Log() (Log.cpp:35)
by 0xF75CD1: ACE_Singleton<Log, ACE_Thread_Mutex>::ACE_Singleton() (Singleton.inl:13)
by 0xF754A4: ACE_Singleton<Log, ACE_Thread_Mutex>::instance() (Singleton.cpp:91)
by 0xF8351A: main (Main.cpp:135)
|
|
I don't have the computer to even compile a core, please report back. My logics shouldn't be wrong here from what I can read on the wiki.
Ref #10016.
|
|
|
|
Core/Command: Fixing .account password to no longer crash
|
|
And add some comments to it.
|
|
sent, to the whole party (not blizzlike) or not.
Signed-off-by: Machiavelli <machiavelli.trinity@gmail.com>
|
|
Fixes #3915, By Vincent_Michael
|
|
|
|
Fixes #10778
|
|
Core/Commands: Fixing some problems with .account email
|
|
|
|
Core/ArenaTeam: Add teamnames to logs.
|
|
Scripts/Commands: Retrieve Creature template in HandlePetCreateCommand f...
|
|
Scripts/Murmur: Remove unused field
|
|
Core/Timer: Better handle system clock changes
|
|
Core/Thread: Fix race condition converting time values to local time
|
|
Creature itself
CreatureTemplate can be retrieved directly from the Creature itself instead of using ObjectMgr::GetCreatureTemplate(id) .
|
|
Remove unused class field.
|
|
Scripts/Garfrost: fixed forge jump
|
|
Closes #10740
|
|
|
|
|
|
|
|
Fixes #10758
|
|
|
|
|
|
I hope this is final one....
|
|
|
|
|
|
|
|
|
|
|
|
Note: If you have any custom command, CHECK THE SQLS BEFORE APPLYING
|
|
|
