aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-09-03Merge pull request #10697 from Chaplain/authserverSubv
Auth/Misc: Code cleanup.
2013-09-03Scripts/HallsOfReflection: Fixed a typo detected by static analysis tool.Sebastian Valle
2013-09-03Merge pull request #10713 from jackpoz/movement_fixShauren
Core/Movement: Fix uninitialized MovementInfo fields
2013-09-03Core/Movement: Fix uninitialized MovementInfo fieldsjackpoz
Fix uninitialized fallTime and splineElevation fields of MovementInfo. Valgrind log: Conditional jump or move depends on uninitialised value(s) at 0x5FBEB50: deflate (in /lib/x86_64-linux-gnu/libz.so.1.2.7) by 0x1269883: UpdateData::Compress(void*, unsigned int*, void*, int) (UpdateData.cpp:85) by 0x1269BB6: UpdateData::BuildPacket(WorldPacket*) (UpdateData.cpp:133) by 0x130E9B3: Trinity::VisibleNotifier::SendToSelf() (GridNotifiers.cpp:68) by 0x117A89D: Player::UpdateVisibilityForPlayer() (Player.cpp:22344) by 0x117B334: Player::SendInitialPacketsAfterAddToMap() (Player.cpp:22567) by 0x15A48BC: WorldSession::HandlePlayerLogin(LoginQueryHolder*) (CharacterHandler.cpp:937) by 0x141D04B: WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1106) by 0x141994D: WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:391) by 0x14E289C: World::UpdateSessions(unsigned int) (World.cpp:2629) by 0x14E0613: World::Update(unsigned int) (World.cpp:1986) by 0x100B37F: WorldRunnable::run() (WorldRunnable.cpp:60) Uninitialised value was created by a heap allocation at 0x4C286E7: operator new(unsigned long) (vg_replace_malloc.c:287) by 0x159E64F: void LoadHelper<Creature>(std::set<unsigned int, std::less<unsigned int>, std::allocator<unsigned int> > const&, CoordPair<512u>&, GridRefManager<Creature>&, unsigned int&, Map*) (ObjectGridLoader.cpp:94) by 0x159DECF: ObjectGridLoader::Visit(GridRefManager<Creature>&) (ObjectGridLoader.cpp:150) by 0x159F092: void VisitorHelper<ObjectGridLoader, Creature>(ObjectGridLoader&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64) by 0x159EFF5: void VisitorHelper<ObjectGridLoader, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(ObjectGridLoader&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor.h:70)
2013-09-03DB/SAI: Guided by Honor 11289Filip
Fixes #2263 Requires spell to give quest credit, hence the issue of being unable to turn it in.
2013-09-03Core/Misc: Fixed some more issues found by code analysis tools.Sebastian Valle
2013-09-03Core/Misc: Solved some issues found by static code analysis.Sebastian Valle
2013-09-03DB/SAI: Disclosure (12710)Filip
Fixes #7192 The credit timing is very strange, it is given right at the start of the script, but that's how it is from Blizzard, so we'll stick to that. As for the areatriggers, I know I could've just simplified it and made it into an areatrigger_teleport. But the sniffs state that it is the trigger that just makes the bunnies cast the teleport spell, so we'll keep that one complicated. This is the penultimate quest of the chain, the final quest is a WIP. Any additional info would be very helpful. Regards, Kirk.
2013-09-03DB/Update: Spells update for Bloadted AbominationFilip
2013-09-03DB/Creature: Delete 2 mobs spawned on the voidAokromes
2013-09-02Quest/SAI: Fix quest credit for quest "Monitoring the Rift: Cleftcliff Anomaly"Vincent-Michael
2013-09-02DB/SAI: Mystery of the Infinite (12470)Filip
Fixes #10510
2013-09-02Scripts/HallsOfStone: Sjonnir, some improvementsMitchesD
- rewritten to BossAI - added spawn ordered by percent, according to official data Closes #10702 Signed-off-by: joschiwald <joschiwald@online.de>
2013-09-02Auth/Misc: Code cleanup.Chaplain
*Random performance optimizations
2013-09-02Scripts/HoL/HoS: changed some bosses to optional, doors are always openjoschiwald
2013-09-02Core/SAI: Added SMART_ACTION_CALL_KILLEDMONSTER log for has already spell ↵Vincent-Michael
kill credit
2013-09-02Core: Fix compile with PCH enabled and warningsNay
Few corrections to worldserver.conf
2013-09-02Scripts/HallsOfStone: reworked InstanceScriptjoschiwald
2013-09-02Fix SQL typo after RBAC commitsAokromes
2013-09-02Fix SQL typos after RBAC commitsSpp
2013-09-02Core/RBAC: Move cast and characters commands to RBAC (using individual ↵Nay
permissions)
2013-09-02Compile Fix (and edit of last 2 sqls to add the missing permissions)Spp
2013-09-02Core/RBAC: Move message commands to RBAC (using individual permissions)Spp
2013-09-02Core/Commands: Move lookup commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move list commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move lfg commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move learn commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move instance commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move honor commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move guild commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move gobject commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move go commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move gm commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move event commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move disable commands to RBAC (using individual permissions)Spp
2013-09-02Normalize sql file names from 722a6c1Spp
2013-09-02Core/RBAC: Move deserter commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move debug commands to RBAC (using individual permissions)Spp
2013-09-02Core/RBAC: Move cheat commands to RBAC (using individual permissions)Spp
2013-09-02Core/Spells: move debug log into debug modeAokromes
2013-09-01Merge pull request #10696 from jackpoz/socket_race_conditionNay
Core/Socket: Fix race condition in WorldSocket
2013-09-01Merge pull request #10563 from Ascathor/masterNay
Core/Account: Make account password change security variable and various changes
2013-09-01DB/SAI: Fix quest credit for quest "Laying Waste to the Unwanted"Vincent-Michael
2013-09-01Merge pull request #10687 from jackpoz/farsight_fixShauren
Core/Spell: Fix farsight log error "Player requests non-existing seer"
2013-09-01Core/Spell: Fix farsight log error "Player requests non-existing seer"jackpoz
Partially revert 167ca565d044915f01ead4b189754ab1c44cc981 which wrongly used TYPEMASK_UNIT to denote Creatures and Players, so when a Player sent farsight opcode with another Player as target HandleFarSightOpcode() couldn't find the right Unit filtering by typemask TYPEMASK_SEER.
2013-09-01Core/Objects: Removed obsolete codeShauren
2013-09-01DB/Misc: Fix startup errors & typoZxBiohazardZx
2013-09-01SQL: Fix fail in 7facda2002e80401ce71ab7562042293eba62ad6Vincent-Michael
2013-09-01DB/Loot: make sure to update & delete the right templates, updated file!ZxBiohazardZx
2013-09-01Core/Socket: Fix race condition in WorldSocketjackpoz
ReactorRunnable::svc() checks the status of WorldSockets while WorldRunnable::run() updates them, causing a race condition. Helgrind log: Possible data race during write of size 8 at 0x49961810 by thread #9 Locks held: 1, at address 0x4367A620 at 0x51781F7: ACE_Message_Block::copy(char const*, unsigned long) (Message_Block.inl:372) by 0x15D048F: WorldSocket::SendPacket(WorldPacket const&) (WorldSocket.cpp:180) by 0x141C45E: WorldSession::SendPacket(WorldPacket const*) (WorldSession.cpp:223) by 0x15C49C4: WorldSession::SendAuthResponse(unsigned char, bool, unsigned int) (AuthHandler.cpp:37) by 0x14DA71C: World::AddSession_(WorldSession*) (World.cpp:278) by 0x14E601E: World::UpdateSessions(unsigned int) (World.cpp:2617) by 0x14E3E67: World::Update(unsigned int) (World.cpp:1986) by 0x100EAFA: WorldRunnable::run() (WorldRunnable.cpp:60) by 0x163A626: ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186) by 0x518F555: ACE_OS_Thread_Adapter::invoke() (OS_Thread_Adapter.cpp:103) by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219) by 0x61DAB4F: start_thread (pthread_create.c:304) This conflicts with a previous read of size 8 by thread #14 Locks held: none at 0x1008414: ACE_Message_Block::length() const (Message_Block.inl:131) by 0x15D1207: WorldSocket::Update() (WorldSocket.cpp:448) by 0x1427CA3: ReactorRunnable::svc() (WorldSocketMgr.cpp:177) by 0x51CBB16: ACE_Task_Base::svc_run(void*) (Task.cpp:271) by 0x51CD3BC: ACE_Thread_Adapter::invoke_i() (Thread_Adapter.cpp:161) by 0x51CD4D4: ACE_Thread_Adapter::invoke() (Thread_Adapter.cpp:96) by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219) by 0x61DAB4F: start_thread (pthread_create.c:304) Address 0x49961810 is 16 bytes inside a block of size 80 alloc'd at 0x4C286BB: operator new(unsigned long, std::nothrow_t const&) (vg_replace_malloc.c:316) by 0x15D0818: WorldSocket::open(void*) (WorldSocket.cpp:237) by 0x1429560: ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::activate_svc_handler(WorldSocket*) (Acceptor.cpp:347) by 0x142916D: ACE_Acceptor<WorldSocket, ACE_SOCK_Acceptor>::handle_input(int) (Acceptor.cpp:429) by 0x515F48D: ACE_Dev_Poll_Reactor::dispatch_io_event(ACE_Dev_Poll_Reactor::Token_Guard&) (Dev_Poll_Reactor.inl:86) by 0x5161653: ACE_Dev_Poll_Reactor::handle_events(ACE_Time_Value*) (Dev_Poll_Reactor.cpp:1015) by 0x51ACCFC: ACE_Reactor::run_reactor_event_loop(ACE_Time_Value&, int (*)(ACE_Reactor*)) (Reactor.cpp:267) by 0x1427C57: ReactorRunnable::svc() (WorldSocketMgr.cpp:170) by 0x51CBB16: ACE_Task_Base::svc_run(void*) (Task.cpp:271) by 0x51CD3BC: ACE_Thread_Adapter::invoke_i() (Thread_Adapter.cpp:161) by 0x51CD4D4: ACE_Thread_Adapter::invoke() (Thread_Adapter.cpp:96) by 0x4C2B5AD: mythread_wrapper (hg_intercepts.c:219)