aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-28Core/Spell: don't make creature change orientation to 0 if channeling selfariel-
(cherry picked from commit 1f4439ece49790bee43016ea2462e3803b2f6218)
2020-04-28Core/Spell: define channels without movement interrupt flags as allowed moveariel-
- Remove script hacks no longer needed (cherry picked from commit 3a0cb90ea994e82dd8c70888fb847082f738d5dc)
2020-04-27Core/Packets Fix SMSG_START_TIMER struct & update to new packet system (#22614)Traesh
2020-04-27Core/AI: prevent launching a new MoveChase if victim didn't changeariel-
Thanks ccrs for feedback :P (cherry picked from commit b6b0353bff151d180d98f4f7a67414cfca4bd585)
2020-04-27[3.3.5] Core/Quest: always send the specified RewardNextQuest regardless of ↵Xyventh
eventual scripts (#19498) - Fixes certain situations in which the quest window would get stuck after completing a quest (cherry picked from commit f0bf1fc77aa304ad278618aae25274ed46d308d5)
2020-04-27Core/Scripts: Willix the Importer - $n in aggro texttkrokli
* In the existing core script, Willix the Importer in Razorfen Kraul says "Help! Get this $n off of me!" (showing the $n part in his SAY text) instead of naming the attacker when using his 'SAY_AGGRO1' creature_text. * With this commit change, unit target is no longer missing for Talk, making Willix name the attacking unit when he shouts for help. (cherry picked from commit 6cc267d90918a0663f928db302ef1465f7952c61)
2020-04-27Core/Player: don't randomly change temporary spell statusariel-
- They shouldn't be saved in db - Prevented temporary spell removal after a save Closes #14373 (cherry picked from commit 7ffe0563664c2ed5ba90832dcc42bc15acc177c3)
2020-04-27Core/Spell: fix creature focus with channeled spellsariel-
- Remove one not needed ReleaseFocus, this is done at finish already (cherry picked from commit 88c12b45d0adbe7ca18a72a53cb1416b1621975b)
2020-04-27Revert "Core/Spell: don't set scaleAura for some special spells"ariel-
This reverts commit 1ca8434b365687dbd12ca232a615d126234eba5e. Closes #19472 (cherry picked from commit c296d255e25a2d0eb7155f64eea32cc36fed280a)
2020-04-27DB/Creature: Add missing Spirit HealersKillyana
All graveyards are checked (cherry picked from commit 3028be49296cd2d7efaadd7ab64e3520a934254c)
2020-04-27Core/Unit: fix SPELL_AURA_MOD_DAMAGE_DONE damage calculation on non-melee ↵ariel-
schools for Keader :P (cherry picked from commit 66ac1509ae925edc8848cdf6c370f8ed52c688ec)
2020-04-27Core/Spell: register spell mod owner properly on spell castariel-
- This fixes pets and totems getting mods from owner (cherry picked from commit 8b52cf902bf98a05197efa4e96ddd6188eb1a178)
2020-04-27Core/Auras: don't skip stack rule check whenever spells have same IDariel-
- The auras might not have the same amounts due to spellmods Closes #1626 (cherry picked from commit 9414f50f5c60b03871b4bd8d147786f77476ea04)
2020-04-27Core/Spell: fix broken Unit::GetHighestExclusiveSameEffectSpellGroupValueariel-
- Affects 3 aura effects currently, should be rewritten with GetTotalAuraModifier maybe? (cherry picked from commit d44a44abacdf3f9fabc37e62806970f97e06332b)
2020-04-27Core/Spell: fix nopch build x2ariel-
(cherry picked from commit abaa9d635a6c52f78ec5eb87a5a39890645d5649)
2020-04-27Core/Spell: fix nopch buildariel-
(cherry picked from commit f0a93140e88d9dad96aaf60faf0cb8b6e22b5a97)
2020-04-27Core/Spell: build fixariel-
(cherry picked from commit 9a051570035f7812786158eb00cf482af35bfb10)
2020-04-27Core/Spell: fixed SPELL_GROUP_STACK_RULE_EXCLUSIVE_SAME_EFFECT to actually ↵ariel-
check effects - This commit enables stack rule 3 to be properly used to fix auras that should be active but only one providing effects, even if the spell has multiple auras Closes #19454 (cherry picked from commit 9900899dd9d7f685a1c862bc75e7614e3f0a3ce6)
2020-04-27Rename last 2 SQL files with correct datetkrokli
(cherry picked from commit 912351febd43043798746a2f5bd46595ffea467f)
2020-04-27DB: Fix some DB errorsKillyana
(cherry picked from commit 10d7ae488e32b51b66e0ab3fb44feca68aaa7a8b)
2020-04-27DB/Creature: Add some Winterfin Tadpole missing spawnsKillyana
(cherry picked from commit 5563b14d7a780bd3cb51135d3f62f5594730215b)
2020-04-27Core/Spell: check aura positivity per effect on spell hitariel-
- Fixes applying DR to positive effects, and changing duration of whole aura Closes #19447 (cherry picked from commit 232e631390a504b51d82a7b678b7cf26d49d182a)
2020-04-27Core/Player: fix use after free crashariel-
(cherry picked from commit d914c55c0585fe31a9a1b9fe4e9d4a9b498e8e8f)
2020-04-27Core/Spell: fix SPELL_ATTR3_IGNORE_HIT_RESULT bypassing reflectsariel-
Closes #19440 (cherry picked from commit 83177e771a373514913d066e14d5a7f9775407fe)
2020-04-27DB/Spell: Egg of mortal essence should proc with HoTsariel-
Closes #19441 (cherry picked from commit 947a1f7be3080270b921e9bf69155bfc068ea301)
2020-04-27Core/Instance: stop updating the instance resettimes based on creature respawnsariel-
- Rather update normal instance reset time to 2 hours after last creature kill - This fixes yet another integer overflow due to the possibility of having time_t max showing up - Also change respawntime and resettime fields to bigint on respawn/instance related tables - Start using prepared statements on the InstanceSaveMgr (cherry picked from commit 4c593f12caa162c1bfb831bdbed934bb39155ddb)
2020-04-27Core/Misc: pch fixes pt 2ariel-
(cherry picked from commit e32a4f26aaa51fba2647aeb8ef751dd398bc09d8)
2020-04-27Core/Creature: fix integer overflow in Creature::Update leading to endless ↵ariel-
thrashing of characters database Closes #19182 (cherry picked from commit 66755eecf117d21504b13a86410aa01cfc44c3ba)
2020-04-27Core/Misc: fix non-pch buildariel-
(cherry picked from commit 5e0485178de0ab794c72d845e331559171301b22)
2020-04-27Core/Loot: implement Loot Item Storage (#19018)xinef1
* Created Item Loot Storage, no more synchronous DB selects * Fixed buyback case, where stored loot was not removed from db * Added Primary key, and changed field types to be unsigned for table item_loot_money (cherry picked from commit 9dc3de10f0044c35a95e9b72e7b874f4b5b8e867)
2020-04-27Core/Movement: correct no point recalculation on speed change in ↵ccrs
TargetedMovementGenerator (cherry picked from commit 4d7e7a97b329dc8ee4354f7be26c5e5efbaeba6b)
2020-04-27Core/Unit: fix crash on magic school autoattacksariel-
Closes #19436 (cherry picked from commit 0b50ea072e504ac7d5bf87b08d564955785f7197)
2020-04-27Core/Unit: cleanup and minor fixes of miss and resist calculationsariel-
- Removed Unit::GetUnitMeleeSkill as it was basically a copy of GetMaxSkillValueForLevel - Removed static from GetEffectiveResistChance, as this was passed anyways, changed name to CalculateAverageResistReduction, which better reflects what it does - Fix melee miss chances calculated from attacker maxskill instead of victim maxskill - Do actual checks if spell can be resisted/missed in MagicSpellHitResult (ie chances > 0) - Fixed SPELLMOD_RESIST_MISS_CHANCE calculation in MeleeSpellMissChance - Minor codestyle and cleanup of diminishing returns calcs (cherry picked from commit e565b34f6d24411e210151d0d03e524f94cdff85)
2020-04-27Core/Misc: fix static analysis issuesariel-
CID 1373466 CID 1373481 CID 1373482 (cherry picked from commit e478434146fd479fab955aaa80eb925c15e29809)
2020-04-27Core/Quest: fix RewardNextQuest being used to condition previous quests in chainariel-
(cherry picked from commit 214b8e53c5598695915c1392702e059d79cfc260)
2020-04-27DB/Gossip: Add broadcast gossip text for Argent Gruntling/Argent SquireKillyana
Closes #19402 (cherry picked from commit 33ce20b021a0d848a3c33058e8757bc3bddee970)
2020-04-27DB/Script: Fix Captain Dranarus sound rangeKillyana
By offl Closes #19427 (cherry picked from commit f7bb1d899da27b62a54193e158c1400ef107015a)
2020-04-27Core/Scripts: Baltharus the Warborn preincrement _cloneCountKeader
(cherry picked from commit 2921449a333ea27a62c7b21d003650421c982917)
2020-04-27Core/Movement: FormationMovementGeneratorccrs
Use own movement generator for creatures following on a formation. First step of implementation, huge room for improvement. Closes #19422 (cherry picked from commit 46221b6dc1272989e0de85a4563fc49dba8e7851)
2020-04-27Core/Misc: Fix static analysis issuesjackpoz
(cherry picked from commit 3c4c67160afbe15cc48e5390201157c416cb9a09)
2020-04-27[3.3.5] Core/Movement: MotionMaster & MovementGenerators cleaning (#19361)ccrs
(cherry picked from commit 21b8c4997a260b5e2dc24ab07df17d3daa6b8b5d)
2020-04-27Core/Player: fix weapon dependent aura talents not applied on talent learnariel-
Closes #19408 (cherry picked from commit 5cb1555de6db43db03d6202b7edaa9c6835ecfab)
2020-04-27Core/Auction: wrap item deletions from AHBot auction on a transactionariel-
This speeds up the query execution time tremendously Refs #19182 (cherry picked from commit ae9995f463ec9797eaa4a803bdca4fbf5978a9b7)
2020-04-27Core/Scripts: Baltharus the Warborn make clone count more readableKeader
*Also fixed issue that make Baltharus summons alot of clones when he is casting (cherry picked from commit 58f2e62098f2c78b77b6b3851709c83f33e1cafd)
2020-04-27Core/AHBot: fix price calcariel-
- priceRatio is already a factor (cherry picked from commit 4a654be2fbb1857f31180f8d4edca91f7825c34a)
2020-04-27Core/AHBot: fixed assert checkariel-
(cherry picked from commit c36854677c4cef0c83a81afa23b45ba322d354cc)
2020-04-27Core/Spell: don't set scaleAura for some special spellsariel-
Closes #14541 (cherry picked from commit 1ca8434b365687dbd12ca232a615d126234eba5e)
2020-04-27Core/AHBot: fix a typoariel-
(cherry picked from commit e594c2d096c101a5b722793612febb6276b3b48e)
2020-04-27Core/AHBot: Refactor of AuctionHouseBotSeller:ariel-
- Use AuctionHouseBot.Class.* for what they really are, priorities, factor them when calculating item amount per class, changed enums to CONFIG_AHBOT_CLASS_*_PRIORITY to reflect this change - Don't factor in the priority calc empty item lists: * Let's say you had AuctionHouseBot.Class.Glyph set to 10, sum of AuctionHouseBot.Class.* is 20, and AuctionHouseBot.Items.Amount.White is 5000 * If there were no glyphs on the item list, you automatically lost 50% of the total item amount, meaning only 2500 of original 5000 were alloted to fill - Fixed AuctionHouseBot.AH.Price.Ratio to be an actual percentage factor - Separated containers in SellerConfiguration, each one better reflects what kind of data is stored there, now we won't use magic index 0 from _ItemInfo :P - General cleanup, removal of bad voodoo and magical numbers - Use unordered_sets for loading item lists, as they were only used to check for item presence (cherry picked from commit 7f8bfe68d0f660643c8bd4c63d2129d220c2184c)
2020-04-27DB/Schema: add unsigned to some guid fields in charactersariel-
(cherry picked from commit 0c698b4567044f67eb52f6459308fb6edf693966)