aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-11-03DB/SAI: Little Morsels cannot feed mobsAokromes
by dr-j, closes #10892
2013-11-03DB/Misc: Fix Bros. Before Ho Ho Ho'sAokromes
by nelegalno, closes #4332
2013-11-03DB/Quest: Fix quest ender for To Fordragon Hold!Aokromes
by dr-j, closes #5121
2013-11-03DB/Misc: Make Caladis Brightspear visible when having proper questAokromes
by Foldor, updates #11015
2013-11-03DB/Disables: Tempering The Blade queldalar LoSAokromes
by dr-j, closes #8920
2013-11-03DB/Misc: Lunar Festival Invitation - Teleport MoongladeAokromes
by zaphod77, updates #4945
2013-11-03DB/Misc: Heart of the Phoenix Cooldown must ignore LoSAokromes
By mweinelt, updates #10198
2013-11-03DB/Gameobject: Battle plans of the KvaldirAokromes
By Justiciar, closes #10291
2013-11-03DB/SAI: Book of the AncientsAokromes
By dr-j, closes #10146
2013-11-03DB/Misc: Argent tournament quests without progressAokromes
By Crysicle, closes #7988
2013-11-03DB/SAI: There's Something Going On In Those CavesAokromes
By dr-j, closes #10786
2013-11-03DB/SAI: Boiling PointAokromes
By untaught, closes #10761
2013-11-03DB/Quest: A Dark InfluenceAokromes
By wintergreen77, fixes #6777
2013-11-03DB/Misc: Kyle the friendlyAokromes
By dr-j, closes #10564
2013-11-03DB/Misc: Required classes for all versions of The Purification of Quel'DelarAokromes
By dr-j, closes #10594
2013-11-03DB/SAI: Still At ItAokromes
By dr-j, closes #8008
2013-11-03DB/Creature: Scalesworn Elite inhabittypeAokromes
By untaught, closes #10831
2013-11-03DB/SAI: Fix more credit fixesAokromes
By Pitcrawler, closes #10022
2013-11-03DB/Conditions: Skill requirements to ride flying carpets and flying machinesAokromes
By dr-j, closes #10572
2013-11-03DB/Gameobject: Ulduar Flame Leviatan secondary force fieldAokromes
By PanDaemonAeon, closes #4793
2013-11-03DB/Misc: Remove spells with effects SPELL_EFFECT_SUMMONAokromes
By xjose93, closes #7653 closes #10212
2013-11-03DB/Creature: IoC template updatesAokromes
By milotic, closes #8591
2013-11-03DB/Gameobject: Dip in the MoonwellAokromes
By untaught, closes #7523
2013-11-03DB/SAI: Fix more credit fixesAokromes
By dr-j, closes #10872
2013-11-03DB/SAI: Surveying the RuinsAokromes
By Polkic, closes #11162
2013-11-02Core/Database: Add additional assertjackpoz
Add additional assert to assure that helgrind reports related to SQLQueryHolderTask::Execute() and WorldSession::ProcessQueryCallbacks() are false positives. The only chance for WorldSession::ProcessQueryCallbacks() to access the SQL queries before they are completed is if m_result.ready() is true before the end of SQLQueryHolderTask::Execute() . Helgrind false positive log: Possible data race during read of size 8 at 0x2BD641E0 by thread #7 Locks held: none at : SQLQueryHolder::GetPreparedResult(unsigned long) (QueryHolder.cpp:107) by : Player::LoadFromDB(unsigned int, SQLQueryHolder*) (Player.cpp:16917) by : WorldSession::HandlePlayerLogin(LoginQueryHolder*) (CharacterHandler.cpp:807) by : WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1112) by : WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:401) by : World::UpdateSessions(unsigned int) (World.cpp:2646) by : World::Update(unsigned int) (World.cpp:2003) by : WorldRunnable::run() (WorldRunnable.cpp:60) by : ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186) by : ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so) by : mythread_wrapper (hg_intercepts.c:233) by : start_thread (pthread_create.c:311) This conflicts with a previous write of size 8 by thread #4 Locks held: none at : SQLQueryHolder::SetPreparedResult(unsigned long, PreparedResultSet*) (QueryHolder.cpp:140) by : SQLQueryHolderTask::Execute() (QueryHolder.cpp:196) by : SQLOperation::call() (SQLOperation.h:65) by : DatabaseWorker::svc() (DatabaseWorker.cpp:45) by : ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so) by : ACE_Thread_Adapter::invoke_i() (in /usr/lib/libACE-6.0.3.so) by : ACE_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so) by : mythread_wrapper (hg_intercepts.c:233) Address 0x2BD641E0 is 16 bytes inside a block of size 792 alloc'd at : operator new(unsigned long) (vg_replace_malloc.c:319) by : __gnu_cxx::new_allocator<std::pair<SQLElementData, SQLResultSetUnion> >::allocate(unsigned long, void const*) (new_allocator.h:104) by : std::_Vector_base<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::_M_allocate(unsigned long) (in /home/jackpoz/trinity/bin/worldserver) by : std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::_M_fill_insert(__gnu_cxx::__normal_iterator<std::pair<SQLElementData, SQLResultSetUnion>*, std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > > >, unsigned long, std::pair<SQLElementData, SQLResultSetUnion> const&) (vector.tcc:483) by : std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::insert(__gnu_cxx::__normal_iterator<std::pair<SQLElementData, SQLResultSetUnion>*, std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > > >, unsigned long, std::pair<SQLElementData, SQLResultSetUnion> const&) (stl_vector.h:1024) by : std::vector<std::pair<SQLElementData, SQLResultSetUnion>, std::allocator<std::pair<SQLElementData, SQLResultSetUnion> > >::resize(unsigned long, std::pair<SQLElementData, SQLResultSetUnion>) (stl_vector.h:707) by : SQLQueryHolder::SetSize(unsigned long) (QueryHolder.cpp:167) by : LoginQueryHolder::Initialize() (CharacterHandler.cpp:66) by : WorldSession::HandlePlayerLoginOpcode(WorldPacket&) (CharacterHandler.cpp:788) by : WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:363) by : World::UpdateSessions(unsigned int) (World.cpp:2646) by : World::Update(unsigned int) (World.cpp:2003)
2013-11-02Core/Transports: Fixed a few mistakes in GO passenger teleports (currently ↵Shauren
unused), thanks joschiwald for spotting them
2013-11-02Tools: Skip extracting already existing DBC filesGacko
Thanks to MacWarrior, closes #11061
2013-11-02Fixed typo in 39175ac68071a22233cb6828bfd8f2cd099861d7Shauren
2013-11-02Core/TransportsShauren
* Fixed fall damage on transports while teleporting * Fixed packets not being received by owner if sent by a controlled minion * Fixed an issue when a teleporting transport would attempt to reload its creature passengers on old map Closes #11140
2013-11-02DB/Misc: Correct some game event dataAokromes
By Foldor, closes #10960
2013-11-02DB/Loot: Voidwalker Minions are not meant to drop lootAokromes
By dr-j and Exodius closes #11012
2013-11-02DB/Misc: NeltharakuAokromes
By untaught, closes #11031
2013-11-02DB/SAI: Slaves of the StormforgedAokromes
By untaught, closes #10509
2013-11-02DB/SAI: Sprouted FrondAokromes
By untaught, closes #11123
2013-11-02DB/Misc: Quest item "Drain Schematics" dropAokromes
By trickerer, fixes #10394
2013-11-02DB/Misc: Fixes 2 innkeepers of Hallow's End eventAokromes
By dr-j and untaught, closes #11108
2013-11-02DB/Misc: Make invisible some visible TriggersAokromes
By untaught, closes #10648
2013-10-28DB/SAI: Dragonmaw Sky StalkerFilip
By @MitchesD fixes #11148
2013-10-28Core/Vehicles: Add missing NULL check in ↵jackpoz
cf72f7cc5cf13607dd7353b8d940d56679b6956b Add an additional NULL check for me->GetVehicleKit() , otherwise the crash fixed in cf72f7cc5cf13607dd7353b8d940d56679b6956b becomes a NULL dereference crash.
2013-10-28Merge pull request #11147 from LeGuybrush/masterAokromes
Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }.
2013-10-28Core/Code: Unify [more] codestyle for brackets: )\n{\n} to ) { }.leguybrush
2013-10-28Merge pull request #11138 from Ascathor/masterAokromes
Core/Code: Unify codestyle for brackets: {} to { }.
2013-10-27Core/Code: Adding copyright to all the mesh_extractor files.Ascathor
2013-10-27Core/Code: Unify codestyle for brackets: {} to { }.Ascathor
Also added missing copyright to some files.
2013-10-27Core/Vehicles: Fixed a crash caused by accessing freed memoryShauren
Valgrind log: ==1357== Invalid read of size 8 ==1357== at 0x108339C: std::_Rb_tree<signed char, std::pair<signed char const, VehicleSeat>, std::_Select1st<std::pair<signed char const, VehicleSeat> >, std::less<signed char>, std::allocator<std::pair<signed char const, VehicleSeat> > >::begin() (stl_tree.h:685) ==1357== by 0x1082B23: std::map<signed char, VehicleSeat, std::less<signed char>, std::allocator<std::pair<signed char const, VehicleSeat> > >::begin() (stl_map.h:321) ==1357== by 0x1567152: VehicleAI::CheckConditions(unsigned int) (CombatAI.cpp:330) ==1357== by 0x1566EE5: VehicleAI::UpdateAI(unsigned int) (CombatAI.cpp:285) ==1357== by 0x11A8FB3: Creature::Update(unsigned int) (Creature.cpp:543) ==1357== by 0x11BC1A2: TempSummon::Update(unsigned int) (TemporarySummon.cpp:47) ==1357== by 0x12E8194: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45) ==1357== by 0x12F31BD: void VisitorHelper<Trinity::ObjectUpdater, Creature>(Trinity::ObjectUpdater&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64) ==1357== by 0x12F2CCB: void VisitorHelper<Trinity::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor.h:70) ==1357== by 0x12F251F: void VisitorHelper<Trinity::ObjectUpdater, GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:71) ==1357== by 0x12F1BA5: void VisitorHelper<Trinity::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >(Trinity::ObjectUpdater&, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:94) ==1357== by 0x12F0DDD: TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >::Visit(TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >&) (TypeContainerVisitor.h:105) ==1357== by 0x12EF5A0: void Grid<Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::Visit<Trinity::ObjectUpdater>(TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (Grid.h:91) ==1357== by 0x12ED766: void NGrid<8u, Player, TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > >, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >::VisitGrid<Trinity::ObjectUpdater, TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > >(unsigned int, unsigned int, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (NGrid.h:157) ==1357== by 0x12EA2D3: void Map::Visit<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >(Cell const&, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&) (Map.h:701) ==1357== by 0x12DCD84: Map::VisitNearbyCellsOf(WorldObject*, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<GameObject, TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > > > >&, TypeContainerVisitor<Trinity::ObjectUpdater, TypeMapContainer<TypeList<Player, TypeList<Creature, TypeList<Corpse, TypeList<DynamicObject, TypeNull> > > > > >&) (Map.cpp:604) ==1357== by 0x12DD045: Map::Update(unsigned int) (Map.cpp:646) ==1357== by 0x1520E03: MapUpdateRequest::call() (MapUpdater.cpp:54) ==1357== by 0x1596958: DelayExecutor::svc() (DelayExecutor.cpp:52) ==1357== by 0x5184E56: ACE_Task_Base::svc_run(void*) (in /usr/lib/libACE-6.0.3.so) ==1357== Address 0x2a849600 is 32 bytes inside a block of size 168 free'd ==1357== at 0x4C2BADC: operator delete(void*) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==1357== by 0x107F309: Vehicle::~Vehicle() (Vehicle.cpp:66) ==1357== by 0x10BE0D2: Unit::RemoveVehicleKit() (Unit.cpp:15949) ==1357== by 0x10B52CA: Unit::RemoveFromWorld() (Unit.cpp:13440) ==1357== by 0x11A7D73: Creature::RemoveFromWorld() (Creature.cpp:204) ==1357== by 0x11BCBAA: TempSummon::RemoveFromWorld() (TemporarySummon.cpp:279) ==1357== by 0x11BCD5E: Minion::RemoveFromWorld() (TemporarySummon.cpp:308) ==1357== by 0x10B5514: Unit::CleanupBeforeRemoveFromMap(bool) (Unit.cpp:13481) ==1357== by 0x10B5605: Unit::CleanupsBeforeDelete(bool) (Unit.cpp:13503) ==1357== by 0x12E3B67: Map::AddObjectToRemoveList(WorldObject*) (Map.cpp:2401) ==1357== by 0x10FCAAC: WorldObject::AddObjectToRemoveList() (Object.cpp:2138) ==1357== by 0x11BCABA: TempSummon::UnSummon(unsigned int) (TemporarySummon.cpp:256) ==1357== by 0x11BCAFA: ForcedUnsummonDelayEvent::Execute(unsigned long, unsigned int) (TemporarySummon.cpp:261) ==1357== by 0x159B665: EventProcessor::Update(unsigned int) (EventProcessor.cpp:47) ==1357== by 0x10858E2: Unit::Update(unsigned int) (Unit.cpp:318) ==1357== by 0x11A8E6C: Creature::Update(unsigned int) (Creature.cpp:519) ==1357== by 0x11BC1A2: TempSummon::Update(unsigned int) (TemporarySummon.cpp:47) ==1357== by 0x12E8194: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45) ==1357== by 0x12F31BD: void VisitorHelper<Trinity::ObjectUpdater, Creature>(Trinity::ObjectUpdater&, ContainerMapList<Creature>&) (TypeContainerVisitor.h:64) ==1357== by 0x12F2CCB: void VisitorHelper<Trinity::ObjectUpdater, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > >(Trinity::ObjectUpdater&, ContainerMapList<TypeList<Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > >&) (TypeContainerVisitor
2013-10-27Merge pull request #11137 from Ascathor/masterSubv
Core/Command: Fix ban info order for .pinfo
2013-10-27Core/Command: Fix ban info order for .pinfoAscathor
2013-10-27DB/Cond: Prevent multiple spawns in vicinityFilip
By @dr-j fixes #11128
2013-10-27Core/Transports: Correct path generation for a few transportsShauren