| Age | Commit message (Collapse) | Author |
|
Core/Packets: updated and enabled CMSG_QUESTGIVER_ACCEPT_QUEST
|
|
Core/PacketIO: updated and enabled CMSG_SET_TITLE
|
|
|
|
|
|
Thx @DJScias for help
|
|
|
|
|
|
closing the map
|
|
|
|
|
|
Also correct SMSG_NOTIFICATION initializaiton.
|
|
Core/Packets: Update & enable more opcodes (names inside)
|
|
SMSG_CANCEL_ORPHAN_SPELL_VISUAL, SMSG_CANCEL_SPELL_VISUAL, SMSG_COIN_REMOVED
Documentation used:
- Updated and enabled the before-mentioned opcodes.
- "SMSG_CANCEL_AUTO_REPEAT" also switched from PackedGuid to ObjectGuid as per @DDuarte's suggestion.
- Changed initial size of "SMSG_SELL_RESPONSE" packet and default initialized SellResult Reason. Thanks @Lordron.
Cleaning up latest commit.
|
|
Core/Packets: update & enable CMSG_RANDOM_ROLL, SMSG_RANDOM_ROLL, CMSG_E...
|
|
Core/Log: Fix some issues detected by static analysis.
|
|
This reverts commit 04020e717c1303bb9b175bad63d4ce155c810e88.
Initializing a std::string with nullptr is not allowed by C++11 standard
and trigger runtime exceptions.
|
|
CMSG_EMOTE, CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE
Documentation used:
- Enabled CMSG_TEXT_EMOTE and SMSG_TEXT_EMOTE to 6.1
- Changed CMSG_EMOTE from "0x0B2B" to "0x0B2C". It sends an empty packet but it's meant to stop the current emote as per @Zedron's sniffs.
- Updated structure and enabled CMSG_RANDOM_ROLL and SMSG_RANDOM_ROLL. Thanks @rocverde for providing sniffs.
Cleaning up last commit
|
|
|
|
structure to match sniffs of retail and correct threashold and reason definitions.
|
|
Core/Packets: updated and enabled SMSG_SELL_RESPONSE
|
|
This reverts commit e68ca82d4d039a401d03de145111b0a738bb9dd7.
Closes #14329
|
|
A typo that slipped in, damnit
|
|
Core/Game: & Core/Scripts: Fix some issues detected by static analysis.
|
|
|
|
|
|
|
|
* Prefer prefix ++/-- operators for non-primitive types.
* Variable 'ownerBonus' is reassigned a value before the old one has been used.
* Fix a wrong type of ownerBonus, sometimes it is float sometimes uint32
|
|
* Possible inefficient checking for 'list' emptiness.
* Variable '_scheduledScripts' is assigned in constructor body.
Consider performing initialization in initialization list.
* Variable 'Text' is assigned in constructor body.
Consider performing initialization in initialization list.
* Possible inefficient checking for 'm_loadedScripts' emptiness.
|
|
|
|
* Either inefficient or wrong usage of string::find(). string::compare() will
be faster if string::find's result is compared with 0, because it will not scan the whole string.
If your intention is to check that there are no findings in the string,
you should compare with std::string::npos.
* C-style pointer casting detected. C++ offers four different kinds of casts as replacements:
static_cast, const_cast, dynamic_cast and reinterpret_cast.
|
|
conventions.
|
|
Core/Support: Update the support/ticket system to 6.x
|
|
Core/Mail: fix a logic error introduced in 829e11b6623f967672143d79cd8d31772f54866d
|
|
(also added OnCombatExit hook for stuff like this)
|
|
Core/Packets: update & enabled CMSG_EMOTE
|
|
Documentation Used:
- Thank you @MitchesD for providing some extra information, much appreciated.
Core/Packets: Fix CMSG_EMOTE opcode handler
Documentation used:
- Thanks thumsoul from TC IRC for providing extra information.
|
|
|
|
|
|
Core/PacketIO: Sync with WPP
|
|
|
|
Core/PacketIO: enable CMSG_DESTROY_ITEM, CMSG_INSPECT, SMSG_INSPECT_RESU...
|
|
Documentation used:
- Thanks @rocverde for providing sniffs through TC IRC.
- Each opcode checked and works positively, feel free to apply and check yourself.
|
|
Core/Packets: update & enabled CMSG_SHOWING_CLOAK, CMSG_SHOWING_HELM
|
|
Documentation Used:
- Thanks @rocverde for providing sniffs through TC IRC.
- Thank you very much @MitchesD, @DDuarte, @Carbenium and @Vincent-Michael (+ Trinity as a whole) for the help with my very first opcode structure update.
|
|
|
|
|
|
|
|
|
|
Closes #14133
|
|
|