aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-02-07Shared/Logs: Make AppenderFile more thread-safejackpoz
In case of dynamic file names don't store the FILE* handle in a shared class variable but keep it only at function scope. Valgrind log: at _IO_un_link (genops.c:69) by fclose@@GLIBC_2.2.5 (iofclose.c:55) by AppenderFile::CloseFile() (AppenderFile.cpp:94) by AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:66) by Appender::write(LogMessage&) (Appender.cpp:102) by Logger::write(LogMessage&) const (Logger.cpp:63) by Log::write(LogMessage*) (Log.cpp:279) by Log::vlog(std::string const&, LogLevel, char const*, __va_list_tag*) (Log.cpp:267) by Log::outMessage(std::string const&, LogLevel, char const*, ...) (Log.h:129) Address 0x2a1bd2d0 is 0 bytes inside a block of size 568 free'd at free (vg_replace_malloc.c:468) by fclose@@GLIBC_2.2.5 (iofclose.c:85) by AppenderFile::CloseFile() (AppenderFile.cpp:94) by AppenderFile::_write(LogMessage const&) (AppenderFile.cpp:66) by Appender::write(LogMessage&) (Appender.cpp:102) by Logger::write(LogMessage&) const (Logger.cpp:63) by Log::write(LogMessage*) (Log.cpp:279) by Log::vlog(std::string const&, LogLevel, char const*, __va_list_tag*) (Log.cpp:267) by Log::outMessage(std::string const&, LogLevel, char const*, ...) (Log.h:129)
2014-02-07Shared/Logs: Add workaround for "w" flag used with dynamic name filesjackpoz
Ignore "w" flag and always use "a" for log files with dynamic name since the file handle is created at every log line and "w" would delete any other logged line from previous _write() calls. The best solution would be to overwrite only at first call and append at any other call.
2014-02-07Revert "DB/Misc: A lucky bag random fixes"Vincent_Michael
This reverts commit 3fcb1bf09140e59a878911cd889d5047cf8a0ca6.
2014-02-07SQL: Maybe I'll have more luck :(Vincent_Michael
2014-02-07DB/Misc: A lucky bag random fixesVincent_Michael
2014-02-06Core/Achievements: rename some AchievementCriteriaDataTypes to keep consistentjoschiwald
2014-02-06Core/Spells: Possible crash fixjackpoz
Get Unit target with the proper method instead of retrieving Object target and then casting it to Unit, possible dereferencing NULL. Updates #11560
2014-02-06Core/CrashHandler: Add more informations about localsjackpoz
Handle SymTagData with inner type of SymTagPointerType. Increase buffer sizes to avoid buffer overflows. Avoid infinite loops by logging the children of each type only once. Avoid too deep nesting by adding a max nesting level. Print the address for arrays instead of just the name.
2014-02-06Core/Entities: allow interaction with gameobject questgivers if player can ↵joschiwald
take or return quests Closes #11269 Closes #8898 Closes #10204 Closes #11410 Closes #7053 Closes #6189 Closes #9474
2014-02-06DB/Gameobject: Fix Dire PoolAokromes
Closes #9893
2014-02-05Remove whitespaces from previous commitGacko
2014-02-05Authserver / Worldserver: Fix warnings about unused variablesGacko
2014-02-05Core/Auras: Implemented SPELL_AURA_MOD_COOLDOWNShauren
Closes #9671
2014-02-05Merge pull request #11568 from Rochet2/VendorChecksDiscover-
Core: Add rest of checks from SendListInventory to BuyItemFromVendorSlot
2014-02-05Core/Achievements: Use ACE_OS::localtime_r instead of localtime in my ↵Discover-
previous commit for thread safety. Thanks to @Shauren
2014-02-05Core/Achievements: Implement criteria type ↵Discover-
ACHIEVEMENT_CRITERIA_TYPE_ON_LOGIN and criteria requirements ACHIEVEMENT_CRITERIA_REQUIRE_NTH_BIRTHDAY and ACHIEVEMENT_CRITERIA_REQUIRE_KNOWN_TITLE. Fixes anniversary achievements. By @Schmoozerd
2014-02-04DB/SAI: Fix Dire Maul entrance leversAokromes
Updates #6298
2014-02-04Core: Add rest of checks from SendListInventory to BuyItemFromVendorSlotRochet2
2014-02-04Rename 2014_01_21_world_access_requirement.sql to ↵Aokromes
2014_02_04_00_world_access_requirement.sql
2014-02-04Merge pull request #11095 from gerripeach/pull_request3Aokromes
Core/LFG: Minimum item level in Wotlk heroic dungeons
2014-02-04Core/Spells: Fixed AoE damage reduction auras, original patch by @UnholychickShauren
2014-02-04Core/Groups: Fixed UnitIsPartyLeader lua functionShauren
2014-02-02Core/Misc: remove error log, which returns false positivesjoschiwald
2014-02-02Core/Chat: Fix a new issue caused by ↵Discover-
c0224dd7ca9a39034518bd7e6285702636749929 which would trigger false positives for CHAT_MSG_AFK and CHAT_MSG_DND.
2014-02-01Core/Spell: Handle SPELL_AURA_FORCE_REACTION missing casesjackpoz
Always check forced reputation ranks before any other faction check to get the reaction between 2 units. Fixes #5790
2014-02-01Core/Spells: fix crash when loading custom spell attr with invalid spellidjoschiwald
2014-02-01Core/Scripts: Fix quest The Totem of Kar'dash alliance version.w1sht0l1v3
Remove some hungarian notation for horde side version. Closes #11035
2014-02-01DB/Creature: Fix warnings with creature_formations loadingVincent_Michael
2014-02-01Core/Chat: Fix an exploit where it was possible to speak in universal ↵Discover-
language in say/yell/emote by sending CMSG_MESSAGECHAT using cheats.
2014-01-31Build: Use override/final keywords for VS 2012 and newer. (VS 2013 still ↵Shauren
defines __cplusplus as 199711L)
2014-01-31Shared/Logs: Fix crash in Console log outputjackpoz
Correctly handle the return value of vsnprintf() which returns -1 if the buffer is too small http://msdn.microsoft.com/en-us/library/1kt27hek.aspx . In this case just truncate the output. This caused a crash on character delete if Logger.entities.player.dump was enabled and set to 3. Fixes #11539
2014-01-31Core/Arena: Fix arena season not always appearing to clientsjackpoz
Arena season sent to client with SMSG_INIT_WORLD_STATES opcode was not sent if Player was on a zone with id 0 on login. Initializing the zone id to -1 will always trigger UpdateZone() properly on login. Fixes #10623
2014-01-31SQL: Update 2014_01_31_01_world_item_template.sqlDuarte Duarte
2014-01-31DB/item_template: Set defaults of spellcharges_X to 0 instead of NULLMagnifikator
Closes #10748 Signed-off-by: Duarte Duarte <dnpd.dd@gmail.com>
2014-01-31Core/Achievs: Rename a few unknown achievement criteria flagsDuarte Duarte
Source tomrus88, Mangos
2014-01-31SQL: Fixed two issues with 2014_01_31_00_world_spell_custom_attr.sqlDuarte Duarte
Engine should be MyISAM and not MRG_MyISAM MySQL doesn't play nice with hex values so converted them to decimal Closes #11537
2014-01-31Core/Spells: Fix DK Ghoul's damage after ↵Discover-
ad8eb434c02e451effd0949aaa7d2b7999d91597. I misread 'SpellScript::m_damage' for 'SpellScript::damage'. By @joschiwald
2014-01-31SQL: Update old .sql files to keep consistency with auth_database.sqlDuarte Duarte
Also update characters_database.sql (generated by mysqldump)
2014-01-31Core&DB/Spells: Move custom spell attributes from code to DB, ↵Duarte Duarte
`spell_custom_attr` table `spell_custom_attr` - `entry` uint PK - `attributes` uint (enum SpellCustomAttributes of SpellInfo.h)
2014-01-30Fix warnings introduced on littleendian in ↵QAston
2134cb610d45727a0623741f7416a360882133fa This fix prevents possible issues on bigendian machines. Don't use c style casts ppl, it's evul.
2014-01-30Scripts/HoR: Fix log errorjackpoz
Fix "DoZoneInCombat called for creature that has empty threat list" error caused by DoZoneInCombat() called by IsSummonedBy() in a script before the Creature is allowed to enter combat.
2014-01-30Core/Splines: Fix "velocity > 0.1f" errorjackpoz
Updates #6191.
2014-01-30Core/Misc: Missing changes and get rid of useless method in ↵Discover-
acd46085d1f496657e27e0d5f823f53d466702dc
2014-01-30Core/Spells: drop last leftovers of hardcoded spell target selection and ↵joschiwald
move it into spellscripts Closes #1719 Closes #3186
2014-01-28DB/Creature: Fix some factionsAokromes
Updates #11501
2014-01-28DB/Creature: Fix some factionsAokromes
Updates #11501
2014-01-28DB/Creature: Fix some factionsAokromes
Updates #11501
2014-01-28DB/Creature: Fix some factionsAokromes
Updates #11501
2014-01-28DB/Creature: Fix some factionsAokromes
Updates #11501
2014-01-28DB/Creature: Typo fix.Aokromes