aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2013-09-29DB/SAI: Destroying the AltersFilip
By @untaught fixes #10841
2013-09-29DB/SAI: Hampering their EscapeFilip
By @untaught fixes #10780
2013-09-29DB/Update: Plan BFilip
By @untaught fixes #10787
2013-09-29DB/Update: Gibblewilt fear spamFilip
By @Vincent-Michael fixes #10627
2013-09-29DB/SAI: Finding the SourceFilip
By @dr-j fixes #10943
2013-09-29DB/SAI: Neltharion's Flame (12267)Filip
By @dr-j fixes #10965
2013-09-29DB/SAI: Leading the Ancestors HomeFilip
By @dr-j fixes #10783
2013-09-29Fix compile under linux and update auth db with latest changesSpp
2013-09-29Core/RBAC: Simplify RBAC implementationSpp
- Drop groups (roles than can have inherited roles) and roles (set of permissions) - Permissions can now have inherited permissions (those act as roles) RBAC DB structure is now limited to four tables - rbac_permissions: Contains permissions and roles - rbac_linked_permissions: Contains the relation between permissions and linked permissions (those permissions that have linked permissions are called roles) - rbac_default_permissions: Contains the list of permissions to be granted to each security level [Added to maintain compatibility in an easy way] - rbac_account_permissions: Contains the list of permissions granted or denied for a particular account. NOTE: IF YOU ARE USING CUSTOM PERMISSIONS, ROLES OR GROUPS CHECK THE SQL BEFORE APPLYING...
2013-09-29Tools/VMAP Extractor: Fix memory issuesjackpoz
Fix not-NULL terminated char buffer and uninitialized memory written to vmaps due to WMOLiquidHeader struct padding bytes left uninitialized. The padding bytes should be ignored anyway by VMAP Assembler so no re-extraction is required. Valgrind log: Syscall param write(buf) points to uninitialised byte(s) at 0x585FB50: __write_nocancel (syscall-template.S:81) by 0x57EE2F2: _IO_file_write@@GLIBC_2.2.5 (fileops.c:1270) by 0x57EE1D1: new_do_write (fileops.c:546) by 0x57EF904: _IO_do_write@@GLIBC_2.2.5 (fileops.c:519) by 0x57EEB70: _IO_file_xsputn@@GLIBC_2.2.5 (fileops.c:1341) by 0x57E3EC4: fwrite (iofwrite.c:43) by 0x41161B: WMOGroup::ConvertToVMAPGroupWmo(_IO_FILE*, WMORoot*, bool) (wmo.cpp:386) by 0x407FA9: ExtractSingleWmo(std::string&) (vmapexport.cpp:215) by 0x407B16: ExtractWmo() (vmapexport.cpp:138) by 0x409D50: main (vmapexport.cpp:497) Address 0x40398e2 is not stack'd, malloc'd or (recently) free'd Uninitialised value was created by a heap allocation at 0x4C2C7A7: operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x410ADA: WMOGroup::open() (wmo.cpp:224) by 0x407F54: ExtractSingleWmo(std::string&) (vmapexport.cpp:208) by 0x407B16: ExtractWmo() (vmapexport.cpp:138) by 0x409D50: main (vmapexport.cpp:497)
2013-09-29Tools/MeshExtractor: Fixed a lot of stuff, finally made the Doodads render, ↵Sebastian Valle
the WMO's have been disabled for now. ToDo: * Fix the doodads positions. * Review and re-implement some code. P.D: Help me please.
2013-09-28Tools/MapExtractor: Fix string-related memory issuesjackpoz
Fix not-NULL terminated char buffers and char[] to string conversion. Valgrind logs: Invalid read of size 1 at 0x4C2D7D4: __GI_strlen (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x5318BAF: std::basic_string<char, std::char_traits<char>, std::allocator<char> >::basic_string(char const*, std::allocator<char> const&) (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.17) by 0x409471: ReadBuild(int) (System.cpp:189) by 0x40CEC6: main (System.cpp:1108) Address 0x5f851ee is 0 bytes after a block of size 94 alloc'd at 0x4C2C037: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x40F63A: MPQFile::MPQFile(char const*) (mpq_libmpq.cpp:65) by 0x409408: ReadBuild(int) (System.cpp:182) by 0x40CEC6: main (System.cpp:1108) Invalid read of size 1 at 0x57FFCAC: strtok (strtok.S:165) by 0x40D279: MPQArchive::GetFileListTo(std::vector<std::string, std::allocator<std::string> >&) (mpq_libmpq04.h:45) by 0x40C5CF: ExtractDBCFiles(int, bool) (System.cpp:1001) by 0x40CEF5: main (System.cpp:1110) Address 0x5f91e27 is 0 bytes after a block of size 44,391 alloc'd at 0x4C2C037: operator new[](unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by 0x40D1A5: MPQArchive::GetFileListTo(std::vector<std::string, std::allocator<std::string> >&) (mpq_libmpq04.h:30) by 0x40C5CF: ExtractDBCFiles(int, bool) (System.cpp:1001) by 0x40CEF5: main (System.cpp:1110)
2013-09-28Core/Scripts: Fix uninitialized values in The Black Morassjackpoz
Valgrind log: Conditional jump or move depends on uninitialised value(s) at 0x1798C2C: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:192) by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542) by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45) Conditional jump or move depends on uninitialised value(s) at 0x1798C7E: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:200) by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542) by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45) Conditional jump or move depends on uninitialised value(s) at 0x1798CB0: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:205) by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542) by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45) Conditional jump or move depends on uninitialised value(s) at 0x1798CE2: npc_medivh_bm::npc_medivh_bmAI::UpdateAI(unsigned int) (the_black_morass.cpp:210) by 0x11AEFC0: Creature::Update(unsigned int) (Creature.cpp:542) by 0x12E96F8: Trinity::ObjectUpdater::Visit(GridRefManager<Creature>&) (GridNotifiersImpl.h:45)
2013-09-28Merge pull request #10966 from Chaplain/MeshSubv
Tools/MeshExtractor: Cleanup using static analyzing tool
2013-09-28DB/Update: Pet spellsFilip
2013-09-28DB/Update: Spawndist for creature with random movementFilip
2013-09-28Tools/MeshExtractor: Cleanup using static analyzing toolChaplain
*printf format fixed *method arguments changed to const where needed *removed not needed strlen() from cycles *other minor changes
2013-09-27Merge pull request #10963 from Tomatodev/masterSubv
Tools/MeshExtractor: Fixed an infinite loop when reading the liquid information
2013-09-27Subv's changes to mesh extractor V2Tomatoes
Signed-off-by: Tomatoes <diredarknil@gmail.com>
2013-09-27Tools/MeshExtractor: Added some debug messages.Sebastian Valle
2013-09-27Tools/MeshExtractor: Removed the fool-proof code.Sebastian Valle
2013-09-27Fix silly " that snuck in.click
2013-09-27Buildsystem/CMake: Add support for building meshextractor-project from CMake GUIclick
2013-09-27Tools/MeshExtractor: Fixed it's build, still in pre-alphaSebastian Valle
2013-09-27Core/RBAC: Add default groups to accounts based on their security level.Spp
- Removed config option RBAC.DefaultGroups Use the table rbac_security_level_groups to configure the groups to be added to the account at load time. Note: Those groups are only used at run time, never saved to DB
2013-09-27Core/RBAC: Move RBAC code to namespace rbacSpp
2013-09-27DB/Core: The Storm King's VengeanceKirkhammett
2013-09-26Core/Movement: Port Ascent r1637 ↵jackpoz
http://sourceforge.net/p/ascentemubackup/code/1637/ to TrinityCore Port some movement packet fixes, taking into account client/server connection lag. Credits to original author, check http://sourceforge.net/p/ascentemubackup/code/1637/ for more details. MOVEMENT_PACKET_TIME_DELAY default value is currently set to 0, feel free to set it to different values and report feedback.
2013-09-26DB/SAI: Wanton WarlordFilip
Fixes #5126 by @dr-j
2013-09-26DB/Update: Quest credit fix-upFilip
Vehicles will not accept quest credit in the form of a spell cast, credit needs to be a monster kill.
2013-09-25Core/Scripts: added some OVERRIDEsjoschiwald
2013-09-25Merge pull request #10933 from MitchesD/SteamVaultjoschiwald
Scripts/SteamVault: reworked InstanceScript
2013-09-25Core/SAI: Get rid of unused parameter 'storageId' (third) in ↵Discover-
SMART_ACTION_SUMMON_CREATURE. This means the 4th parameter (actionInvoker 0/1) must move back one parameter. On a clean TDB there is not a single case of this parameter being used. Updated wiki accordingly.
2013-09-24Merge branch 'master' of github.com:TrinityCore/TrinityCorejackpoz
2013-09-24Core/AI: Fix uninitialized values and array overflows in SAIjackpoz
Proper initialize POD struct members to 0 in SMART_ACTION_CREATE_TIMED_EVENT action type. Fix array overflows and access uninitialized values in SMART_ACTION_CALL_RANDOM_TIMED_ACTIONLIST, SMART_ACTION_RANDOM_PHASE and SMART_ACTION_RANDOM_EMOTE . Valgrind log for SMART_ACTION_RANDOM_PHASE case: Conditional jump or move depends on uninitialised value(s) at : SmartScript::UpdateTimer(SmartScriptHolder&, unsigned int) (SmartScript.cpp:3086) by : SmartScript::OnUpdate(unsigned int) (SmartScript.cpp:3176) by : SmartAI::UpdateAI(unsigned int) (SmartAI.cpp:335) by : Creature::Update(unsigned int) (Creature.cpp:542) by : TempSummon::Update(unsigned int) (TemporarySummon.cpp:47) Uninitialised value was created by a stack allocation at : SmartScript::ProcessAction(SmartScriptHolder&, Unit*, unsigned int, unsigned int, bool, SpellInfo const*, GameObject*) (SmartScript.cpp:143)
2013-09-24DB/SAI: Non-repeatable flags change & credit circumventionFilip
By dr-j fixes #10929 fixes #6444
2013-09-23Core/Logs: Random changesVincent-Michael
2013-09-23Scripts/SteamVault: reworked InstanceScriptMitchesD
2013-09-23Merge branch 'master' of https://github.com/TrinityCore/TrinityCoreDiscover-
2013-09-23Core/SAI: Using SMART_TARGET_NONE no longer works the same way as ↵Discover-
SMART_TARGET_ACTION_INVOKER but rather return NULL instead. Fixes #10908
2013-09-22DB/SAI: Zeth'Gor Must Burn!Filip
Fixes #10904 by @untaught
2013-09-22Merge pull request #10875 from zorix/PR2Shauren
Core/Script:
2013-09-22Core/Script:zorix
ICC: Convert possible non valid pointer to guid Close #9954
2013-09-21DB/SAI: Eyes of GrillokFilip
By @dr-j fixes #10909
2013-09-21Scripts/ScarletEnclave: Fix uninitialized values in Highlord Darion Mograinejackpoz
Reset() has if checks on values that are initialized after them so it's required to initialize these fields in the constructor. Valgrind log: Conditional jump or move depends on uninitialised value(s) by 0x11CF472: HashMapHolder<Creature>::Find(unsigned long) (ObjectAccessor.h:67) by 0x11CE36F: Creature* ObjectAccessor::GetObjectInWorld<Creature>(unsigned long, Creature*) (ObjectAccessor.h:114) by 0x1257C13: Creature* ObjectAccessor::GetObjectInMap<Creature>(unsigned long, Map*, Creature*) (ObjectAccessor.h:135) by 0x12E64F1: Map::GetCreature(unsigned long) (Map.cpp:2767) by 0x10AF4DE: Unit::GetCreature(WorldObject&, unsigned long) (Unit.cpp:13021) by 0x16F8F81: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::Reset() (chapter5.cpp:386) by 0x16F8D36: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::npc_highlord_darion_mograineAI(Creature*) (chapter5.cpp:314) by 0x16F8CD6: npc_highlord_darion_mograine::GetAI(Creature*) const (chapter5.cpp:307) by 0x132AF6C: ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:796) by 0x1441D45: FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
2013-09-21Core/Guild: Fix withdraw money from bank overflowing int32 limitjackpoz
Clamp amount of money withdrawn from bank to MAX_MONEY_AMOUNT to avoid int32 overflow which would remove money from Player instead of adding it.
2013-09-21Core/DB: Make a26a24a consistent with Trinity code stylejackpoz
Change DatabaseWorkerPool<T>::DirectExecute() to handle PreparedStatement disposal in the same way of DatabaseWorkerPool<T>::Query() , thanks Joschiwald for patch.
2013-09-21Core/AccountMgr: Fix memory leak on account creationjackpoz
Fix .account create command not deleting a MySql PreparedStatement . Valgrind log: 254 (40 direct, 214 indirect) bytes in 1 blocks are definitely lost in loss record 6 of 8 at 0x4C24DFA: operator new(unsigned long) (vg_replace_malloc.c:261) by 0x998EC2: DatabaseWorkerPool<LoginDatabaseConnection>::GetPreparedStatement(unsigned int) (DatabaseWorkerPool.h:437) by 0x99599B: AccountMgr::CreateAccount(std::string, std::string, std::string) (AccountMgr.cpp:49) by 0xF3ABAC: account_commandscript::HandleAccountCreateCommand(ChatHandler*, char const*)
2013-09-21Core/SAI: Make SMART_ACTION_RANDOM_MOVE also work with SMART_TARGET_NONE and ↵Discover-
non-creature targets (if a non-creature target_type is specified and no creature target was found, the action is fired at the source) Ref. #7431
2013-09-21Core/PathGenerator: Fix conditional jump on uninitialized valuejackpoz
Fix conditional jump on uninitialized value in PathGenerator::GetNavTerrain() by checking the result of getLiquidStatus() before accessing the LiquidData, uninitialized in case there's no water at all. Valgrind log: Conditional jump or move depends on uninitialised value(s) at : PathGenerator::GetNavTerrain(float, float, float) (PathGenerator.cpp:553) by : PathGenerator::UpdateFilter() (PathGenerator.cpp:542) by : PathGenerator::CreateFilter() (PathGenerator.cpp:530) by : PathGenerator::PathGenerator(Unit const*) (PathGenerator.cpp:46) by : Spell::Spell(Unit*, SpellInfo const*, TriggerCastFlags, unsigned long, bool) (Spell.cpp:493) by : Unit::CastSpell(SpellCastTargets const&, SpellInfo const*, CustomSpellValues const*, TriggerCastFlags, Item*, AuraEffect const*, unsigned long) (Unit.cpp:846) by : Unit::CastSpell(Unit*, SpellInfo const*, TriggerCastFlags, Item*, AuraEffect const*, unsigned long) (Unit.cpp:882) by : Unit::CastSpell(Unit*, unsigned int, TriggerCastFlags, Item*, AuraEffect const*, unsigned long) (Unit.cpp:870) by : Unit::CastSpell(Unit*, unsigned int, bool, Item*, AuraEffect const*, unsigned long) (Unit.cpp:858) by : Player::SendInitialPacketsAfterAddToMap() (Player.cpp:22580) by : WorldSession::HandleMoveWorldportAckOpcode() (MovementHandler.cpp:121) by : WorldSession::HandleMoveWorldportAckOpcode(WorldPacket&) (MovementHandler.cpp:37)