aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-05-19Core/Misc: Removed remnants of old db threading modelShauren
2014-05-19Merge pull request #12082 from MitchesD/misc_2joschiwald
Scripts/Krystallus: converted to EventMap, removed useless code
2014-05-18Revert "Core/Logging: Use logger cache for speed up logger filter search"jackpoz
This reverts commit 39331ea7b9e906b67378a1be6c0c694d264eda3a. This is required to fix a race condition introduced with the logger cache. Adding a locking mechanism might make worthless the speed gain added by the cache itself, push a proper thread-safe implementation if it's worth it. Helgrind log: Possible data race during write of size 8 at 0x736F428 by thread #1 Locks held: none at 0x11872DF: std::_Hashtable<std::string, std::pair<std::string const, Logger const*>, std::allocator<std::pair<std::string const, Logger const*> >, std::__detail::_Select1st, std::equal_to<std::string>, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_insert_bucket_begin(unsigned long, std::__detail::_Hash_node<std::pair<std::string const, Logger const*>, true>*) (hashtable.h:1196) by 0x11865A1: std::_Hashtable<std::string, std::pair<std::string const, Logger const*>, std::allocator<std::pair<std::string const, Logger const*> >, std::__detail::_Select1st, std::equal_to<std::string>, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_insert_unique_node(unsigned long, unsigned long, std::__detail::_Hash_node<std::pair<std::string const, Logger const*>, true>*) (hashtable.h:1342) by 0x1185A48: std::__detail::_Map_base<std::string, std::pair<std::string const, Logger const*>, std::allocator<std::pair<std::string const, Logger const*> >, std::__detail::_Select1st, std::equal_to<std::string>, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true>, true>::operator[](std::string const&) (hashtable_policy.h:496) by 0x1184F3A: std::unordered_map<std::string, Logger const*, std::hash<std::string>, std::equal_to<std::string>, std::allocator<std::pair<std::string const, Logger const*> > >::operator[](std::string const&) (unordered_map.h:596) by 0x1184495: Log::GetLoggerByType(std::string const&) (Log.h:106) by 0x1184527: Log::ShouldLog(std::string const&, LogLevel) (Log.h:112) by 0x16E7121: World::LoadConfigSettings(bool) (World.cpp:909) by 0x16EB623: World::SetInitialWorldSettings() (World.cpp:1276) by 0x118F0EC: Master::Run() (Master.cpp:169) by 0x1196AFF: main (Main.cpp:142) This conflicts with a previous read of size 8 by thread #3 Locks held: none at 0x1186EA6: std::_Hashtable<std::string, std::pair<std::string const, Logger const*>, std::allocator<std::pair<std::string const, Logger const*> >, std::__detail::_Select1st, std::equal_to<std::string>, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_before_node(unsigned long, std::string const&, unsigned long) const (hashtable.h:1162) by 0x1186263: std::_Hashtable<std::string, std::pair<std::string const, Logger const*>, std::allocator<std::pair<std::string const, Logger const*> >, std::__detail::_Select1st, std::equal_to<std::string>, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::_M_find_node(unsigned long, std::string const&, unsigned long) const (hashtable.h:604) by 0x11857B9: std::_Hashtable<std::string, std::pair<std::string const, Logger const*>, std::allocator<std::pair<std::string const, Logger const*> >, std::__detail::_Select1st, std::equal_to<std::string>, std::hash<std::string>, std::__detail::_Mod_range_hashing, std::__detail::_Default_ranged_hash, std::__detail::_Prime_rehash_policy, std::__detail::_Hashtable_traits<true, false, true> >::find(std::string const&) (hashtable.h:1025) by 0x1184DE2: std::unordered_map<std::string, Logger const*, std::hash<std::string>, std::equal_to<std::string>, std::allocator<std::pair<std::string const, Logger const*> > >::find(std::string const&) (unordered_map.h:543) by 0x11842EF: Log::GetLoggerByType(std::string const&) (Log.h:84) by 0x1184527: Log::ShouldLog(std::string const&, LogLevel) (Log.h:112) by 0x189AACA: MySQLConnection::Execute(char const*) (MySQLConnection.cpp:175) by 0x18A3225: BasicStatementTask::Execute() (AdhocStatement.cpp:56) Address 0x736F428 is 120 bytes inside a block of size 184 alloc'd at 0x4C2AE3A: operator new(unsigned long, std::nothrow_t const&) (vg_replace_malloc.c:350) by 0x1185046: ACE_Singleton<Log, ACE_Thread_Mutex>::instance() (Singleton.cpp:91) by 0x11968E2: main (Main.cpp:135)
2014-05-18Revert "Core/Logging: store loggers in cache correctly"jackpoz
This reverts commit c6a4d5a1de1c8e9c7722a5a13695d1273b8cbfbc.
2014-05-18Core/Calendar: Fix warningjackpoz
Fix warning added b6048f89f7456ab683901f12ea4f90ac5d23be70 about signed/unsigned comparison mismatch
2014-05-18Scripts/Krystallus: converted to EventMap, removed useless codeMitchesD
2014-05-18Partially revert f296095191c7b5c6b10f79c2b1433dc227a462f5 "Fix various ↵Shauren
warnings. The core, the scripts and the tools now compile without warnings with -Wall -Wextra -pedantic." Visual studio does not support constexpr Made semicolon after "Prepare*Script" mandatory - workaround for dumb IDEs inserting extra indentation level after newline
2014-05-18Update 2014_05_18_04_world_misc.sqlAokromes
2014-05-18Update 2014_05_18_04_world_misc.sqlAokromes
2014-05-18DB/Spawns: Myralion Sunblaze Frozen Halls spawnsAokromes
By Foldy, closes #11899
2014-05-18Rename 2014_05_18_02_world_gameobject.sql to ↵Aokromes
2014_05_18_02_world_gameobject.sql
2014-05-18DB/Misc: Nesingwary Lackey EarAokromes
By nelegalno, closes #8624
2014-05-18DB/Gameobject: Thunderbrew Lager KegAokromes
By Foldy, closes #12078
2014-05-18DB/Creature: Ethereal Soul-TraderAokromes
By Foldy, closes #12080 updates #4152
2014-05-17Merge pull request #12071 from Praetonus/warningsSebastian Valle Herrera
Fix various warnings.
2014-05-18DB/Creature: Highlord Darion Mograine - Restore Shadow's Edge gossipAokromes
By Foldy, closes #12079
2014-05-17Merge pull request #12070 from Trisjdc/more_saiSebastian Valle Herrera
Core/SAI: Prevent nullifying damage, because of player damage requirements
2014-05-18Shared/Packets: Handle crash by throwing an exception insteadjackpoz
Throw a ByteBufferException when trying to access the first element of an empty ByteBuffer class
2014-05-18Core/Warden: Fix crashjackpoz
Fix crash with empty CMSG_WARDEN_DATA packets
2014-05-17Shared/Database: Increase Database Worker Pool queue sizejackpoz
Increase DatabaseWorkerPool queue size from the default 16KB to 8MB to avoid blocking the caller thread when queuing an async statement/transaction.
2014-05-17Fixed build without pchShauren
2014-05-17Core/Calendar: Align max amount of Players to be invited to Client limitsjackpoz
Limit the max amount of Players to be invited to a Calendar event to 100, same limit as the one in the Client
2014-05-17Core/Calendar: Use single database transaction for adding multiple invites ↵Shauren
when creating new event
2014-05-17Core/GameObjects: fixed instant reset of gameobjects after activationjoschiwald
2014-05-17Contrib: Added an updated version of the configuration file merger tool.Warpten
This one lets you choose which value to keep between the two configuration files. Make sure to carefully read the file's lines 3 to 9 to make sure you don't misuse it and get back at me later raging. It is not exactly as I would like it to be, but current state will have to do. You can try it out live at: http://tinyurl.com/kzxmrlm
2014-05-15Remove changes in dep file.Praetonus
2014-05-15Fix various warnings. The core, the scripts and the tools now compile ↵Praetonus
without warnings with -Wall -Wextra -pedantic. -Fix warnings from -Woverflow on implicit constant conversion. -Fix warnings from -pedantic. -Fix warnings from -pedantic. -Fix warnings from -Wformat. Two minor changes in addition : -Replace a defined value equal to 2^31 - 1 by std::numeric_limits<int>::max(). -Remove useless null-check on pointer returned by new. New doesn't returns nullptr on failure, it throws std::bad_alloc.
2014-05-15Core/SAI: Prevent nullifying damage, because of player damage requirementsTrisjdc
2014-05-14Core/Misc: Fix crash in ticket creationjackpoz
Fix a crash happening with malicious CMSG_GMTICKET_CREATE packets.
2014-05-13Merge pull request #12021 from Trisjdc/spell_target_destjackpoz
Core/Spells: Replace MovePosition by MovePositionToFirstCollision in spell dest target handling.
2014-05-13Merge pull request #12058 from Trisjdc/sunwelljackpoz
Scripts/SWP: Sathrovarr will no longer cause player teleports on grid load
2014-05-13Scripts/SWP: Sathrovarr will no longer cause player teleports on grid loadTrisjdc
2014-05-13DB/Conditions: Fix startup error added on 018da66Aokromes
2014-05-12Core/Arena: Fix exploit in arena teamjackpoz
Fix exploit that allowed anyone to add a target Player to any arena team.
2014-05-12Core/Misc: Fix static analysis issuesjackpoz
Fix uninitialized values spotted by coverity. Remove unused "dynamic analysis" code, use Valgrind or another dynamic analysis tool instead if needed.
2014-05-12DB/Creature: Fix Antipersonnel Cannon (1) immune maskAokromes
Closes #11944, by gecko32
2014-05-12Move file 2014_05_12_00_world_misc.sqlAokromes
2014-05-12DB/Creature: Fix Argent Tournament VendorsAokromes
By dr-j, closes #10351
2014-05-12Merge pull request #12050 from Trisjdc/u_liek_fish_questionmarkDiscover-
Core/Spells: Fix fishing on areas with liquid data but no valid height
2014-05-11DB/Gameobjects: Updated the VerifiedBuild of some gameobjectsKinzcool
2014-05-11Scripts/HoR: fixed conflict between multiple classes with same namejoschiwald
Closes #12051
2014-05-11Core/Spells: Fix fishing on areas with liquid data but no valid heightTrisjdc
2014-05-11Script/ICC: Use existing method for getting GO auto-close-timeGacko
2014-05-11Merge branch 'master' of github.com:TrinityCore/TrinityCoreGacko
2014-05-11Core/GameObject: Set trap type 0 back to GO_READY after activation.Gacko
Otherwise it would be activated again on every update. My fault, moving the activation code to GO_ACTIVATED skips the cooldown check. Closes #12047
2014-05-11DB/Gameobjects: Fixed Gymer's cage phasemask to make it appear while doing ↵Kinzcool
"The Storm King's Vengeance" quest
2014-05-11DB: Changed WDBVerified startdard to VerifiedBuildKinzcool
2014-05-11DB/Gameobjects: Added some missing gameobjects spawnsKinzcool
2014-05-10Merge pull request #11960 from MitchesD/horjoschiwald
Scripts/HallsOfReflection: Major changes
2014-05-10Scripts/HallsOfReflection: Major changesMitchesD
* corrections to Intro Event (Falric, Marwyn etc.) * fixed issues with Frostsworn General * improved the whole Wrath of the Lich King event * implemented outro gunship * optimalization code and cleanup and fixed some typos * Big thanks to @joschiwald, he is author too ;-)