aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2012-03-27Core/DBLayer: Correct few more wrong read types (No. 2)Nay
DB/World: Some consistency in the ints "length" field (not really a length) From A to G world tables verified; missing all the others
2012-03-27Merge pull request #5811 from Elron103/pull-requests3click
Core/Units: Fix issues with threat management on phase changes This is the cleaner version of the two suggested on pull-requests, and handles the threatlist correctly as well.
2012-03-27Core/Spells: fix the issue with dispel auras. (thx warpten) closes #5902Kandera
2012-03-27Core/Misc: Make World::m_stopEvent thread-safe. Note that the 'virtual' ↵Machiavelli
keyword in C/C++ is pretty useless for multithreading
2012-03-27Core/DB Layer: Fix helgrind errors on some concurrent access to resultset ↵Machiavelli
auto pointers. Example: ==8753== Possible data race during read of size 8 at 0x2e803e60 by thread #8 ==8753== at 0xDD0FFC: PreparedResultSet::operator[](unsigned int) const (QueryResult.h:83) ==8753== by 0x131D82D: WorldSession::HandleCharEnum(Trinity::AutoPtr<PreparedResultSet, ACE_Null_Mutex>) (CharacterHandler.cpp:217) ==8753== by 0x118F8C3: WorldSession::ProcessQueryCallbacks() (WorldSession.cpp:1087) {..} ==8753== Address 0x2e803e60 is 0 bytes inside a block of size 16 alloc'd ==8753== at 0x4C28B75: operator new(unsigned long) (vg_replace_malloc.c:261) ==8753== by 0x137D515: __gnu_cxx::new_allocator<Field*>::allocate(unsigned long, void const*) (new_allocator.h:92) ==8753== by 0x137D378: std::_Vector_base<Field*, std::allocator<Field*> >::_M_allocate(unsigned long) (in /home/aokromes/bin/bin/worldserver) ==8753== by 0x137CEC6: std::vector<Field*, std::allocator<Field*> >::_M_fill_insert(__gnu_cxx::__normal_iterator<Field**, std::vector<Field*, std::allocator<Field*> > >, unsigned long, Field* const&) (vector.tcc:416) ==8753== by 0x137CB27: std::vector<Field*, std::allocator<Field*> >::insert(__gnu_cxx::__normal_iterator<Field**, std::vector<Field*, std::allocator<Field*> > >, unsigned long, Field* const&) (stl_vector.h:944) ==8753== by 0x137C964: std::vector<Field*, std::allocator<Field*> >::resize(unsigned long, Field*) (stl_vector.h:632) ==8753== by 0x137BFCA: PreparedResultSet::PreparedResultSet(st_mysql_stmt*, st_mysql_res*, unsigned long, unsigned int) (QueryResult.cpp:98) ==8753== by 0x137A12B: MySQLConnection::Query(PreparedStatement*) (MySQLConnection.cpp:493) ==8753== by 0x137F663: PreparedStatementTask::Execute() (PreparedStatement.cpp:412) Have a feeling this is a false positive, though. Nevertheless good to get rid of.
2012-03-27Core/DB Layer: - Fix "Thread #1 unlocked a not-locked lock at 0x6D56E90" ↵Machiavelli
helgrind error (thanks to Aokromes for logs). Cause was unlocking MySQL connection on shutdown, but concurrent access at this point is not required. - Remove redundant locking in PingOperation. Since these are delayed to async threads with their own MySQL connection, no concurrent access here either. - Codestyle cleanup - Documentation refining
2012-03-27Core/Groups: Remove redundant check in WorldSession::HandleLootRollShocker
2012-03-27Core: Remove the MersenneTwiser-library (SFMT is now considered stable ↵click
enough for full deployment)
2012-03-27Core/DBLayer: Correct few more wrong read types (No. 1)Nay
DB/World: Some consistency in the ints "length" field (not really a length) From A to D world tables verified; missing all the others int(11) -> int32 unsigned int(10) -> uint32 mediumint(8) -> int32 unsigned mediumint(8) -> uint32 smallint(6) -> int16 unsigned smallint(5) -> uint16 tinyint(4) -> int8 unsigned tinyint(3) -> uint8
2012-03-26Core/DBLayer: Fix `creature` and `spell_rank` loadingNay
2012-03-26Core/Spells: and another mistake from the misdirection fix >.>kandera
2012-03-26DB/Auth: Update auth_database.sql with recent changesNay
2012-03-26Core/DBLayer: Typo from prev. commitleak
2012-03-26Core/DBLayer: Restore pet loadingleak
closes #5878
2012-03-26Core/Spells: one more miss from misdirection fixKandera
2012-03-26Core/Spells: Added sql for misdirection fix (thx dasio)Kandera
2012-03-26Core/Spells: Fix Necrotic Touch proc closes #538Kandera
2012-03-26Core/Spells: Fix Misdirection (thx to elron) closes #5869, #4343Kandera
2012-03-26Core/DBLayer: Convert PAppend() queries to prepared statements No.4 NOTE:leak
Most of the cores queries have been converted to prepared statements now. If your code contains queries, please either use the exiting or implement new statements. The only exclusions are one-time queries (e.g. for core startup) and queries that can't be prepared due to limitations.
2012-03-26DB/Creature Template: Some updates, mostly HoverHeight and InhabitType. ↵Machiavelli
Thanks to KingPin for re-parsing ~5GB of sniffs.
2012-03-26Partial revert of "Core/DB Layer: Fix a memory leak.", mysql library related ↵Machiavelli
stuff. Original memory leak fix is still in place.
2012-03-26Core/DB Layer: Fix a memory leak for synchronously executed prepared statements.Machiavelli
2012-03-26Core/DB Layer: Fix a memory leak.Machiavelli
2012-03-26Auth/Realmlist: Make use of RealmFlags and rename color to flag (core- and ↵kaelima
dbwise) Also fix connecting with realmflag & 4
2012-03-26Fix compile and fix a possible crash for mob_kiljaeden_controllerkaelima
2012-03-26Core/CombatLog:kaelima
- Send more proper hitinfo values in SMSG_ATTACKERSTATEUPDATE (still lot of research todo) - Some renaming and commenting - Minor cleanup in Player::UpdateZone
2012-03-26Core/Spells: Don't remove summoned gameobjects for non-channeled spells when ↵Shocker
spell cast was canceled Fixes issues like Demonic Circle: Summon removing the last summoned circle when the new cast was canceled
2012-03-26Core/DB Layer: Make SQLTransaction AutoPtr thread safe (valgrind caught a ↵Machiavelli
race condition)
2012-03-26Core/Misc: Fix logic for owner check in Unit::RemoveGameObjectShocker
2012-03-25Core/Player: Fixed accessing possibly deallocated memoryShauren
2012-03-25DB/Auth: Update auth_database.sql with recent changesNay
DB/GameEvent: Resync Darkmoon, again - by Aokromes
2012-03-25Core/DBLayer: Restore pinfo ban info outputleak
2012-03-25Core/Misc: Implement Trinity::Auto_Ptr. Ditches ACE_Refcounted_AutoPtr (we ↵Machiavelli
strongly suspect it does NOT clean up the underlying pointer properly). Underlying type is now ACE_Strong_Bound_Ptr
2012-03-25Core/AchievementMgr: We heard you like uninitialized variables so... we ↵Shauren
initialized them for you so you can hate us
2012-03-25Core/DBLayer: Convert PAppend() queries to prepared statements No.3leak
2012-03-25Core/Players: Use correct size in variablesSubv
2012-03-25Core/DBLayer: Use correct Get method in some DB fieldsSubv
2012-03-25Core/DBLayer: Convert PAppend() queries to prepared statements No.2leak
2012-03-25Buildsystem/CMake: Add the ability to avoid linking the core with jemalloc ↵click
on linux through using the -DNOJEM parameter. WARNING: This is a developer flag only, and as such NOT documented elsewhere - we need this for valgrind and related tools. Again : YOU HAVE BEEN WARNED! DO NOT USE THIS FLAG UNLESS YOU REALLY KNOW WHAT YOU ARE DOING!
2012-03-25Core/DBLayer: Typo on query conversionleak
2012-03-25Core/DBLayer: Convert PAppend() queries to prepared statements No.1leak
2012-03-25Memory: Get rid of some memory leaks, converted FormationMgr back to singletonSubv
2012-03-25Update src/server/shared/Database/Field.hMachiavelli
2012-03-25Core/DBLayer: Refine field type checks in Field::GetXXX methods. Should give ↵Machiavelli
us logs of wrong GetXXX calls for a certain type without having to dig trough valgrind logs.
2012-03-25Core/TicketMgr: Remove a memory leak in RemoveTicket. Spotted by SubvMachiavelli
2012-03-25Core: Remove an annoying memoryleak in OutdoorPVPMgr (Patch by Raczman)click
2012-03-24Merge pull request #5870 from Elron103/pull-requests5leak
Core: Fix warnings
2012-03-24Core/DBLayer: Few more type correctionsNay
Closes #5871
2012-03-25Core/DBLayer: Restore pinfo timestamp output (Prepared statment results ↵leak
don't deliver TIMESTAMP as string)
2012-03-24Core: Fix .pinfo handling of player level and securitylevel after recent ↵click
cleanups (and clean up my last commit)