aboutsummaryrefslogtreecommitdiff
path: root/src/server/scripts
AgeCommit message (Collapse)Author
2021-05-17Scripts/World: New target dummy AI, because I don't trust the existing one ↵Treeston
in light of #21187. (cherry picked from commit a23c97a0fcc53e5da0bee5fc033dd3748774c337)
2021-05-16Scripts/Commands: New command: .debug threatinfoTreeston
(cherry picked from commit f45c211987794ff7e4192e0d3d4ca6bf67335fb5)
2021-05-169ad11e6 follow-up, prevent Halion respawn without lootTreeston
tagging #21198 (cherry picked from commit f0a394753ad9f1614fd696027c51ed2e297a02f6)
2021-05-16Core/Threat: Fix a potential exploit allowing players to damage a boss ↵Treeston
without them taking damage. Scripts/Halion: General cleanup of old hacks no longer needed under new combat system. (cherry picked from commit 9ad11e67fb6b410f18031ee68259866ea1354c8c)
2021-05-16Core/Map: New Map::ForceRespawn to override objections and force a respawn ↵Treeston
(equivalent to force = true). Use this to fix various GM commands. Scripts/Valithria: Fix an issue that could get the encounter stuck in an unloaded state. (cherry picked from commit 3bb33e3108c65ba8a1c35b934526562aa542b63b)
2021-05-16Core/Units: Remove Unit::EnergizeBySpell overload taking spellId argumentShauren
2021-05-16Core/Scripts: Remove deprecated overload of QuestReward without LootItemType ↵Shauren
argument
2021-05-16Core/Combat: Some more sanity check asserts to try and track down #21187.Treeston
Also, some anti-annoyance treatment for dot tele. (cherry picked from commit fdacf127395965b426185f05a7b1351138775e89)
2021-05-16MovementInform should overridesMoein
(cherry picked from commit 18f5eae835a0045d1180262bfcc4a2e6cf97c807)
2021-05-16Core/Misc: A variety of clean-up changes, mostly following up on 532ab1c to ↵Treeston
fix legacy bugs exposed by it: - Triggers can no longer have a threat list (this may expose some ugliness in old legacy scripts) - Threat entries are forced to OFFLINE if the AI refuses to attack the target - Clean up passive creature evade behavior to be more consistent - Fix a months old issue in spawn group management that would cause "Inactive" to incorrectly show in .list respawns for system groups outside of map 0 - Valithria script cleanups, remove old hacks and make it work with the new system. Closes #21174. - Some strings cleanup (cherry picked from commit 9f9507e6a1fd50a5ce643a4096c1712700244a61)
2021-05-16Core: Combat/threat system rewrite (PR #19930)Treeston
- PvE combat is now always mutual. UNIT_FLAG_IN_COMBAT is backed by actual references to the units we're in combat with. - PvP combat is now also tracked, and almost always mutual; spells like Vanish and Feign Death can break this rule. That means we can easily determine a list of players we're fighting. - By extension, IsInCombatWith now has sensible behavior when invoked on nonplayers. - Threat and combat systems are no longer the same. - They still have an enforced relationship (threat implies combat - clearing combat clears threat)... - ...but we can have combat without threat. A creature (with threat list) isn't considered to be engaged until it has an entry on its threat list... - ...which means we can now faithfully replicate retail engage behavior. Combat on projectile launch - engagement start on projectile impact. Yay for progress! - AI method refactor, as already ported in 6113b9d - `JustEngagedWith`, `JustEnteredCombat` and `JustExitedCombat`. - Vehicle threat is now properly pooled on the main vehicle body (fixes #16542). - Various edge case bug fixes for threat redirects (Misdirection "cancelling" Vigilance and similar). - Target re-selection is now significantly faster. - Fixed a ton of other smaller edge case bugs, probably. Closes #7951 and #19998. (cherry picked from commit 532ab1c7f8653d1a2e48aa1f1f8a9ba1041d4bb7)
2021-05-15Scripts/Spells: Clear arcane charge damage/cost/cast time modifier aura when ↵Shauren
reaching 0 arcane charges (power)
2021-05-15Scripts/Spells: Remove manual damage adjustment from Arcane Barrage for ↵Shauren
scaling with arcane charges and use spell cast for mana energize
2021-05-15Scripts/Spells: Properly utilize all Arcane Explosion energize effectsShauren
2021-05-15Scripts/Spells: Fixed arcane barrage + explosionMatan Shukry
2021-05-12Core/Scenes: Fix scenes played by package id storing pointers to stack variablesShauren
2021-05-11Core/Commands: Add ItemContext argument to .additem and .additemset commandsShauren
2021-05-09Core/Quests: Quest improvementsShauren
* Add quest log slot argument to functions dealing with objective progress * Implemented QUEST_OBJECTIVE_FLAG_SEQUENCED (prevent progressing hidden objectives)
2021-05-06Core/Scripts: fix Millhouse Manastorm resetting dialogs after Skyriss encounterariel-
Closes #21159 (cherry picked from commit fd7fff80c9ce9954c58fa3fa35eadcdfe5648e3d)
2021-05-06Core/Scripts: cast "Trial of the Naaru: Tenacity" credit spell when criteria ↵ariel-
is achieved Closes #21155 (cherry picked from commit 036a05458eb90f137326885651dec05b303116f9)
2021-05-06Core/Scripts: fixed npc immunity flags during Harbinger Skyriss encounterariel-
- Added missing _Reset - Properly register Skyriss summons in SummonList Closes #21154 Who ordered up an extra large can of whoop-ass? (cherry picked from commit f8b148c3346e6d5017bf3b044cc36bce32c0cf45)
2021-05-06Core/Scripts: Implemented Shifting Naaru Sliverariel-
(cherry picked from commit a5d4f34c3158bbbd65436bd2bd1dd8a9fad1ff52)
2021-05-06Core/Scripts: fix issues with 'Squeeze' on Yogg-Saron encounterariel-
- Unassigned spell script for 25-man difficulty - Didn't remove aura on 25-man when tentacle killed (cherry picked from commit de3fd4d076a1d02c5b75ab5d2f32bfb7ecb202a5)
2021-05-03Core/Chat: Allow incorrect spell/skill language assignments to mirror client ↵Shauren
behavior
2021-05-03Core/Chat: Load chat language data from db2 and implement serverside chat ↵Matan Shukry
translations
2021-04-22Scripts/Spells: Implemented monk stagger (#26295)Matan Shukry
2021-04-21Scripts/Spells: Implemented discipline priest PvP talent TrinityShauren
2021-04-21Scripts/Spells: Implemented AtonementMatan Shukry
* Also renamed spell_priest_spirit_of_redemption to spell_pri_spirit_of_redemption
2021-04-19Core/Spells: Implement priest holy words + modify cooldown for a charge (#26270)Matan Shukry
Co-authored-by: Shauren <shauren.trinity@gmail.com>
2021-04-17Core/Auras: Implemented SPELL_AURA_SCHOOL_ABSORB_OVERKILL (#26269)Matan Shukry
2021-04-16Core/Misc: Removed unneeded checksjackpoz
(cherry picked from commit 513e153a135ab51941fafe452aaa4e91faa285a0)
2021-04-16Core/AI: Some more refactoring prep for #19930. CreatureAI::EnterCombat is ↵Treeston
now called CreatureAI::JustEngagedWith. There's also two new methods on UnitAI, though they're never invoked right now. (cherry picked from commit 6113b9dec2e0081c36c36c2974a28ed0693bc601)
2021-04-16[3.3.5] CastSpell unclusterfucking (that's a word now) (#21123)Treeston
Core/Spell: The giant CastSpell unclusterfucking (that's a word now) of this generation. - CastSpell now always takes three arguments - target, spellId, and a struct containing extra arguments - This struct (CastSpellExtraArgs, see SpellDefines.h) serves as a conglomerate of every previous combination of the 20 billion different CastSpell overloads, all merged into one - It has some great utility constructors - check them out! All of these can be used to implicitly construct the ExtraArgs object. - A gajillion refactors to make everything behave the way it always has (cherry picked from commit d507a7e3388382960108b24143da48e5f912b4a7)
2021-04-15Core/Entities: Fix some weird movement due to los issues (#21125)Jeremy
* Core/Entities: Fix some weird movement due to los issues - Made LoS check use collisionHeight instead of midsection. Value was too low. - Gnomes will now have a breath bar more quickly than for example a tauren. - Changes have been made to checking for ground z as well, some tweeking might be needed but removed most of the scattered +2.0f/+0.5f/we * Add 0.05f to isInAir check in Creature::UpdateMovementFlags (cherry picked from commit e42903ec16f4849b71bc8736e3151a1e11d3cd25)
2021-04-15Core/Scripts: fix codestyleariel-
(cherry picked from commit e2a97ba7e789748aaa46ace153382573fd7d7df5)
2021-04-15Core/Scripts: Val'anyr Hammer of Ancient Kings should proc only with ↵Keader
effective heal (cherry picked from commit 502864e86c0a29ac4e64b20ee0c2e853cecd0401)
2021-04-15Core/Scripts: remove Quel'Delar from player inventory during "The Halls Of ↵ariel-
Reflection" quests (24480, 24561) (cherry picked from commit d13999c8d6a390914907d1d8343d72c06195bf10)
2021-04-15Core/Scripts: prevent Arthas in CoS losing his gossip flag and halting ↵ariel-
instance progress (cherry picked from commit 720ba9e973f7af5a84d7e61a1eaa716a65f41e92)
2021-04-15Core/Scripts: fixed Festergut applying more than one stack of Inoculated at onceariel-
(cherry picked from commit c409ba8d9d570514bce3cdbaa756ae989ab06146)
2021-04-15Core/AI: Making guid const& in SetGUID method (#21128)Keader
(cherry picked from commit 465b43fabef1727432ddda27f04b882b29fd2c7f)
2021-04-15Core/Misc: Fix static analysis issuesjackpoz
(cherry picked from commit ad56299846a92c2cda84ebcc2d37d9aa6e3e8024)
2021-04-15Scripts/Trial of Crusader: Fix static analysis issuesjackpoz
(cherry picked from commit cbc7642edd4a45068636adb98d74332837ab4c71)
2021-04-15Core/Misc: Replace time(NULL) with GameTime::GetGameTime()jackpoz
(cherry picked from commit 12701cb0c6c45eb105ad449eb9a56e76d84d691e) Conflicts: src/server/game/Achievements/AchievementMgr.cpp src/server/game/AuctionHouse/AuctionHouseMgr.cpp src/server/game/AuctionHouseBot/AuctionHouseBotBuyer.cpp src/server/game/AuctionHouseBot/AuctionHouseBotSeller.cpp src/server/game/Battlefield/Battlefield.cpp src/server/game/Battlefield/Zones/BattlefieldWG.cpp src/server/game/Battlegrounds/BattlegroundMgr.cpp src/server/game/Calendar/CalendarMgr.h src/server/game/DungeonFinding/LFGQueue.cpp src/server/game/Entities/Corpse/Corpse.cpp src/server/game/Entities/Creature/Creature.cpp src/server/game/Entities/Item/Item.cpp src/server/game/Entities/Pet/Pet.cpp src/server/game/Entities/Player/Player.cpp src/server/game/Entities/Unit/Unit.cpp src/server/game/Globals/ObjectMgr.cpp src/server/game/Grids/ObjectGridLoader.cpp src/server/game/Guilds/Guild.cpp src/server/game/Handlers/AuctionHouseHandler.cpp src/server/game/Handlers/BattlefieldHandler.cpp src/server/game/Handlers/CalendarHandler.cpp src/server/game/Handlers/CharacterHandler.cpp src/server/game/Handlers/ChatHandler.cpp src/server/game/Handlers/LFGHandler.cpp src/server/game/Handlers/MailHandler.cpp src/server/game/Handlers/MiscHandler.cpp src/server/game/Handlers/MovementHandler.cpp src/server/game/Handlers/PetHandler.cpp src/server/game/Handlers/QueryHandler.cpp src/server/game/Handlers/TicketHandler.cpp src/server/game/Instances/InstanceSaveMgr.cpp src/server/game/Server/WorldSession.cpp src/server/game/Server/WorldSocket.cpp src/server/game/Spells/Auras/SpellAuras.cpp src/server/game/Tickets/TicketMgr.cpp src/server/game/Tickets/TicketMgr.h src/server/game/World/World.cpp src/server/scripts/Commands/cs_gobject.cpp src/server/scripts/Commands/cs_instance.cpp src/server/scripts/Commands/cs_list.cpp src/server/scripts/Northrend/zone_wintergrasp.cpp src/server/scripts/Spells/spell_item.cpp
2021-04-15Scripts/Trial of Crusader: Northrend Beasts Rework (#21031)Keader
* Rewritten Gormok encounter * Rewritten Snobold Vassal Script * Rewritten Jormungars encounter * Rewritten Icehowl encounter * Added missing texts * Added missing spells * Implemented berserk mechanic on heroic diffs. * Implemented Achievement requirement to make heroic diffs. * Rewritten Barrett Ramsay scripts * Added Barrett gossips and ported everything to DB. * Added right Barrett in each encounter * Removed a lot of hacks * Rewritten Tirion Fordring script * Rewritten Varian Wrynn script * Rewritten Garrosh script * Rewritten Wilfred event * Rewritten Lich King event * Updated codestyle * Added missing spawns * Fixed combat behavior before Gormok * Fixed some visual stuff (cherry picked from commit 2362e9c79410c689afc10266b94f7e78c88bbddc)
2021-04-15TypoKillyana
(cherry picked from commit b08280fcfee500acf8b951ec2c05e0760d4b9955)
2021-04-15Scripts/Stratholme: Fix a DB errorKillyana
Ref #20749 (cherry picked from commit be56a4669e6f1b1d34a9a1e2ed19b627e1263cfb)
2021-04-15Scripts/Stratholme: Add missing header for no-pch buildjackpoz
(cherry picked from commit 9a515c29bab2dadec011f40e4f824bd9409528d4)
2021-04-15Scripts/Stratholme: Fix buildjackpoz
(cherry picked from commit 828c5d08e758385519955201b909a0d9a578715d)
2021-04-15Scripts/Stratholme: Fix buildjackpoz
(cherry picked from commit a98b2aa8c8cfe9e06cf00b7d37abf06f06aee67b)
2021-04-15Scripts/Stratholme: Few changes to how Ysida behaves during the Baron run ↵Riztazz
(#20749) (cherry picked from commit 2a25d9d9a7a7d4aa8b06f9cd0bb26b123adf7789)