| Age | Commit message (Collapse) | Author |
|---|
|
* closes #2381
|
|
3.3.5-base (PR #16437)
|
|
|
|
Change #define to enum {with brackets}
Possibly the smallest change so far in this series of core script changes.
|
|
- moved 2 #define text lines to enum, already in npc_text
- new gossip_menu_option for NPC 3678 Disciple of Naralex
- using `ADD_GOSSIP_ITEM_DB` instead of `ADD_GOSSIP_ITEM`
Tested on both alliance and horde characters, works just like before.
|
|
There should no longer be weirdness if a reset happens during the RP phase.
|
|
- Roar at start of phase two
- Ingvar no longer does a weird move-jump towards his target when resurrecting
- Fixed a duplicate yell on phase one end
|
|
(PR #16384)
|
|
Fix Coverity issue id 1022474
|
|
Additional change: menu options are changed from containing only names
to include the text " is my answer.", based on the lines in `broadcast_text`.
- replaced core text with DB SAI script
- created DB creature_text entries for Parqual Fintallas
- created DB gossip_menu_option entries for the NPC
- implemented NPC say lines in reply to all the answers
- added conditions for which gossip should show, depending on quest status
- added conditions to avoid exploits in the time it takes for NPC to say his texts
This PR is tested several times on a horde character (horde-only quest).
It now works as originally intended, with option-specific NPC replies.
|
|
|
|
3.3.5-base (PR #16152)
|
|
3.3.5-base (PR #16276)
|
|
engineering/leatherworking specs possible!
|
|
Core/Script: fix bug that prevent double spending reset cooldown
|
|
Core/Scripts: Change door ID and name in Blackwing Lair
|
|
|
|
(0x00200000) that awards players credit for killing the creature even if less than 50% of damage was dealt by players.
This can be used to fix quests such as "Heated Battle" or "If Valgarde Falls..." that are currently very hard to complete at the appropriate level due to "friendly" NPCs killing off the required targets too quickly for players to get 50% of damage in.
|
|
|
|
- created DB gossip_menu_option entries for both NPCs
- added enum section instead of "magic numbers" in script
- replaced core text with pointers to DB text
- zone_western_plaguelands.cpp is now cleaned up
|
|
|
|
|
|
as per 7d454c66f70c19c8ff402fd126392e27700398ba
Change the name as well.
|
|
|
|
|
|
blank text to players after buffing them
Closes #12697
Closes #16300
|
|
Fixes -Winconsistent-missing-override
|
|
- Stop tools from complaining about leaks.
- Also, list -> vector.
- Fix an ambiguous constructor warning.
- Fix a bug with Gormok and Sindragosa (Fixes #16280).
|
|
|
|
|
|
- Rewrite pretty much the entire encounter code
- Get rid of ugly define ugliness
- Sniffed waypoints
- Blizzlike timings
- Missing emotes
|
|
- Move TeleportTo hack to proper spell casts
- Add missing lines to boss
- Fix add spawn timings
- Fix visuals
- Fix logic for gate opening
- Fix add aggro behavior
- Fix add casting AI
- Fix some other stuff I probably forgot
|
|
|
|
- Migrate boundary logic to Maps/AreaBoundary instead of having it sit in InstanceScript (to possibly allow use for other purposes).
- Implement the first five boundary types in Maps/AreaBoundary.cpp.
- Add boundary checks to Creature's update logic
- Add boundary data for all Northrend raids
- Add boundary initialization structures and methods to InstanceScript
- Modify EnterEvadeMode signature. It now passes a value from the EvadeReason enum as parameter to allow special casing depending on evade reason
- Remove previous (weird) boundary code that had them linked to GO spawns
|
|
Core/Spells Implement SpellScript needed for Achievement The Turkinator
|
|
|
|
|
|
|
|
|
|
Closes #3997
|
|
Removing hardcoded text from the core script and into the DB:
"I am ready for the illusion, Myranda."
This quest is 3.3.5 *only*. Removed in patch 4.0.3a.
Addendum: enum ILLUSION_GOSSIP = 4773 , instead of "magic number".
|
|
Another attempt to shorten the list of hardcoded gossip menu options.
This is the gossip menu option of the NPC ID 28406, Death Knight Initiate
in Death's Breach in the Scarlet Enclave, the death knight starting area.
This gossip is tied to the quest "Death's Challenge".
Removing this text in the core script: "I challenge you, death knight!"
(#define GOSSIP_ACCEPT_DUEL) and using `ADD_GOSSIP_ITEM_DB()`
to pull the gossip_menu_option 9765 from the database instead.
|
|
Getting rid of one more incorrect and hardcoded text
which now will be read correct and from the DB instead.
Wrong text: "Thanks, I'll follow you to the door." (core)
Correct text: "Please unlock the courtyard door." (DB)
Thanks to @Aokromes, @r00ty, @velinath, @Nayd, @Treeston, @Zedron
and lots of other regular TrinityCore developers and members for the
inspiration and motivation, as well as helpfulness along the way.
|
|
Scripts/Spells: Mine Sweeper achievement
|
|
Fix an issue reported by static analysis
|
|
|
|
|
|
Fix confusing NULL checks in Raise Ally check cast.
Fix a crash in Raise Ally triggered by executing ".cast back 61999" command targeting a pet in raid while being dead.
|
|
Fixes issue where NPC does not attack, even when aggro'd.
Fixes #16210
Closes #16204
|
|
[3.3.5] Scripts/ICC: Fixed Professor Putricide
|
