aboutsummaryrefslogtreecommitdiff
path: root/src/server/scripts
AgeCommit message (Collapse)Author
2013-09-22Merge pull request #10875 from zorix/PR2Shauren
Core/Script:
2013-09-22Core/Script:zorix
ICC: Convert possible non valid pointer to guid Close #9954
2013-09-21Scripts/ScarletEnclave: Fix uninitialized values in Highlord Darion Mograinejackpoz
Reset() has if checks on values that are initialized after them so it's required to initialize these fields in the constructor. Valgrind log: Conditional jump or move depends on uninitialised value(s) by 0x11CF472: HashMapHolder<Creature>::Find(unsigned long) (ObjectAccessor.h:67) by 0x11CE36F: Creature* ObjectAccessor::GetObjectInWorld<Creature>(unsigned long, Creature*) (ObjectAccessor.h:114) by 0x1257C13: Creature* ObjectAccessor::GetObjectInMap<Creature>(unsigned long, Map*, Creature*) (ObjectAccessor.h:135) by 0x12E64F1: Map::GetCreature(unsigned long) (Map.cpp:2767) by 0x10AF4DE: Unit::GetCreature(WorldObject&, unsigned long) (Unit.cpp:13021) by 0x16F8F81: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::Reset() (chapter5.cpp:386) by 0x16F8D36: npc_highlord_darion_mograine::npc_highlord_darion_mograineAI::npc_highlord_darion_mograineAI(Creature*) (chapter5.cpp:314) by 0x16F8CD6: npc_highlord_darion_mograine::GetAI(Creature*) const (chapter5.cpp:307) by 0x132AF6C: ScriptMgr::GetCreatureAI(Creature*) (ScriptMgr.cpp:796) by 0x1441D45: FactorySelector::selectAI(Creature*) (CreatureAISelector.cpp:41)
2013-09-18Core/Achievements: Implemented ACHIEVEMENT_CRITERIA_TYPE_KILL_CREATURE_TYPEjoschiwald
2013-09-15Merge pull request #10823 from jackpoz/icewall_overflowNay
Scripts/HoR: Fix possible array overflow
2013-09-15Scripts/HoR: Fix possible array overflowjackpoz
Fix possible array overflow reported by coverity, issue id 1062436 .
2013-09-13Core/Commands: Fix NULL dereference crash in .account passwordjackpoz
Fix NULL dereference crash in .account password added in bd8d0cfbce9a38e0f2fc8b6903434c3553faf143 Fixes #10791
2013-09-12Fix buildMachiavelli
2013-09-12Merge pull request #10792 from Ascathor/masterNay
Core/Command: Fixing .account password to no longer crash
2013-09-12Core/Command: Fixing .account password to no longer crashAscathor
And add some comments to it.
2013-09-11Merge pull request #10782 from Ascathor/masterNay
Core/Commands: Fixing some problems with .account email
2013-09-11Core/Commands: Fixing some problems with .account emailAscathor
2013-09-11Merge pull request #10781 from jackpoz/create_pet_creaturetemplateNay
Scripts/Commands: Retrieve Creature template in HandlePetCreateCommand f...
2013-09-11Merge pull request #10779 from jackpoz/murmur_unused_fieldNay
Scripts/Murmur: Remove unused field
2013-09-11Merge pull request #10736 from jackpoz/localtime_race_conditionNay
Core/Thread: Fix race condition converting time values to local time
2013-09-11Scripts/Commands: Retrieve Creature template in HandlePetCreateCommand from ↵jackpoz
Creature itself CreatureTemplate can be retrieved directly from the Creature itself instead of using ObjectMgr::GetCreatureTemplate(id) .
2013-09-11Scripts/Murmur: Remove unused fieldjackpoz
Remove unused class field.
2013-09-11Scripts/Halion: refixed Twilight Cutterjoschiwald
Scripts/Garfrost: fixed forge jump
2013-09-11Scripts/PitOfSaron: some changesMitchesD
Closes #10740
2013-09-10Core/RBAC: Move titles and wp commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move ticket commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move tele commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move server commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move reset commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move reload command to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move quest commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move npc commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move modify commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move mmap commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move misc commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move send commands to RBAC (using individual permissions)Spp
2013-09-10Core/RBAC: Move pet commands to RBAC (using individual permissions)Spp
- Pet commands moved from cs_misc.cpp to own file
2013-09-10Core/RBAC: Move group commands to RBAC (using individual permissions)Spp
- group commands moved from cs_misc.cpp to own file - renamed groupsummon to "group summon"
2013-09-07Scripts/Blood Furnace: Fix possible compile errors on old VS versionsMachiavelli
2013-09-07Core/Thread: Fix race condition converting time values to local timejackpoz
Replace thread-unsafe localtime() http://www.cplusplus.com/reference/ctime/localtime/ with thread-safe portable ACE_OS::localtime_r() . Helgrind log: Possible data race during read of size 4 at 0x6F183C0 by thread #1 Locks held: none at 0x14E72E3: World::InitDailyQuestResetTime() (World.cpp:2772) by 0x14E3A01: World::SetInitialWorldSettings() (World.cpp:1790) by 0x101122A: Master::Run() (Master.cpp:164) by 0x101740C: main (Main.cpp:142) This conflicts with a previous write of size 4 by thread #2 Locks held: none at 0x6C2D3BA: __tzfile_compute (tzfile.c:797) by 0x6C2D036: __tz_convert (tzset.c:627) by 0x164146C: LogMessage::getTimeStr(long) (Appender.cpp:23) by 0x1641550: LogMessage::getTimeStr() (Appender.cpp:31) by 0x1641722: Appender::write(LogMessage&) (Appender.cpp:80) by 0x1633FCE: Logger::write(LogMessage&) (Logger.cpp:83) by 0x16433D8: LogOperation::call() (LogOperation.cpp:29) by 0x16428A4: LogWorker::svc() (LogWorker.cpp:45)
2013-09-07Merge pull request #10724 from jackpoz/guild_disband_leakMachiavelli
Core/Guild: Fix memory leak on Guild disband
2013-09-07Scripts/Spells: drop obsolete codejoschiwald
2013-09-06-.-joschiwald
2013-09-06Fixed buildjoschiwald
2013-09-06Scripts/YoggSaron: fixed rewarding lootjoschiwald
2013-09-06Core/Spells: add an other condition to SpellInfo::NeedsToBeTriggeredByCaster ↵joschiwald
to correct spells with are wrongly triggered by target instead of caster - convert archavons rock shards to spellscript (now it works properly) - add a spellscript for one spell that can't be corrected by this (and delete the sai hack, now i uses the correct spell)
2013-09-06Core/Commands: Fix .debug send opcode freeze if file dont exists.xjose93
2013-09-06Scripts/Commands: Check if creature entry is valid before attempting to ↵Shauren
spawn (fixes unneccessary error in logs)
2013-09-05Core/Guild: Fix memory leak on Guild disbandjackpoz
Fix memory leak when disbanding a Guild, removed from GuildMgr but never deleted. Due to the different ways of how Guild::Disband() and Guild::DeleteMember() are called, each call to these methods has a different way to delete the Guild if empty/invalid. Valgrind log: 2,127 (240 direct, 1,887 indirect) bytes in 1 blocks are definitely lost in loss record 54 of 81 at operator new(unsigned long) (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) by guild_commandscript::HandleGuildCreateCommand(ChatHandler*, char const*) (cs_guild.cpp:91) by ChatHandler::ExecuteCommandInTable(ChatCommand*, char const*, std::string const&) (Chat.cpp:339) by ChatHandler::ExecuteCommandInTable(ChatCommand*, char const*, std::string const&) (Chat.cpp:320) by ChatHandler::ParseCommands(char const*) (Chat.cpp:466) by WorldSession::HandleMessagechatOpcode(WorldPacket&) (ChatHandler.cpp:217) by WorldSession::Update(unsigned int, PacketFilter&) (WorldSession.cpp:317) by World::UpdateSessions(unsigned int) (World.cpp:2632) by World::Update(unsigned int) (World.cpp:1989) by WorldRunnable::run() (WorldRunnable.cpp:60) by ACE_Based::Thread::ThreadTask(void*) (Threading.cpp:186) by ACE_OS_Thread_Adapter::invoke() (in /usr/lib/libACE-6.0.3.so)
2013-09-05Core/Battlegrounds/IoC: fix fortress teleport padsjoschiwald
(and replace a hack with an other hack) Closes #5846 Closes #7993 Ref #8984
2013-09-03Core/Misc: Fixed some more issues found by static code analysis tools.Sebastian Valle
2013-09-03Scripts/HallsOfReflection: Fixed a typo detected by static analysis tool.Sebastian Valle
2013-09-03Core/Misc: Fixed some more issues found by code analysis tools.Sebastian Valle
2013-09-03Core/Misc: Solved some issues found by static code analysis.Sebastian Valle
2013-09-02Scripts/HallsOfStone: Sjonnir, some improvementsMitchesD
- rewritten to BossAI - added spawn ordered by percent, according to official data Closes #10702 Signed-off-by: joschiwald <joschiwald@online.de>