| Age | Commit message (Collapse) | Author |
|
This is what the script changes should have been in PR #17746
(also updates issue #14719 with a correct solution).
- remove OnGossipHello() to use DB conditions
- replace OnGossipSelect() with sGossipSelect()
- focus script on the confirming gossip option
- let the other gossip menus be handled in DB
|
|
|
|
|
|
Snapper - Very Tasty!".
|
|
Tasty!" with actual summoning.
The spell does not appear in sniffs, and the summoned NPC's spawn time was far too short to be appropriate (15 seconds).
|
|
changes (#17865)
|
|
update if unit is Rooted)
Closes #17864
|
|
Core/Spells: Implemented TARGET_CORPSE_SRC_AREA_ENEMY. Closes #12803
|
|
shouldn't trigger marker aura if proc was prevented
|
|
746b838870e93d9843a089613ce7f1cd160b6ea5
|
|
|
|
|
|
impossible to get:
- SmartScripts: SMART_ACTION_SUMMON_GO
- Spell Effects:
* SPELL_EFFECT_DUEL
* SPELL_EFFECT_SUMMON_OBJECT_WILD
* SPELL_EFFECT_SUMMON_OBJECT_SLOT1
* SPELL_EFFECT_SUMMON_OBJECT_SLOT2
* SPELL_EFFECT_SUMMON_OBJECT_SLOT3
* SPELL_EFFECT_SUMMON_OBJECT_SLOT4
- Command Scripts: .gobject add
Closes #17891
|
|
|
|
UNIT_STATE_CASTING after each iteration, instead of just checking it once initially.
Fixes and closes #17892.
|
|
The Ugly™, e.g. gossip preprocessor macros, and replaces them with the new-and-shiny gossip functions.
|
|
This #define was originally supposed to be removed in my PR #17832,
but for some reason it remained undeleted. This commit corrects it.
Also aligned all the enum values to the same column for readability,
based on a common multiple of 4 spaces.
|
|
|
|
Champions" a triggered cast (#17870)
Fix a problem where the credit wasn't casted due to CGD
|
|
reset, and register them as PP summons since they're summoned by a trigger. (f183ed3c50cdcf13cd9fe608e0f4791177f120a4 follow-up)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Closes #17816
|
|
|
|
Another core script hardcoded text removal:
- removed #define text from script
- added the text to gossip_menu_option
- added and renamed enum to match DB entries
- minor additional adjustments and comments
Closes #6841
|
|
(#17780)
Properly despawn the related GameObjects after use of the quest item, avoiding multiple use and summon
|
|
Now the ranged and charge target dummies will cast their spells and behave correctly for the related quests
|
|
|
|
- Sniffed timers
- Sniffed spawn behavior
- Sniffed everything else
- Sniffed sniff. Mmmm
- In all seriousness though:
- Fixed P2 cast behavior, now obeys category cooldowns as intended
- Fixed P1 pathing and abomination behavior
- Fixed P1 passive minion aggro logic
- Fixed P1->P2 transition logic
- Fixed P3 guardian spawn/despawn logic
- Fixed all minions' cast behavior
- Fixed melee hitbox for Kel'thuzad, abominations, banshees and guardians
- Fixed reset behavior
- Fixed post-Sapphiron event to no longer open the KT door for a few seconds before slamming it closed again
|
|
isn't currently engaged in combat. (#17120)
Also disable spell focus system for vehicle control auras.
Closes #16572
Closes #17016
|
|
preventing a unit from moving
UNIT_FLAG_REMOVE_CLIENT_CONTROL (formerly UNIT_FLAG_DISABLE_MOVE) is a client-only feature that should not be used for NPC scripting. All applications of this flag in scripts/ have been replaced with applications/removals of the UNIT_STATE_ROOT state.
Closes #17311
|
|
Remove commented out code
|
|
not-yet-engaged mob packs.
|
|
Another chapter in core script hardcoded text removal:
- remove core script `npc_loramus_thalipedes` from zone_azshara.cpp
- add gossip, SAI script and conditions to database
- remove redundant SD2 comments from file header
|
|
issued in the console
|
|
SQL content based on issue 14719 by Killyana,
conditions output from Malcrom's Condition Creator
- remove hardcoded #define gossip options
- enum gossip menu IDs from DB
- remove outdated SD comments at the top of the file
Closes #14719
|
|
The core script `npc_timothy_daniels` is no longer needed,
all the gossip handling is already present in the database.
- remove core script npc_timothy_daniels
- remove ScriptName from c_t entry in DB
|
|
Move core script npc_mortog_steamhead to database
- script contains gossip handling + 1 condition
- both actions can be handled in DB settings
|
|
|