Age | Commit message (Collapse) | Author |
|
Fix battleground flags not displaying the typical burning animation when they "despawn" (they don't actually despawn, they just change state)
|
|
|
|
|
|
Fix players stuck in combat with NPC_ARM_SWEEP_STALKER and/or both arms after killing the boss.
|
|
type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL (#23844)
* Core/Achievements: fixed bug with counting honorless units for achievement type ACHIEVEMENT_CRITERIA_TYPE_SPECIAL_PVP_KILL
* Remove codestyle changes
* Remove codestyle changes
|
|
|
|
of their current ground position (#23835)
* Core/Taxis: teleport players to the destination taxi node location instead of straight to their current ground position
* fixed a typo
|
|
Fix an issue that wouldn't allow to re-queue after joining a dungeon, having 1 member leave/get kicked, queue, leave, queue.
In this case a message "One or more dungeons was not valid" would be displayed because LFG would try to queue the group as "continue dungeon" but the current group was not marked as "in dungeon" state anymore.
|
|
|
|
Fix issues reported by Coverity Scan
|
|
|
|
|
|
|
|
change of PP (#23846)
|
|
Fix guardians low damage for unhandled cases in Guardian::InitStatsForLevel()
|
|
* Scripts/PitOfSaron: Fix Martin Victus combat in crossfaction groups
Fix Martin Victus attacking players in crossfaction groups because it was spawned as summon of the boss, triggering DoCombatInZone()
* Scripts/ForgeOfSouls: Fix guards combat in crossfaction groups
Fix Devourer of Souls guardians attacking players in crossfaction groups because they were spawned as summons of the boss, triggering DoCombatInZone()
* Scripts/Misc: Fix no PCH build
|
|
(#23830)
* Core/Movement: fixed taxi pathings getting finalized earlier than intended
Since we handle the intial starting point of a spline properly now the update logic was still expecting the old handling which resulted in incrementing the current node index earlier than intended
* apply a missing change
|
|
Fix static analysis issues reported by Coverity
|
|
Closes #23828
Ty Rizztazz
|
|
Fix static analysis issue
|
|
|
|
(#23817)
* Core/Movement: provide an extra spline path vertex for taxi pathings so the first path point wont get lost.
* Update FlightPathMovementGenerator.cpp
|
|
|
|
|
|
Move "Could not load MMAP" log from ERROR to WARN as 99% of times is a false positive
|
|
|
|
* Core/Calendar: Add some additional validation when creating events
Allow only 30 player events and 100 guild events to be created.
Don't allow to create guild events if player is not in guild.
Send some more error messages to the client (not blizzlike errors but better than nothing).
* Core/Calendar: Add some additional validation/checks
Add guild id check in GetPlayerEvents().
Change error message in HandleCalendarCopyEvent() to be the same as in HandleCalendarAddEvent() when creating an event in the past.
* Core/Calendar: Add some additional validation/checks
Reduce the number of CMSG_CALENDAR_ADD_EVENT packets a seconds allowed from 10 to 3.
* Core/Calendar: Add some additional validation/checks
Implement 5 seconds cooldown between the creation of calendar events
* Core/Calendar: Add some additional validation/checks
Don't allow to copy events of a different player/guild
* Core/Calendar: Implement automatic deletion of old events
Implement automatic deletion of events older than 1 month (30 days).
Fix debug assertion triggered when deleting a character with calendar events.
Avoid double std::set lookup when deleting events when deleting a character.
NB: The whole CalendarMgr/CalendarHandler code should be checked line by line for bugs/crashes/exploits.
|
|
|
|
Add Line of Sight checks to ChaseMovementGenerator::Update(), fixing to ChaseMovementGenerator not reaching a point with valid LoS to the target.
Fix re-implements 8927a042536d4671e94ad901e9209efcf78ffa2c after 2a84562dc85516f432bb1e5de9add23c28b26ce4 partially removed it.
Fix #23724
|
|
(Introduced in this commit: 2ff855054f52bf2dcf81aa7a7da7bab7f8a99686)
|
|
|
|
Fix a crash in taxi paths happening when joining a battleground/dungeon while on a taxi path after second last node but close to last node, then leaving/finishing the battleground.
|
|
* Should check victim that do a parry instead of the unit that deal the damage (Wrong implementation of this commit: 4a46fee03ef204289bbd96e8e1e07117b3bebd9f )
Closes #23754
|
|
|
|
Barrage (#23768)
|
|
Ick (#23767)
|
|
* Scripts/Ulduar: Fix Stormcaller Brundir walking into walls
* Cleanup and fix logic + review
* Review: remove autos
|
|
* Scripts/ScarletMonastery: Rewrite Mograine and Whitemane encounter
* qq
* qq 2
* tryfix circleci build
* review suggestions
|
|
|
|
* Scripts/Outlands: Fix npc_ancestral_wolf not starting waypoint, and also add a way to not follow owner automatically in CreatureAI::JustAppeared() for tempsummons
* fix nopch
|
|
and the pet bar disappears (#23762)
|
|
Fix an assert triggered when dismissing a Warlock pet while it's casting a spell
|
|
|
|
cannot add threat on because of immunity flags. Instead, its AI manually controls the engagement state. Should close #23727.
|
|
* Fix spell_area not checking for zoneID for quests
* Addendum to bdffe0a4a641414fe26c9b75b00f8e70ff0f1cb8
* Fix spell_area handle same spell with the same quests
Also fix not checking for quest_end at all.
* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d
* Better commenting for 7a50189de3104f000d8b31fa6c415bb69cf1a3e7
* Addendum to 2d6b0545e3762b3a25005726d4093cf4a7945a8d
|
|
SMSG_PLAY_OBJECT_SOUND (#23636)
* Core/PacketIO: SMSG_PLAY_SOUND
(cherry picked from commit 82a33c7fa868d5ace7f855dba26b5f41c12bab6e)
# Conflicts:
# src/server/game/Battlefield/Battlefield.cpp
# src/server/game/Battlegrounds/Battleground.cpp
# src/server/game/Battlegrounds/BattlegroundMgr.cpp
# src/server/game/Battlegrounds/BattlegroundMgr.h
# src/server/game/Entities/Object/Object.cpp
# src/server/game/Server/Packets/MiscPackets.cpp
# src/server/game/Server/Protocol/Opcodes.cpp
# src/server/game/Texts/CreatureTextMgr.cpp
# src/server/game/Texts/CreatureTextMgr.h
# src/server/scripts/Commands/cs_misc.cpp
* Update for 3.3.5
* Core/PacketIO: updated and enabled SMSG_PLAY_MUSIC
(cherry picked from commit c6718dc120cae4217bb673b9a0ad1e83b4780f60)
# Conflicts:
# src/server/game/Maps/Map.cpp
# src/server/game/Server/Packets/MiscPackets.cpp
# src/server/game/Server/Protocol/Opcodes.cpp
# src/server/game/Server/Protocol/Opcodes.h
# src/server/game/Spells/SpellEffects.cpp
* Core/Packets: added SMSG_PLAY_OBJECT_SOUND packet class
(cherry picked from commit 1272e9eea684d1f155709baee44a301ff938ade5)
# Conflicts:
# src/server/game/Server/Packets/MiscPackets.cpp
# src/server/game/Server/Packets/MiscPackets.h
# src/server/game/Server/Protocol/Opcodes.cpp
* fic build
* change variable names
* fix build error field will be initialized after
|
|
(#23697)
* Core/Spells: Add SpellMissInfo argument to BeforeHit hooks and call them also when the spell doesn't hit. (#17613)
(cherry picked from commit 8ff5b35be1256d03b85438b130dcec7cd4cae6e1)
# Conflicts:
# src/server/game/Spells/Spell.cpp
# src/server/scripts/Northrend/IcecrownCitadel/boss_the_lich_king.cpp
# src/server/scripts/Spells/spell_warlock.cpp
* Core/Spells: Fixed warlock's Banish cancel if target was already banished (#17614)
(cherry picked from commit 4587b5d88082d2c6416fafaa2f5b9f5f15038520)
# Conflicts:
# src/server/scripts/Spells/spell_warlock.cpp
|
|
|
|
|
|
|