| Age | Commit message (Collapse) | Author |
|
--HG--
branch : trunk
|
|
Fixes issue #336.
Requires DB update.
Still WiP but functional.
--HG--
branch : trunk
|
|
Fixes issue #1243.
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
with a C++ cast(reinterpret_cast) and with a type check(isSummon()).
This function is like ToPlayer(), ToTotem(), etc.
This commit is like ede831bdd6f0cff481acc33f269fa7f8c78befd4 / r7496:
http://code.google.com/p/trinitycore/source/detail?r=ede831bdd6f0cff481acc33f269fa7f8c78befd4
As a result, this commit has the advantages and the "disadvantages" too, like r7496.
Please try to be polite if this commit causes some crashes.
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
players check in instance. Cause of error was a pointer of class Player was casted to class InstanceMap. Refs issue #1323
--HG--
branch : trunk
|
|
GUIDs are most safer than pointers and in some cases can avoid segmentation faults.
== - ==
Let me show a simple example:
We have a pointer to a creature: Creature *pCreature;
and try to search a creature and store it in the pointer:
pCreature = SearchCreature(ID);
We can check simply if the creature found or not:
if(pCreature)
- if this give true: creature found and we have a memory address which points to the creature
- if this give false: creature not found and this is a NULL pointer
Suppose that we have a valid pointer, so creature found.
We wanna use that pointer somewhere, for example in script phase 3.
But we delete the creature(from world) in phase 1.
In phase 3:
if(pCreature)
pCreature->DoSomeShit();
The if condition gives true, but pCreature points to an _invalid_ address.
In that address maybe have "nothing" or another creature's object or a player or anything else, dont know that.
~~ - ~~
Let me show the correct way:
Creature's GUID: uint64 CreatureGUID;
search the creature and set the GUID:
Creature *pCreature = SearchCreature(ID);
CreatureGUID = pCreature ? pCreature->GetGUID() : 0; // if pCreature is NULL set the GUID to 0
So we have a GUID and not a pointer.
We can get the creature from that GUID:
Creature *pCreature = GetCreature(CreatureGUID);
and we can simply check it is valid or not(found or not):
if(pCreature)
So we deleted the creature in phase 1 and try to use it in phase 3:
Creature *pCreature = GetCreature(CreatureGUID);
And this gives NULL because GetCreature() can't find the creature which GUID is CreatureGUID.
if(pCreature) // pCreature is NULL
pCreature->DoSomeShit(); // DoSomeShit() not called
== - ==
Remove some not used variables.
Some clean.
TODO: Should search/fix these in zones scripts.
--HG--
branch : trunk
|
|
AchievementMgr::CompletedAchievement).
Remove support of no longer existing achievement "The Party is Over". Thanks JuliuSZS.
Fixes issue #1318.
--HG--
branch : trunk
|
|
Fixes issue #1034.
- Remove setDisplayID hack and use UpdateEntry to fix Ingvar Kill Credit related achievements.
- code style cleaning.
Requires DB update to set loot from Ingvar Human (23954) to Undead (23980) (in normal and heroic).
--HG--
branch : trunk
|
|
Fix Flame Tsunami aura and visual effects
Author: Gyullo
--HG--
branch : trunk
|
|
not Pet. By Gyullo.
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
* Patch by click
--HG--
branch : trunk
|
|
will be mainly used by outdoorPvP system
* Update next arena auto distribute points time to custom worldstate
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
Wrath for 30 s. Closes issue #1270. Thanks to _manuel_ for research.
--HG--
branch : trunk
|
|
Fix Tomb of Seven event
Fix Shadowforge braziers
GO handling for Magmus
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
Fix some Spell IDs & timers
Implement transformation
--HG--
branch : trunk
|
|
transfer accesory list by pointer, make it constant
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
* This will reduce the size of the trainer / vendor tables a LOT.
* Current tables will continue to work as/is until the refs can be made.
* Huge thanks to XTElite1
* Credits for patch to Cycrow
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
Fix resseting issues
Better IA for adds
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
When apply more 6 gems, and after player logout, server crash, also apply code style and cleanup.
--HG--
branch : trunk
|
|
Fixes issue #1107.
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
Now bosses reset if they're hitted when their door is closed
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
Thanks Aokromes, Baraka & Spawn
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
Based on pivonroll's code but rewrited from scratch
--HG--
branch : trunk
|
|
* ACHIEVEMENT_CRITERIA_DATA_TYPE_S_EQUIPED_ITEM_LVL (item level and item quality).
Implemented achievement criteria:
* ACHIEVEMENT_CRITERIA_TYPE_LOOT_EPIC_ITEM
* ACHIEVEMENT_CRITERIA_TYPE_RECEIVE_EPIC_ITEM
Update ACHIEVEMENT_CRITERIA_TYPE_EQUIP_EPIC_ITEM implementation. Requires DB update to use new criteria data.
Thanks VladimirMangos.
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
--HG--
branch : trunk
|
|
Fixes issue #1231.
--HG--
branch : trunk
|
|
Fix compilation warning.
Fix typo in Freya soundid.
--HG--
branch : trunk
|