| Age | Commit message (Collapse) | Author |
|
for quest credit
- Also sends proper SMSG_ITEM_PUSH_RESULT packet
Closes #3505
|
|
lower level enemies
|
|
using attributes
- Renamed IsProcTriggeredOnEvent to GetProcEffectMask, since long ago this function returned bool, new name should better reflect its use
|
|
|
|
Closes #18256
|
|
- Applied twice for some dots
- Missing for Health Leech Periodic
- Missing in a few scripts
Closes #17463
|
|
more than once
No more overpowered dps for you
Closes #16755
|
|
Ctrl-S failure
|
|
(9f5df023b746d324588f175e264c62205b69e165 follow up)
- Handling checked in sniffs: Spell 63710 Void Barrier vs 49143 Frost Strike
* Send spell miss immune only if spell consists of damage effects
- Checked with 348 Immolate:
* No packets sent if damage immune, aura is applied normally
Also... who the fuck uses 0 to compare against pointers
|
|
|
|
spell. Should be used only for damage
|
|
spellcasts while charmed
|
|
Closes #18248
|
|
- SPELL_ATTR1_UNAFFECTED_BY_SCHOOL_IMMUNE
- SPELL_ATTR2_UNAFFECTED_BY_AURA_SCHOOL_IMMUNE
- SPELL_ATTR3_IGNORE_HIT_RESULT
|
|
|
|
|
|
Fixes an issue with Skadi Harpoons.
Note to self: should actually implement GameObject casting already :/
|
|
Closes #8403
|
|
Fixes Master's call when pet is rooted
|
|
Defensive Stance
|
|
Was breaking functionality (eg: stacking scroll auras)
|
|
wasn't set for the current effect.
Closes #15388
|
|
rewrite too)
- Warlord's Presence, Uncontrollable Frenzy, Free Friend
- Overload, Lightning Tendrils
- Fervor, Berserk
- Determination
|
|
for the purposes of spell/aura targets
Ref #18233
|
|
followup of 50a3ce5703bdaa4fe16e2e773eabafa9a4818083
|
|
and hooks
|
|
|
|
- Removed dead code, outdated comments
- Fixed indentation
- Explicitly delete copy ctors
- const'd the operator() definitions
|
|
* Core/Scripts: Cleanup in instance_black_temple and added missing datas
* Fixed door timing issue
* Remove redundant call
|
|
Closes #17868
(cherry picked from commit f94e6cee38241e10daed711247a18b8706cb8924)
|
|
use typedef for constant reference
|
|
|
|
- Spell attributes research
- Container optimization
- Do not skip damage immunity checks on SPELL_ATTR0_UNAFFECTED_BY_INVULNERABILITY present
- Added additonal arguments support to SendCastResult / CheckCast, spells can now send proper error messages
- Loads spell immune masks/states/effects at startup.
- This cached info is used whenever a spell cast requires immunities to be known beforehand (to see if an aura could be applied for example)
Closes #16658
Closes #16901
Closes #18114
|
|
- Renamed CheckEffectExecuteData to AssertEffectExecuteData and made const, better reflects its purpose
- Added missing attribute check to IsNextMeleeSwingSpell
- Reworked SPELL_ATTR4_CAST_ONLY_IN_OUTLAND attr check (researched behavior)
|
|
|
|
(#18231)
|
|
Closes #17968
By sirikfoll
|
|
Triggered spells shouldn't chain-trigger other spells
Closes #18217
|
|
build
Ninja NULL->nullptr cleanup
|
|
DB/Spell: Seal of Righteousness proc
- Lightining and Water Shield should proc with triggered
Closes #18211
|
|
purposes, and don't use them when casting triggered spells
Fixes #9721 (also other spells affected, example Threat of Thassarian, Stormstrike)
|
|
Spells were failing flags check in Unit::_IsValidAttackTarget
Closes #18206
|
|
Ref #18206
|
|
fully nullified
- Aka: full absorbs/full resists/full blocks/immune
|
|
Closes #18160
|
|
* Core/Loot: Fix master looting of conditional items
follow_loot_rules was a flag intended to force certain quest items to be
master looted. It should not be used for the
NonQuestNonFFAConditionalLoot.
The flag was originally introduced in 869ea349
"Core/Loot: fix the way quest items are handled. so far ive only found 3
quest items that should be able to be masterlooted. added a new flag to
item_template.flagsCustom to allow for making a quest item always follow
loot rules. a bonus may be the fix of the handlelootmasteropcode crash!"
* Core/Loot: Rename QuestItem to NotNormalItem
QuestItem struct was being used for quest items, ffa items, and
conditional items. Renaming it to avoid confusion when working with ffa
and conditional items
* Core/Loot: Use existing AddAllowedLooter rather than reaching into allowedGUIDs directly
* Core/Loot: Rename NotNormalItem to NotNormalLootItem
|
|
|
|
|
|
evade chains on some bosses. Closes #18188.
|
|
|