From 37ead79e289a2121b233d36f9ba1f80b87438d45 Mon Sep 17 00:00:00 2001 From: Shauren Date: Wed, 21 May 2025 21:17:38 +0200 Subject: Core/PacketIO: Disable implicit bool to int conversions for ByteBuffer operators (cherry picked from commit 7ca9e9005d8b54555e0eaba36c9ff446526cb546) --- src/server/shared/Packets/ByteBuffer.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/server/shared/Packets/ByteBuffer.h b/src/server/shared/Packets/ByteBuffer.h index 5c03ba62467..8f3e437f04f 100644 --- a/src/server/shared/Packets/ByteBuffer.h +++ b/src/server/shared/Packets/ByteBuffer.h @@ -286,6 +286,8 @@ class TC_SHARED_API ByteBuffer */ void PutBits(std::size_t pos, std::size_t value, uint32 bitCount); + ByteBuffer& operator<<(bool) = delete; // prevent implicit conversions to int32 + ByteBuffer& operator<<(char value) { append(value); @@ -372,6 +374,8 @@ class TC_SHARED_API ByteBuffer return operator<<(std::string_view(str ? str : "")); } + ByteBuffer& operator>>(bool&) = delete; + ByteBuffer& operator>>(char& value) { read(&value, 1); -- cgit v1.2.3