From b609b314b2cc3380c4cd82265c86b39154080098 Mon Sep 17 00:00:00 2001 From: click Date: Mon, 31 Dec 2012 12:09:22 +0100 Subject: CMake/Buildsystem: CMake adds /Zm1000 to MSVC by default - explicitly replace that in the flaglist with the lower boundary --- cmake/compiler/msvc/settings.cmake | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'cmake/compiler/msvc/settings.cmake') diff --git a/cmake/compiler/msvc/settings.cmake b/cmake/compiler/msvc/settings.cmake index 0aa5d93a4b3..d816a31405d 100644 --- a/cmake/compiler/msvc/settings.cmake +++ b/cmake/compiler/msvc/settings.cmake @@ -51,6 +51,7 @@ if(NOT WITH_WARNINGS) endif() endif() -# Specify Precompiled Header Memory Allocation Limit -# (Fix a compiler-problem when using PCH - the /Ym flag is adjusted by the compiler in MSVC2012, hence we need to set an upper limit to avoid disrupancies) -set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /Zm500") +# Specify the maximum PreCompiled Header memory allocation limit +# Fixes a compiler-problem when using PCH - the /Ym flag is adjusted by the compiler in MSVC2012, hence we need to set an upper limit with /Zm to avoid disrupancies) +# (And yes, this is a verified , unresolved bug with MSVC... *sigh*) +string(REPLACE "/Zm1000" "/Zm500" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) -- cgit v1.2.3 From 4186c3cef7cf53051f52d56e9b4ffb84c5502a03 Mon Sep 17 00:00:00 2001 From: Shauren Date: Mon, 31 Dec 2012 14:10:22 +0100 Subject: Buildsystem/MSVC: Enable and treat as errors compilation warning about not matching virtual function signatures. This will help scripters who might sometimes use a hook using improper parameters (or miss 'const' for example) --- cmake/compiler/msvc/settings.cmake | 5 +++++ 1 file changed, 5 insertions(+) (limited to 'cmake/compiler/msvc/settings.cmake') diff --git a/cmake/compiler/msvc/settings.cmake b/cmake/compiler/msvc/settings.cmake index d816a31405d..d758d466407 100644 --- a/cmake/compiler/msvc/settings.cmake +++ b/cmake/compiler/msvc/settings.cmake @@ -55,3 +55,8 @@ endif() # Fixes a compiler-problem when using PCH - the /Ym flag is adjusted by the compiler in MSVC2012, hence we need to set an upper limit with /Zm to avoid disrupancies) # (And yes, this is a verified , unresolved bug with MSVC... *sigh*) string(REPLACE "/Zm1000" "/Zm500" CMAKE_CXX_FLAGS ${CMAKE_CXX_FLAGS}) + +# Enable and treat as errors the following warnings to easily detect virtual function signature failures: +# 'function' : member function does not override any base class virtual member function +# 'virtual_function' : no override available for virtual member function from base 'class'; function is hidden +set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /we4263 /we4264") -- cgit v1.2.3