From a3874ee4f931336fa1ae240fe3288bc648b5d5c2 Mon Sep 17 00:00:00 2001
From: Shauren <shauren.trinity@gmail.com>
Date: Fri, 20 Sep 2024 13:19:42 +0200
Subject: Build: Add WITH_WARNINGS_AS_ERRORS cmake option that turns compile
 warnings into compile errors

(cherry picked from commit 7ac0c685dd01bdce2d1ee0bb878e5044b3c1fffa)
---
 src/common/CMakeLists.txt | 15 ++++++---------
 1 file changed, 6 insertions(+), 9 deletions(-)

(limited to 'src/common')

diff --git a/src/common/CMakeLists.txt b/src/common/CMakeLists.txt
index c2098260917..e026b7b5302 100644
--- a/src/common/CMakeLists.txt
+++ b/src/common/CMakeLists.txt
@@ -53,10 +53,6 @@ target_include_directories(common
   PRIVATE
     ${CMAKE_CURRENT_BINARY_DIR})
 
-set_target_properties(common
-  PROPERTIES
-    DEFINE_SYMBOL TRINITY_API_EXPORT_COMMON)
-
 target_link_libraries(common
   PRIVATE
     trinity-core-interface
@@ -74,12 +70,13 @@ target_link_libraries(common
     jemalloc
     short_alloc)
 
-add_dependencies(common revision_data.h)
-
 set_target_properties(common
-    PROPERTIES
-      FOLDER
-        "server")
+  PROPERTIES
+    COMPILE_WARNING_AS_ERROR ${WITH_WARNINGS_AS_ERRORS}
+    DEFINE_SYMBOL TRINITY_API_EXPORT_COMMON
+    FOLDER "server")
+
+add_dependencies(common revision_data.h)
 
 if(BUILD_SHARED_LIBS)
   if(UNIX)
-- 
cgit v1.2.3