From a53326353b1e2b3838a1fab5734f24b52471e20d Mon Sep 17 00:00:00 2001 From: megamage Date: Mon, 25 May 2009 11:19:13 -0500 Subject: *Do not allow wrecking crew stack with enrage. Also, allow proc buff overwrite another. Need better rules to check that. (see my comment in code) --HG-- branch : trunk --- src/game/Unit.cpp | 21 +++++++++++---------- 1 file changed, 11 insertions(+), 10 deletions(-) (limited to 'src/game/Unit.cpp') diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 18fe23728ca..ee91150d9d1 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -6865,16 +6865,17 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, AuraEffect* trig Item* castItem = triggeredByAura->GetParentAura()->GetCastItemGUID() && GetTypeId()==TYPEID_PLAYER ? ((Player*)this)->GetItemByGuid(triggeredByAura->GetParentAura()->GetCastItemGUID()) : NULL; - AuraMap::iterator i,next; - for (i = m_Auras.begin(); i != m_Auras.end(); i = next) - { - next = i; - ++next; - if (!(*i).second) continue; - if ( (*i).second->GetSpellProto()->Id == trigger_spell_id) continue; - if (spellmgr.IsNoStackSpellDueToSpell(trigger_spell_id, (*i).second->GetSpellProto()->Id, (pVictim == this))) - return false; - } + // TODO: we need better rules here. Enrage should not overwrite death wish, but it should overwrite Wrecking Crew + // AuraMap::iterator i,next; + // for (i = m_Auras.begin(); i != m_Auras.end(); i = next) + // { + // next = i; + // ++next; + // if (!(*i).second) continue; + //if ( (*i).second->GetSpellProto()->Id == trigger_spell_id) continue; + // if (spellmgr.IsNoStackSpellDueToSpell(trigger_spell_id, (*i).second->GetSpellProto()->Id, (pVictim == this))) + // return false; + // } // Try handle unknown trigger spells if (sSpellStore.LookupEntry(trigger_spell_id)==NULL) -- cgit v1.2.3