From 699bc588b86a5176fce0900804fb7d00425383fe Mon Sep 17 00:00:00 2001 From: megamage Date: Tue, 24 Feb 2009 11:14:28 -0600 Subject: [7330] Code warnings and style cleanups. Some bugs fixes. Author: VladimirMangos 1) comparison singed and unsigned values 2) redundent includes 3) wrong constructor :-part field initilization 4) unused not-/*name*/-guarded args in template/virtual functions that not required like args. 5) explicitly list not implemented achievement types. Also bugs fixed: 1) Drop wrong phase mask 0 check in WorldObject::InSamePhase. 2) ArenaTeamMember::ModifyPersonalRating incorrect work with move points in negative with infinity values in result. 3) ArenaTeam::SaveToDB code send uint64 value to string with arg format %u. --HG-- branch : trunk --- src/game/WorldSocket.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'src/game/WorldSocket.cpp') diff --git a/src/game/WorldSocket.cpp b/src/game/WorldSocket.cpp index 06247f810a6..6c94dbd8cb4 100644 --- a/src/game/WorldSocket.cpp +++ b/src/game/WorldSocket.cpp @@ -489,8 +489,7 @@ int WorldSocket::handle_input_header (void) EndianConvertReverse(header.size); EndianConvert(header.cmd); - if ((header.size < 4) || (header.size > 10240) || - (header.cmd < 0) || (header.cmd > 10240) ) + if ((header.size < 4) || (header.size > 10240) || (header.cmd > 10240)) { sLog.outError ("WorldSocket::handle_input_header: client sent mailformed packet size = %d , cmd = %d", header.size, header.cmd); @@ -734,7 +733,7 @@ int WorldSocket::ProcessIncoming (WorldPacket* new_pct) } else { - sLog.outError ("WorldSocket::ProcessIncoming: Client not authed opcode = ", opcode); + sLog.outError ("WorldSocket::ProcessIncoming: Client not authed opcode = %u", uint32(opcode)); return -1; } } -- cgit v1.2.3