From 2156fec0d2b0958535495c9edc7d30e2b8e95da5 Mon Sep 17 00:00:00 2001
From: megamage <none@none>
Date: Mon, 16 Feb 2009 20:10:40 -0600
Subject: [7284] Avoid 2 times skill value request. Author: VladimirMangos

--HG--
branch : trunk
---
 src/game/SpellEffects.cpp | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

(limited to 'src/game')

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 0e72e541fe4..3a33532d9f5 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -3137,8 +3137,7 @@ void Spell::EffectOpenLock(uint32 /*i*/)
         }
 
         // update skill if really known
-        uint32 SkillValue = player->GetPureSkillValue(SkillId);
-        if(SkillValue)                                      // non only item base skill
+        if(uint32 SkillValue = player->GetPureSkillValue(SkillId))
         {
             if(gameObjTarget)
             {
@@ -3150,7 +3149,6 @@ void Spell::EffectOpenLock(uint32 /*i*/)
             else if(itemTarget)
             {
                 // Do one skill-up
-                uint32 SkillValue = player->GetPureSkillValue(SkillId);
                 player->UpdateGatherSkill(SkillId, SkillValue, reqSkillValue);
             }
         }
-- 
cgit v1.2.3