From 433bc289c2c82b7377ad0189e415a3ca070d220f Mon Sep 17 00:00:00 2001 From: Naios Date: Wed, 18 Mar 2015 19:08:45 +0100 Subject: Core/Misc: Fix some issues detected by static analysis * Assignment of function parameter has no effect outside the function. Did you forget dereferencing it? -> This argument is passed by value, it makes no sence so set it to null here. * Member variable 'instance_violet_hold_InstanceMapScript::bWiped' is not initialized in the constructor. * Mismatching allocation and deallocation: Data --- src/server/bnetserver/Server/ModuleManager.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/server/bnetserver/Server/ModuleManager.h') diff --git a/src/server/bnetserver/Server/ModuleManager.h b/src/server/bnetserver/Server/ModuleManager.h index 05a7298e27c..68d5b2a1e78 100644 --- a/src/server/bnetserver/Server/ModuleManager.h +++ b/src/server/bnetserver/Server/ModuleManager.h @@ -54,9 +54,10 @@ namespace Battlenet memcpy(Data, right.Data, DataSize); } } + ~ModuleInfo() { - delete Data; + delete[] Data; } std::string Type; -- cgit v1.2.3