From 24fc0dcb1ee627cdec5ff5670a85050afc62d281 Mon Sep 17 00:00:00 2001 From: Shauren Date: Sun, 14 May 2023 16:30:05 +0200 Subject: Core/DBLayer: Relaxed restrictions on which Field class member function can be used to access column value from "strict match" to "must not truncate" (cherry picked from commit eadafb0347d606e5e3e660d21227aa15378bdb21) --- .../database/Database/FieldValueConverter.cpp | 48 ++++++++++++++++++++++ 1 file changed, 48 insertions(+) create mode 100644 src/server/database/Database/FieldValueConverter.cpp (limited to 'src/server/database/Database/FieldValueConverter.cpp') diff --git a/src/server/database/Database/FieldValueConverter.cpp b/src/server/database/Database/FieldValueConverter.cpp new file mode 100644 index 00000000000..589d33c8850 --- /dev/null +++ b/src/server/database/Database/FieldValueConverter.cpp @@ -0,0 +1,48 @@ +/* + * This file is part of the TrinityCore Project. See AUTHORS file for Copyright information + * + * This program is free software; you can redistribute it and/or modify it + * under the terms of the GNU General Public License as published by the + * Free Software Foundation; either version 2 of the License, or (at your + * option) any later version. + * + * This program is distributed in the hope that it will be useful, but WITHOUT + * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or + * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for + * more details. + * + * You should have received a copy of the GNU General Public License along + * with this program. If not, see . + */ + +#include "FieldValueConverter.h" +#include "Errors.h" +#include "Field.h" + +BaseDatabaseResultValueConverter::BaseDatabaseResultValueConverter() = default; +BaseDatabaseResultValueConverter::~BaseDatabaseResultValueConverter() = default; + +void BaseDatabaseResultValueConverter::LogTruncation(char const* getter, QueryResultFieldMetadata const* meta) +{ + char const* expectedAccessor = ""; + switch (meta->Type) + { + case DatabaseFieldTypes::UInt8: expectedAccessor = "Field::GetUInt8"; break; + case DatabaseFieldTypes::Int8: expectedAccessor = "Field::GetInt8"; break; + case DatabaseFieldTypes::UInt16: expectedAccessor = "Field::GetUInt16"; break; + case DatabaseFieldTypes::Int16: expectedAccessor = "Field::GetInt16"; break; + case DatabaseFieldTypes::UInt32: expectedAccessor = "Field::GetUIn32"; break; + case DatabaseFieldTypes::Int32: expectedAccessor = "Field::GetInt32"; break; + case DatabaseFieldTypes::UInt64: expectedAccessor = "Field::GetUIn64"; break; + case DatabaseFieldTypes::Int64: expectedAccessor = "Field::GetInt64"; break; + case DatabaseFieldTypes::Float: expectedAccessor = "Field::GetFloat"; break; + case DatabaseFieldTypes::Double: expectedAccessor = "Field::GetDouble"; break; + case DatabaseFieldTypes::Decimal: expectedAccessor = "Field::GetDouble or Field::GetString"; break; + case DatabaseFieldTypes::Binary: expectedAccessor = "Field::GetString or Field::GetBinary"; break; + default: + break; + } + + ASSERT(false, "%s on %s field %s.%s (%s.%s) at index %u caused value to be truncated. Use %s instead.", + getter, meta->TypeName, meta->TableAlias, meta->Alias, meta->TableName, meta->Name, meta->Index, expectedAccessor); +} -- cgit v1.2.3