From 97191e2a1149b94c8a00207da2ab34b7a3f72347 Mon Sep 17 00:00:00 2001 From: Shauren Date: Mon, 6 May 2024 00:38:05 +0200 Subject: Core/Updater: Fix gcc warning (cherry picked from commit b288fceb792b5571eb7b79033408588fe4bede24) --- src/server/database/Updater/UpdateFetcher.cpp | 2 +- src/server/database/Updater/UpdateFetcher.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/server/database') diff --git a/src/server/database/Updater/UpdateFetcher.cpp b/src/server/database/Updater/UpdateFetcher.cpp index 9eb27231d18..659b919cf3d 100644 --- a/src/server/database/Updater/UpdateFetcher.cpp +++ b/src/server/database/Updater/UpdateFetcher.cpp @@ -412,7 +412,7 @@ void UpdateFetcher::CleanUp(AppliedFileStorage const& storage) const void UpdateFetcher::UpdateState(std::string const& name, State const state) const { - std::string const update = "UPDATE `updates` SET `state`=\'" + AppliedFileEntry::StateConvert(state) + "\' WHERE `name`=\"" + name + "\""; + std::string const update = Trinity::StringFormat(R"(UPDATE `updates` SET `state`='{}' WHERE `name`="{}")", AppliedFileEntry::StateConvert(state), name); // Update database _apply(update); diff --git a/src/server/database/Updater/UpdateFetcher.h b/src/server/database/Updater/UpdateFetcher.h index 69f4d4cdca9..be66162efcf 100644 --- a/src/server/database/Updater/UpdateFetcher.h +++ b/src/server/database/Updater/UpdateFetcher.h @@ -86,12 +86,12 @@ private: uint64 const timestamp; - static inline State StateConvert(std::string const& state) + static constexpr State StateConvert(std::string const& state) { return (state == "RELEASED") ? RELEASED : ARCHIVED; } - static inline std::string StateConvert(State const state) + static constexpr std::string StateConvert(State const state) { return (state == RELEASED) ? "RELEASED" : "ARCHIVED"; } -- cgit v1.2.3