From 301ec0be564a4f160984dc5e34ab5468464dc76e Mon Sep 17 00:00:00 2001 From: Naios Date: Wed, 11 Mar 2015 08:53:13 +0100 Subject: Core/Game: Fix some issues detected by static analysis. * Possible inefficient checking for 'list' emptiness. * Variable '_scheduledScripts' is assigned in constructor body. Consider performing initialization in initialization list. * Variable 'Text' is assigned in constructor body. Consider performing initialization in initialization list. * Possible inefficient checking for 'm_loadedScripts' emptiness. (cherry picked from commit 9a61049f88835fd6bdb75905f042583d038d0667) Conflicts: src/server/game/Server/Packets/TicketPackets.cpp --- src/server/game/AI/SmartScripts/SmartScript.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/server/game/AI/SmartScripts') diff --git a/src/server/game/AI/SmartScripts/SmartScript.cpp b/src/server/game/AI/SmartScripts/SmartScript.cpp index e7e5f53f7a2..58b25781035 100644 --- a/src/server/game/AI/SmartScripts/SmartScript.cpp +++ b/src/server/game/AI/SmartScripts/SmartScript.cpp @@ -3167,7 +3167,7 @@ void SmartScript::ProcessEvent(SmartScriptHolder& e, Unit* unit, uint32 var0, ui std::list list; me->GetCreatureListWithEntryInGrid(list, e.event.distance.entry, (float)e.event.distance.dist); - if (list.size() > 0) + if (!list.empty()) creature = list.front(); } @@ -3198,7 +3198,7 @@ void SmartScript::ProcessEvent(SmartScriptHolder& e, Unit* unit, uint32 var0, ui std::list list; me->GetGameObjectListWithEntryInGrid(list, e.event.distance.entry, (float)e.event.distance.dist); - if (list.size() > 0) + if (!list.empty()) gameobject = list.front(); } -- cgit v1.2.3