From 98d6258efdc07b53808ba6177e5427c65163bc0d Mon Sep 17 00:00:00 2001 From: ariel- Date: Sat, 24 Feb 2018 15:52:09 -0300 Subject: Core/Entities: kill unused return value from Unit::HandleSpellClick - AI hook will now receive the result by copy, as modifying it had no effect - Some renaming: result->spellClickHandled, clickPair is actually clickBounds, the clickPair is the pair --- src/server/game/AI/SmartScripts/SmartAI.cpp | 4 ++-- src/server/game/AI/SmartScripts/SmartAI.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) (limited to 'src/server/game/AI/SmartScripts') diff --git a/src/server/game/AI/SmartScripts/SmartAI.cpp b/src/server/game/AI/SmartScripts/SmartAI.cpp index dc9d42e6bbc..768faad0af6 100644 --- a/src/server/game/AI/SmartScripts/SmartAI.cpp +++ b/src/server/game/AI/SmartScripts/SmartAI.cpp @@ -838,9 +838,9 @@ void SmartAI::OnGameEvent(bool start, uint16 eventId) GetScript()->ProcessEventsFor(start ? SMART_EVENT_GAME_EVENT_START : SMART_EVENT_GAME_EVENT_END, nullptr, eventId); } -void SmartAI::OnSpellClick(Unit* clicker, bool& result) +void SmartAI::OnSpellClick(Unit* clicker, bool spellClickHandled) { - if (!result) + if (!spellClickHandled) return; GetScript()->ProcessEventsFor(SMART_EVENT_ON_SPELLCLICK, clicker); diff --git a/src/server/game/AI/SmartScripts/SmartAI.h b/src/server/game/AI/SmartScripts/SmartAI.h index 0bc30015287..e27ac2ad1e8 100644 --- a/src/server/game/AI/SmartScripts/SmartAI.h +++ b/src/server/game/AI/SmartScripts/SmartAI.h @@ -185,7 +185,7 @@ class TC_GAME_API SmartAI : public CreatureAI } void StartDespawn() { mDespawnState = 2; } - void OnSpellClick(Unit* clicker, bool& result) override; + void OnSpellClick(Unit* clicker, bool spellClickHandled) override; void SetWPPauseTimer(uint32 time) { _waypointPauseTimer = time; } -- cgit v1.2.3