From cbb532e4bec11d59f2072441a43b7c797de6d16d Mon Sep 17 00:00:00 2001 From: Shauren Date: Fri, 11 Jul 2025 17:40:34 +0200 Subject: Core/Groups: Use iterators instead of raw LinkedListElement to interact with group members --- src/server/game/Achievements/AchievementMgr.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/server/game/Achievements/AchievementMgr.cpp') diff --git a/src/server/game/Achievements/AchievementMgr.cpp b/src/server/game/Achievements/AchievementMgr.cpp index 246cafea6a7..3323e9c7212 100644 --- a/src/server/game/Achievements/AchievementMgr.cpp +++ b/src/server/game/Achievements/AchievementMgr.cpp @@ -958,10 +958,9 @@ void GuildAchievementMgr::CompletedAchievement(AchievementEntry const* achieveme ca.CompletingPlayers.insert(referencePlayer->GetGUID()); if (Group const* group = referencePlayer->GetGroup()) - for (GroupReference const* ref = group->GetFirstMember(); ref != nullptr; ref = ref->next()) - if (Player const* groupMember = ref->GetSource()) - if (groupMember->GetGuildId() == _owner->GetId()) - ca.CompletingPlayers.insert(groupMember->GetGUID()); + for (GroupReference const& ref : group->GetMembers()) + if (ref.GetSource()->GetGuildId() == _owner->GetId()) + ca.CompletingPlayers.insert(ref.GetSource()->GetGUID()); } if (achievement->Flags & (ACHIEVEMENT_FLAG_REALM_FIRST_REACH | ACHIEVEMENT_FLAG_REALM_FIRST_KILL)) -- cgit v1.2.3