From cbb532e4bec11d59f2072441a43b7c797de6d16d Mon Sep 17 00:00:00 2001 From: Shauren Date: Fri, 11 Jul 2025 17:40:34 +0200 Subject: Core/Groups: Use iterators instead of raw LinkedListElement to interact with group members --- src/server/game/Entities/GameObject/GameObject.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/server/game/Entities/GameObject') diff --git a/src/server/game/Entities/GameObject/GameObject.cpp b/src/server/game/Entities/GameObject/GameObject.cpp index 7e15231016a..6bb1f0a6aa1 100644 --- a/src/server/game/Entities/GameObject/GameObject.cpp +++ b/src/server/game/Entities/GameObject/GameObject.cpp @@ -2835,10 +2835,9 @@ void GameObject::Use(Unit* user, bool ignoreCastInProgress /*= false*/) if (Group* group = player->GetGroup()) { - for (GroupReference const* itr = group->GetFirstMember(); itr != nullptr; itr = itr->next()) - if (Player* member = itr->GetSource()) - if (member->IsAtGroupRewardDistance(this)) - member->KillCreditGO(info->entry, GetGUID()); + for (GroupReference const& itr : group->GetMembers()) + if (itr.GetSource()->IsAtGroupRewardDistance(this)) + itr.GetSource()->KillCreditGO(info->entry, GetGUID()); } else player->KillCreditGO(info->entry, GetGUID()); -- cgit v1.2.3