From b7aef385e863072eef544dcfcc033090a882ff8f Mon Sep 17 00:00:00 2001 From: jackpoz Date: Sat, 17 Feb 2018 23:26:50 +0100 Subject: Core/Misc: ASSERT() cleanup Move some functions calls out of ASSERT() calls. ASSERT() should only apply checks without modifying any object and without having any side effect. (cherry picked from commit 572eab1c355d9298ee640ebd7439f55366224fb8) --- src/server/game/Groups/Group.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/server/game/Groups/Group.cpp') diff --git a/src/server/game/Groups/Group.cpp b/src/server/game/Groups/Group.cpp index a9fd5085d11..07be71b46ff 100644 --- a/src/server/game/Groups/Group.cpp +++ b/src/server/game/Groups/Group.cpp @@ -169,7 +169,8 @@ bool Group::Create(Player* leader) Group::ConvertLeaderInstancesToGroup(leader, this, false); - ASSERT(AddMember(leader)); // If the leader can't be added to a new group because it appears full, something is clearly wrong. + bool addMemberResult = AddMember(leader); + ASSERT(addMemberResult); // If the leader can't be added to a new group because it appears full, something is clearly wrong. } else if (!AddMember(leader)) return false; -- cgit v1.2.3