From 4c0476bfd7d104386806e35edfa975634495dd2c Mon Sep 17 00:00:00 2001 From: jackpoz Date: Sat, 31 Jan 2015 22:59:21 +0100 Subject: Core/Misc: Properly sanitize ReputationSpillover data Fix an issue added in 024b57bb74a664cd515cf0822d4b8e939a91fe03 that didn't properly skip ReputationSpillover rows with invalid data. Fix also a static analysis issue reported by Coverity. (cherry picked from commit 95b1204798d3ab2a141f81b294b064255c335b8a) Conflicts: src/server/game/Globals/ObjectMgr.cpp --- src/server/game/Reputation/ReputationMgr.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/server/game/Reputation/ReputationMgr.cpp') diff --git a/src/server/game/Reputation/ReputationMgr.cpp b/src/server/game/Reputation/ReputationMgr.cpp index ad71381a1de..b99cb677ba0 100644 --- a/src/server/game/Reputation/ReputationMgr.cpp +++ b/src/server/game/Reputation/ReputationMgr.cpp @@ -297,7 +297,7 @@ bool ReputationMgr::SetReputation(FactionEntry const* factionEntry, int32 standi { // bonuses are already given, so just modify standing by rate int32 spilloverRep = int32(standing * repTemplate->faction_rate[i]); - SetOneFactionReputation(sFactionStore.LookupEntry(repTemplate->faction[i]), spilloverRep, incremental); + SetOneFactionReputation(sFactionStore.AssertEntry(repTemplate->faction[i]), spilloverRep, incremental); } } } -- cgit v1.2.3