From 301ec0be564a4f160984dc5e34ab5468464dc76e Mon Sep 17 00:00:00 2001 From: Naios Date: Wed, 11 Mar 2015 08:53:13 +0100 Subject: Core/Game: Fix some issues detected by static analysis. * Possible inefficient checking for 'list' emptiness. * Variable '_scheduledScripts' is assigned in constructor body. Consider performing initialization in initialization list. * Variable 'Text' is assigned in constructor body. Consider performing initialization in initialization list. * Possible inefficient checking for 'm_loadedScripts' emptiness. (cherry picked from commit 9a61049f88835fd6bdb75905f042583d038d0667) Conflicts: src/server/game/Server/Packets/TicketPackets.cpp --- src/server/game/Scripting/ScriptMgr.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'src/server/game/Scripting/ScriptMgr.cpp') diff --git a/src/server/game/Scripting/ScriptMgr.cpp b/src/server/game/Scripting/ScriptMgr.cpp index 628452d120c..aed829a7b57 100644 --- a/src/server/game/Scripting/ScriptMgr.cpp +++ b/src/server/game/Scripting/ScriptMgr.cpp @@ -182,9 +182,8 @@ struct TSpellSummary uint8 Effects; // set of enum SelectEffect } *SpellSummary; -ScriptMgr::ScriptMgr() : _scriptCount(0) +ScriptMgr::ScriptMgr() : _scriptCount(0), _scheduledScripts(0) { - _scheduledScripts = 0; } ScriptMgr::~ScriptMgr() { } -- cgit v1.2.3