From cc4ebdbe059358cac997e783b2fddc6cff4c831b Mon Sep 17 00:00:00 2001
From: joschiwald <joschiwald.trinity@gmail.com>
Date: Fri, 5 Dec 2014 23:55:06 +0100
Subject: Core/Scripts: log ScriptNames assigned in database without core
 script

---
 src/server/game/Scripting/ScriptMgr.cpp | 33 +++++++++++++++++++++++++++++++--
 1 file changed, 31 insertions(+), 2 deletions(-)

(limited to 'src/server/game/Scripting/ScriptMgr.cpp')

diff --git a/src/server/game/Scripting/ScriptMgr.cpp b/src/server/game/Scripting/ScriptMgr.cpp
index ac0b5bbf2e6..055a7a52310 100644
--- a/src/server/game/Scripting/ScriptMgr.cpp
+++ b/src/server/game/Scripting/ScriptMgr.cpp
@@ -34,6 +34,12 @@
 #include "WorldPacket.h"
 #include "WorldSession.h"
 
+// namespace
+// {
+    UnusedScriptContainer UnusedScripts;
+    UnusedScriptNamesContainer UnusedScriptNames;
+// }
+
 // This is the global static registry of scripts.
 template<class TScript>
 class ScriptRegistry
@@ -89,6 +95,12 @@ class ScriptRegistry
                     {
                         ScriptPointerList[id] = script;
                         sScriptMgr->IncrementScriptCount();
+
+                    #ifdef SCRIPTS
+                        UnusedScriptNamesContainer::const_iterator itr = std::lower_bound(UnusedScriptNames.begin(), UnusedScriptNames.end(), script->GetName());
+                        if (itr != UnusedScriptNames.end() && *itr == script->GetName())
+                            UnusedScriptNames.erase(itr);
+                    #endif
                     }
                     else
                     {
@@ -106,8 +118,7 @@ class ScriptRegistry
 
                     // Avoid calling "delete script;" because we are currently in the script constructor
                     // In a valid scenario this will not happen because every script has a name assigned in the database
-                    // If that happens, it's acceptable to just leak a few bytes
-
+                    UnusedScripts.push_back(script);
                     return;
                 }
             }
@@ -189,6 +200,15 @@ void ScriptMgr::Initialize()
     FillSpellSummary();
     AddScripts();
 
+#ifdef SCRIPTS
+    for (std::string const& scriptName : UnusedScriptNames)
+    {
+        TC_LOG_ERROR("sql.sql", "ScriptName '%s' exists in database, but no core script found!", scriptName.c_str());
+    }
+#endif
+
+    UnloadUnusedScripts();
+
     TC_LOG_INFO("server.loading", ">> Loaded %u C++ scripts in %u ms", GetScriptCount(), GetMSTimeDiffToNow(oldMSTime));
 }
 
@@ -229,10 +249,19 @@ void ScriptMgr::Unload()
 
     #undef SCR_CLEAR
 
+    UnloadUnusedScripts();
+
     delete[] SpellSummary;
     delete[] UnitAI::AISpellInfo;
 }
 
+void ScriptMgr::UnloadUnusedScripts()
+{
+    for (size_t i = 0; i < UnusedScripts.size(); ++i)
+        delete UnusedScripts[i];
+    UnusedScripts.clear();
+}
+
 void ScriptMgr::LoadDatabase()
 {
     sScriptSystemMgr->LoadScriptWaypoints();
-- 
cgit v1.2.3


From 9cda85a38817179ae48ead6080ae2a200f2310de Mon Sep 17 00:00:00 2001
From: joschiwald <joschiwald.trinity@gmail.com>
Date: Sat, 6 Dec 2014 00:19:12 +0100
Subject: Fixed build

---
 src/server/game/Scripting/ScriptMgr.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/server/game/Scripting/ScriptMgr.cpp')

diff --git a/src/server/game/Scripting/ScriptMgr.cpp b/src/server/game/Scripting/ScriptMgr.cpp
index 055a7a52310..69e54f18ca3 100644
--- a/src/server/game/Scripting/ScriptMgr.cpp
+++ b/src/server/game/Scripting/ScriptMgr.cpp
@@ -97,7 +97,7 @@ class ScriptRegistry
                         sScriptMgr->IncrementScriptCount();
 
                     #ifdef SCRIPTS
-                        UnusedScriptNamesContainer::const_iterator itr = std::lower_bound(UnusedScriptNames.begin(), UnusedScriptNames.end(), script->GetName());
+                        UnusedScriptNamesContainer::iterator itr = std::lower_bound(UnusedScriptNames.begin(), UnusedScriptNames.end(), script->GetName());
                         if (itr != UnusedScriptNames.end() && *itr == script->GetName())
                             UnusedScriptNames.erase(itr);
                     #endif
-- 
cgit v1.2.3