From 3b95d3dcf95caa6df3f5b7897e8b29dbb1cb58e3 Mon Sep 17 00:00:00 2001 From: Shauren Date: Mon, 10 May 2021 13:09:59 +0200 Subject: Core/PacketIO: Fixed SMSG_GUILD_EVENT for empty MOTD broken after cd28423a4e813baf6833f38c93613a7f82a721f8 Closes #26522 --- src/server/game/Server/Packets/GuildPackets.cpp | 7 +++---- src/server/game/Server/Packets/GuildPackets.h | 3 ++- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'src/server/game/Server') diff --git a/src/server/game/Server/Packets/GuildPackets.cpp b/src/server/game/Server/Packets/GuildPackets.cpp index 1cc7e23a062..30cc4c941b9 100644 --- a/src/server/game/Server/Packets/GuildPackets.cpp +++ b/src/server/game/Server/Packets/GuildPackets.cpp @@ -122,10 +122,9 @@ ByteBuffer& operator<<(ByteBuffer& data, WorldPackets::Guild::GuildRosterMemberD WorldPacket const* WorldPackets::Guild::GuildEvent::Write() { _worldPacket << uint8(Type); - uint8 paramCount = Params[2].empty() ? (Params[1].empty() ? (Params[0].empty() ? 0 : 1) : 2) : 3; - _worldPacket << uint8(paramCount); - for (uint8 i = 0; i < paramCount; ++i) - _worldPacket << Params[i]; + _worldPacket << uint8(Params.size()); + for (std::string_view param : Params) + _worldPacket << param; switch (Type) { diff --git a/src/server/game/Server/Packets/GuildPackets.h b/src/server/game/Server/Packets/GuildPackets.h index 44796c422da..6815b936531 100644 --- a/src/server/game/Server/Packets/GuildPackets.h +++ b/src/server/game/Server/Packets/GuildPackets.h @@ -22,6 +22,7 @@ #include "Guild.h" #include "ObjectGuid.h" #include "PacketUtilities.h" +#include #include namespace WorldPackets @@ -207,7 +208,7 @@ namespace WorldPackets WorldPacket const* Write() override; uint8 Type = 0; - std::array Params = { }; + boost::container::static_vector Params; ObjectGuid Guid; }; -- cgit v1.2.3