From 7dff0e3246f68c39e122e6ccb93b18c29f6df130 Mon Sep 17 00:00:00 2001 From: ariel- Date: Fri, 15 Dec 2017 03:40:36 -0300 Subject: Core/Auras: fixed off by one error in counting SPELL_ATTR5_START_PERIODIC_AT_APPLY ticks - Made SpellInfo::GetMaxTicks and AuraEffect::GetTotalTicks return the same number without mods (dumped arbitrary default return value of 6 and arbitrary 30 sec limit) - They should be streamlined whenever SPELL_AURA_48 is implemented --- src/server/game/Spells/SpellEffects.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/server/game/Spells/SpellEffects.cpp') diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index 052d4e466c6..007e30b7714 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -444,6 +444,8 @@ void Spell::EffectSchoolDMG(SpellEffIndex effIndex) int32 pct_dot = m_caster->CalculateSpellDamage(unitTarget, m_spellInfo, EFFECT_2); int32 const dotBasePoints = CalculatePct(pdamage, pct_dot); + + ASSERT(m_spellInfo->GetMaxTicks() > 0); m_spellValue->EffectBasePoints[EFFECT_1] = dotBasePoints / m_spellInfo->GetMaxTicks(); apply_direct_bonus = false; -- cgit v1.2.3