From 91a0fbbd7145d6fb966231689c369d641da06f9b Mon Sep 17 00:00:00 2001 From: Ujp8LfXBJ6wCPR Date: Sat, 8 Feb 2020 20:29:18 +0100 Subject: Use boost::optional and boost::none instead of smelly pointer (#24134) * Remove bad pointer usage from CharacterCache Use TrinityCore Option type instead which is intended for this purpose. (Wrapper around boost::option until C++17 bump is finalised) * Unify codestyle regarding TC optional type Based upon advice from @Shauren (cherry picked from commit 76831f1f467efe4aa26a38dc58c9eab2229bce71) --- src/server/game/Spells/SpellEffects.cpp | 4 ---- 1 file changed, 4 deletions(-) (limited to 'src/server/game/Spells/SpellEffects.cpp') diff --git a/src/server/game/Spells/SpellEffects.cpp b/src/server/game/Spells/SpellEffects.cpp index e3297b1407d..a127167b186 100644 --- a/src/server/game/Spells/SpellEffects.cpp +++ b/src/server/game/Spells/SpellEffects.cpp @@ -2148,8 +2148,6 @@ void Spell::EffectDispel() WorldPackets::CombatLog::SpellDispellData dispellData; dispellData.SpellID = dispelableAura.GetAura()->GetId(); dispellData.Harmful = false; // TODO: use me - dispellData.Rolled = boost::none; // TODO: use me - dispellData.Needed = boost::none; // TODO: use me unitTarget->RemoveAurasDueToSpellByDispel(dispelableAura.GetAura()->GetId(), m_spellInfo->Id, dispelableAura.GetAura()->GetCasterGUID(), m_caster, dispelableAura.GetDispelCharges()); @@ -4568,8 +4566,6 @@ void Spell::EffectStealBeneficialBuff() WorldPackets::CombatLog::SpellDispellData dispellData; dispellData.SpellID = dispell.first; dispellData.Harmful = false; // TODO: use me - dispellData.Rolled = boost::none; // TODO: use me - dispellData.Needed = boost::none; // TODO: use me unitTarget->RemoveAurasDueToSpellBySteal(dispell.first, dispell.second, m_caster); -- cgit v1.2.3