From e6e5775be83d07c3221d6690f11184246bec4bf1 Mon Sep 17 00:00:00 2001 From: Peter Keresztes Schmidt Date: Sat, 18 Jul 2020 20:43:16 +0200 Subject: Build: Enable -Wimplicit-fallthrough on clang (#25056) * Misc: Use [[fallthrough]] attribute instead of comment to mark intentional fallthroughs Related: #25006 * Misc: Add some missing breaks (no-ops) to satisfy clang Related: #25006 Closes #25055 * Build: Enable -Wimplicit-fallthrough on clang Closes #25006 --- src/server/game/Spells/SpellInfo.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/server/game/Spells/SpellInfo.cpp') diff --git a/src/server/game/Spells/SpellInfo.cpp b/src/server/game/Spells/SpellInfo.cpp index 24a587a161c..60122176508 100644 --- a/src/server/game/Spells/SpellInfo.cpp +++ b/src/server/game/Spells/SpellInfo.cpp @@ -3498,10 +3498,12 @@ bool _isPositiveEffectImpl(SpellInfo const* spellInfo, uint8 effIndex, std::unor case SPELL_EFFECT_HEAL_PCT: return true; case SPELL_EFFECT_INSTAKILL: - if (i != effIndex && // for spells like 38044: instakill effect is negative but auras on target must count as buff + if (i != effIndex && + // for spells like 38044: instakill effect is negative but auras on target must count as buff spellInfo->Effects[i].TargetA.GetTarget() == spellInfo->Effects[effIndex].TargetA.GetTarget() && spellInfo->Effects[i].TargetB.GetTarget() == spellInfo->Effects[effIndex].TargetB.GetTarget()) - return false; + return false; + break; default: break; } -- cgit v1.2.3