From 1c5287032affb1a402b0a6091b75997ef56e556c Mon Sep 17 00:00:00 2001 From: ccrs Date: Thu, 10 Jan 2019 22:51:47 +0100 Subject: Core/Movement: correct logic wrongly ported in 2a84562dc8 I'm referencing line 97 from ChaseMovementGenerator. That commit introduced a modification in this use case: - Chasing target is not my current victim, I should stop moving till it is my victim again Changed To: - Chasing target is not my current vicitm, I should stop chasing My correction: - I dont care about the relation of my current victim and my chasing target, I'm commanded to chase, something will tell me to stop chasing --> Most likely: evade, new attackstart, etc. the rest are just minor changes (cherry picked from commit 9080e7863c28df7dc1c2af321964776e7b59e41a) --- src/server/scripts/Commands/cs_misc.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src/server/scripts/Commands') diff --git a/src/server/scripts/Commands/cs_misc.cpp b/src/server/scripts/Commands/cs_misc.cpp index 3782d181b5d..7f1175a4503 100644 --- a/src/server/scripts/Commands/cs_misc.cpp +++ b/src/server/scripts/Commands/cs_misc.cpp @@ -2199,8 +2199,8 @@ public: float x, y, z; unit->GetMotionMaster()->GetDestination(x, y, z); - std::vector list = unit->GetMotionMaster()->GetMovementGeneratorsInformation(); - for (MovementGeneratorInformation info : list) + std::vector const list = unit->GetMotionMaster()->GetMovementGeneratorsInformation(); + for (MovementGeneratorInformation const& info : list) { switch (info.Type) { -- cgit v1.2.3