From 97e869e8b36afd9e7f0452b9001287f6b4a02ef2 Mon Sep 17 00:00:00 2001 From: ariel- Date: Thu, 14 Dec 2017 13:39:05 -0300 Subject: Core/Auras: periodics refactor part 3: move more switch hacks to scripts - Incidentally fixed some spells which were supposed to be removed by proc instead of healing to full (cherry picked from commit 16e20711d277bc43ae3ac350208df73827306ea6) --- .../FrozenHalls/PitOfSaron/pit_of_saron.cpp | 31 --------------------- .../Northrend/Ulduar/Ulduar/boss_thorim.cpp | 32 ---------------------- 2 files changed, 63 deletions(-) (limited to 'src/server/scripts/Northrend') diff --git a/src/server/scripts/Northrend/FrozenHalls/PitOfSaron/pit_of_saron.cpp b/src/server/scripts/Northrend/FrozenHalls/PitOfSaron/pit_of_saron.cpp index 043fdc44c4b..f057f2cc22b 100644 --- a/src/server/scripts/Northrend/FrozenHalls/PitOfSaron/pit_of_saron.cpp +++ b/src/server/scripts/Northrend/FrozenHalls/PitOfSaron/pit_of_saron.cpp @@ -232,36 +232,6 @@ class npc_geist_ambusher : public CreatureScript } }; -class spell_trash_npc_glacial_strike : public SpellScriptLoader -{ - public: - spell_trash_npc_glacial_strike() : SpellScriptLoader("spell_trash_npc_glacial_strike") { } - - class spell_trash_npc_glacial_strike_AuraScript : public AuraScript - { - PrepareAuraScript(spell_trash_npc_glacial_strike_AuraScript); - - void PeriodicTick(AuraEffect const* /*aurEff*/) - { - if (GetTarget()->IsFullHealth()) - { - GetTarget()->RemoveAura(GetId(), ObjectGuid::Empty, 0, AURA_REMOVE_BY_ENEMY_SPELL); - PreventDefaultAction(); - } - } - - void Register() override - { - OnEffectPeriodic += AuraEffectPeriodicFn(spell_trash_npc_glacial_strike_AuraScript::PeriodicTick, EFFECT_2, SPELL_AURA_PERIODIC_DAMAGE_PERCENT); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_trash_npc_glacial_strike_AuraScript(); - } -}; - class npc_pit_of_saron_icicle : public CreatureScript { public: @@ -395,7 +365,6 @@ void AddSC_pit_of_saron() new npc_iceborn_protodrake(); new npc_geist_ambusher(); new npc_pit_of_saron_icicle(); - new spell_trash_npc_glacial_strike(); new spell_pos_ice_shards(); new at_pit_cavern_entrance(); new at_pit_cavern_end(); diff --git a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp index 41c5b3c68d6..35fe1efc788 100644 --- a/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp +++ b/src/server/scripts/Northrend/Ulduar/Ulduar/boss_thorim.cpp @@ -2092,37 +2092,6 @@ class spell_thorim_activate_lightning_orb_periodic : public SpellScriptLoader } }; -// 62331, 62418 - Impale -class spell_iron_ring_guard_impale : public SpellScriptLoader -{ - public: - spell_iron_ring_guard_impale() : SpellScriptLoader("spell_iron_ring_guard_impale") { } - - class spell_iron_ring_guard_impale_AuraScript : public AuraScript - { - PrepareAuraScript(spell_iron_ring_guard_impale_AuraScript); - - void PeriodicTick(AuraEffect const* /*aurEff*/) - { - if (GetTarget()->HealthAbovePct(GetSpellInfo()->GetEffect(EFFECT_1)->CalcValue())) - { - Remove(AURA_REMOVE_BY_ENEMY_SPELL); - PreventDefaultAction(); - } - } - - void Register() override - { - OnEffectPeriodic += AuraEffectPeriodicFn(spell_iron_ring_guard_impale_AuraScript::PeriodicTick, EFFECT_0, SPELL_AURA_PERIODIC_DAMAGE); - } - }; - - AuraScript* GetAuraScript() const override - { - return new spell_iron_ring_guard_impale_AuraScript(); - } -}; - class condition_thorim_arena_leap : public ConditionScript { public: @@ -2161,6 +2130,5 @@ void AddSC_boss_thorim() new spell_thorim_arena_leap(); new spell_thorim_runic_smash(); new spell_thorim_activate_lightning_orb_periodic(); - new spell_iron_ring_guard_impale(); new condition_thorim_arena_leap(); } -- cgit v1.2.3