From 03c34ee507b4e43fabee1ff382d9de9ea815e3f2 Mon Sep 17 00:00:00 2001
From: Spp <spp@jorge.gr>
Date: Thu, 16 Feb 2012 13:56:08 +0100
Subject: Fix a lot of warnings

---
 src/server/scripts/Commands/cs_debug.cpp                       |  2 +-
 .../CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp  |  2 +-
 src/server/scripts/Outland/blades_edge_mountains.cpp           |  6 ++----
 src/server/scripts/Spells/spell_generic.cpp                    | 10 ++++++----
 4 files changed, 10 insertions(+), 10 deletions(-)

(limited to 'src/server/scripts')

diff --git a/src/server/scripts/Commands/cs_debug.cpp b/src/server/scripts/Commands/cs_debug.cpp
index 73e6b0ac8a5..3de1181f764 100644
--- a/src/server/scripts/Commands/cs_debug.cpp
+++ b/src/server/scripts/Commands/cs_debug.cpp
@@ -1042,7 +1042,7 @@ public:
         return true;
     }
     
-    static bool HandleDebugLoSCommand(ChatHandler* handler, char const* args)
+    static bool HandleDebugLoSCommand(ChatHandler* handler, char const* /*args*/)
     {
         if (Unit* unit = handler->getSelectedUnit())
             handler->PSendSysMessage("Unit %s (GuidLow: %u) is %sin LoS", unit->GetName(), unit->GetGUIDLow(), handler->GetSession()->GetPlayer()->IsWithinLOSInMap(unit) ? "" : "not ");
diff --git a/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp b/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp
index a78a29704cc..242b2f2f0ea 100755
--- a/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp
+++ b/src/server/scripts/Northrend/CrusadersColiseum/TrialOfTheCrusader/boss_twin_valkyr.cpp
@@ -308,7 +308,7 @@ struct boss_twin_baseAI : public ScriptedAI
 
     void EnableDualWield(bool mode = true)
     {
-        SetEquipmentSlots(false, m_uiWeapon, mode ? m_uiWeapon : EQUIP_UNEQUIP, EQUIP_UNEQUIP);
+        SetEquipmentSlots(false, m_uiWeapon, mode ? m_uiWeapon : int32(EQUIP_UNEQUIP), EQUIP_UNEQUIP);
         me->SetCanDualWield(mode);
         me->UpdateDamagePhysical(mode ? OFF_ATTACK : BASE_ATTACK);
     }
diff --git a/src/server/scripts/Outland/blades_edge_mountains.cpp b/src/server/scripts/Outland/blades_edge_mountains.cpp
index 97ce9f45430..c9fdd0f65ff 100644
--- a/src/server/scripts/Outland/blades_edge_mountains.cpp
+++ b/src/server/scripts/Outland/blades_edge_mountains.cpp
@@ -739,7 +739,7 @@ class npc_simon_bunny : public CreatureScript
                 if (!listening)
                     return;
 
-                uint8 pressedColor;
+                uint8 pressedColor = SIMON_MAX_COLORS;
 
                 if (type == clusterIds[SIMON_RED])
                     pressedColor = SIMON_RED;
@@ -974,7 +974,7 @@ class npc_simon_bunny : public CreatureScript
             // Handles the spell rewards. The spells also have the QuestCompleteEffect, so quests credits are working.
             void GiveRewardForLevel(uint8 level)
             {
-                uint32 rewSpell;
+                uint32 rewSpell = 0;
                 switch (level)
                 {
                     case 6: 
@@ -989,8 +989,6 @@ class npc_simon_bunny : public CreatureScript
                     case 10:
                         rewSpell = SPELL_REWARD_BUFF_3;
                         break;
-                    default:
-                        rewSpell = 0;
                 }
 
                 if (rewSpell)
diff --git a/src/server/scripts/Spells/spell_generic.cpp b/src/server/scripts/Spells/spell_generic.cpp
index 9899e50cd28..09fb6830da8 100644
--- a/src/server/scripts/Spells/spell_generic.cpp
+++ b/src/server/scripts/Spells/spell_generic.cpp
@@ -1521,7 +1521,7 @@ class spell_gen_luck_of_the_draw : public SpellScriptLoader
                 if (group && group->isLFGGroup())
                     if (uint32 dungeonId = sLFGMgr->GetDungeon(group->GetGUID(), true))
                         if (LFGDungeonEntry const* dungeon = sLFGDungeonStore.LookupEntry(dungeonId))
-                            if (dungeon->map == map->GetId() && dungeon->difficulty == map->GetDifficulty())
+                            if (uint32(dungeon->map) == map->GetId() && dungeon->difficulty == map->GetDifficulty())
                                 if (randomDungeon && randomDungeon->type == LFG_TYPE_RANDOM)
                                     return; // in correct dungeon
 
@@ -1706,6 +1706,8 @@ class spell_gen_break_shield: public SpellScriptLoader
                         }
                         break;
                     }
+                    default:
+                        break;
                 }
             }
 
@@ -1834,7 +1836,7 @@ class spell_gen_mounted_charge: public SpellScriptLoader
                 }
             }
 
-            void HandleChargeEffect(SpellEffIndex effIndex)
+            void HandleChargeEffect(SpellEffIndex /*effIndex*/)
             {
                 uint32 spellId;
 
@@ -1908,7 +1910,7 @@ class spell_gen_defend : public SpellScriptLoader
 
             void RefreshVisualShields(AuraEffect const* aurEff, AuraEffectHandleModes /*mode*/)
             {
-                if (Unit* caster = GetCaster())
+                if (GetCaster())
                 {
                     Unit* target = GetTarget();
 
@@ -1989,7 +1991,7 @@ class spell_gen_tournament_duel : public SpellScriptLoader
                 return true;
             }
 
-            void HandleScriptEffect(SpellEffIndex effIndex)
+            void HandleScriptEffect(SpellEffIndex /*effIndex*/)
             {
                 if (Unit* rider = GetCaster()->GetCharmer())
                 {
-- 
cgit v1.2.3