From aaefda61009f9375e82ee63cf0610adcd19b5d8d Mon Sep 17 00:00:00 2001 From: ariel- Date: Wed, 1 Mar 2017 19:35:39 -0300 Subject: Core/Scripts: Change null-check to assert - ToPlayer() should never be null in this context (cherrypicked from 12c680f9b1f1068099c3b19443d93d456690ac56) --- src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'src/server/scripts') diff --git a/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp b/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp index 0de1bc53f73..7a880f05150 100644 --- a/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp +++ b/src/server/scripts/Northrend/IcecrownCitadel/boss_sindragosa.cpp @@ -1098,10 +1098,8 @@ class spell_sindragosa_s_fury : public SpellScriptLoader { targets.remove_if([](WorldObject* obj) -> bool { - if (Player* target = obj->ToPlayer()) - if (target->IsGameMaster()) - return true; - return false; + // SPELL_ATTR3_ONLY_TARGET_PLAYERS present on the spell, we can safely cast to Player + return ASSERT_NOTNULL(obj->ToPlayer())->IsGameMaster(); }); _targetCount = targets.size(); -- cgit v1.2.3