From 123163dc41b0264891aa0d57702c23c98fdb5f1e Mon Sep 17 00:00:00 2001 From: Machiavelli Date: Sun, 12 Sep 2010 15:57:36 +0200 Subject: Core/DBLayer: Check for potential mysql client/server version mismatch. Version mismatch may lead to undefined behaviour with prepared statements. --HG-- branch : trunk --- src/server/shared/Database/MySQLConnection.cpp | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'src/server/shared/Database/MySQLConnection.cpp') diff --git a/src/server/shared/Database/MySQLConnection.cpp b/src/server/shared/Database/MySQLConnection.cpp index cf47eb1374d..3707016765e 100644 --- a/src/server/shared/Database/MySQLConnection.cpp +++ b/src/server/shared/Database/MySQLConnection.cpp @@ -122,10 +122,12 @@ bool MySQLConnection::Open(const std::string& infoString) if (m_Mysql) { - sLog.outDetail("Connected to MySQL database at %s", host.c_str()); sLog.outSQLDriver("MySQL client library: %s", mysql_get_client_info()); - sLog.outSQLDriver("MySQL server ver: %s ", mysql_get_server_info( m_Mysql)); + sLog.outSQLDriver("MySQL server ver: %s ", mysql_get_server_info(m_Mysql)); + if (mysql_get_server_version(m_Mysql) != mysql_get_client_version()) + sLog.outSQLDriver("[WARNING] MySQL client/server version mismatch; may conflict with behaviour of prepared statements."); + sLog.outDetail("Connected to MySQL database at %s", host.c_str()); if (!mysql_autocommit(m_Mysql, 1)) sLog.outSQLDriver("AUTOCOMMIT SUCCESSFULLY SET TO 1"); else -- cgit v1.2.3