From 9c336cc32e26999b8155d52885f6cc83152109d5 Mon Sep 17 00:00:00 2001 From: jackpoz Date: Sat, 21 Sep 2013 17:45:46 +0200 Subject: Core/DB: Make a26a24a consistent with Trinity code style Change DatabaseWorkerPool::DirectExecute() to handle PreparedStatement disposal in the same way of DatabaseWorkerPool::Query() , thanks Joschiwald for patch. --- src/server/shared/Database/DatabaseWorkerPool.h | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'src/server/shared/Database') diff --git a/src/server/shared/Database/DatabaseWorkerPool.h b/src/server/shared/Database/DatabaseWorkerPool.h index 5ecadfe18a8..e209beef8b6 100644 --- a/src/server/shared/Database/DatabaseWorkerPool.h +++ b/src/server/shared/Database/DatabaseWorkerPool.h @@ -214,6 +214,9 @@ class DatabaseWorkerPool T* t = GetFreeConnection(); t->Execute(stmt); t->Unlock(); + + //! Delete proxy-class. Not needed anymore + delete stmt; } /** @@ -430,7 +433,7 @@ class DatabaseWorkerPool */ //! Automanaged (internally) pointer to a prepared statement object for usage in upper level code. - //! Pointer is deleted in this->Query(PreparedStatement*) or PreparedStatementTask::~PreparedStatementTask. + //! Pointer is deleted in this->DirectExecute(PreparedStatement*), this->Query(PreparedStatement*) or PreparedStatementTask::~PreparedStatementTask. //! This object is not tied to the prepared statement on the MySQL context yet until execution. PreparedStatement* GetPreparedStatement(uint32 index) { -- cgit v1.2.3