From fbbcc3167053950d2000cd88bb7d98266491768f Mon Sep 17 00:00:00 2001
From: Shauren <shauren.trinity@gmail.com>
Date: Fri, 11 Jul 2025 17:47:14 +0200
Subject: Core/Misc: Simplify LinkedListHead::isEmpty and rename to empty to
 fit standard container naming

---
 src/server/shared/Dynamic/LinkedList.h | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

(limited to 'src/server/shared/Dynamic')

diff --git a/src/server/shared/Dynamic/LinkedList.h b/src/server/shared/Dynamic/LinkedList.h
index bc4a10da741..01a2e2610a8 100644
--- a/src/server/shared/Dynamic/LinkedList.h
+++ b/src/server/shared/Dynamic/LinkedList.h
@@ -83,7 +83,7 @@ class LinkedListElement
         LinkedListElement& operator=(LinkedListElement&&) = delete;
 
     protected:
-        virtual ~LinkedListElement()
+        ~LinkedListElement()
         {
             delink();
         }
@@ -107,13 +107,13 @@ class LinkedListHead
             iLast.iPrev = &iFirst;
         }
 
-        bool isEmpty() const { return(!iFirst.iNext->isInList()); }
+        bool empty() const { return iFirst.iNext == &iLast; }
 
-        LinkedListElement      * getFirst()       { return (isEmpty() ? nullptr : iFirst.iNext); }
-        LinkedListElement const* getFirst() const { return (isEmpty() ? nullptr : iFirst.iNext); }
+        LinkedListElement      * getFirst()       { return (empty() ? nullptr : iFirst.iNext); }
+        LinkedListElement const* getFirst() const { return (empty() ? nullptr : iFirst.iNext); }
 
-        LinkedListElement      * getLast()       { return(isEmpty() ? nullptr : iLast.iPrev); }
-        LinkedListElement const* getLast() const { return(isEmpty() ? nullptr : iLast.iPrev); }
+        LinkedListElement      * getLast()       { return (empty() ? nullptr : iLast.iPrev); }
+        LinkedListElement const* getLast() const { return (empty() ? nullptr : iLast.iPrev); }
 
         void insertFirst(LinkedListElement* pElem)
         {
@@ -166,18 +166,18 @@ class LinkedListHead
                 {                                           // construct with node pointer _Pnode
                 }
 
-                Iterator& operator=(const_pointer const& _Right)
+                Iterator& operator=(const_pointer _Right)
                 {
-                    _Ptr = pointer(_Right);
+                    _Ptr = const_cast<pointer>(_Right);
                     return *this;
                 }
 
-                reference operator*()
+                reference operator*() const
                 {                                           // return designated value
                     return *_Ptr;
                 }
 
-                pointer operator->()
+                pointer operator->() const
                 {                                           // return pointer to class object
                     return _Ptr;
                 }
-- 
cgit v1.2.3