From 026ceb85b9e0e870d95cea42895e867198c156dd Mon Sep 17 00:00:00 2001 From: Naios Date: Tue, 21 Jul 2015 23:17:00 +0200 Subject: Core/Logging: Enable perfect forwarding for logging format and args. * Handle timestamp parsing though cppformat. * Change a wrong forward -> move --- src/server/shared/Logging/Log.cpp | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) (limited to 'src/server/shared/Logging/Log.cpp') diff --git a/src/server/shared/Logging/Log.cpp b/src/server/shared/Logging/Log.cpp index c9a4432039f..f9f96c3da75 100644 --- a/src/server/shared/Logging/Log.cpp +++ b/src/server/shared/Logging/Log.cpp @@ -270,7 +270,7 @@ void Log::write(std::unique_ptr&& msg) const if (_ioService) { - auto logOperation = std::shared_ptr(new LogOperation(logger, std::forward>(msg))); + auto logOperation = std::shared_ptr(new LogOperation(logger, std::move(msg))); _ioService->post(_strand->wrap([logOperation](){ logOperation->call(); })); } @@ -291,9 +291,8 @@ std::string Log::GetTimestampStr() // HH hour (2 digits 00-23) // MM minutes (2 digits 00-59) // SS seconds (2 digits 00-59) - char buf[20]; - snprintf(buf, 20, "%04d-%02d-%02d_%02d-%02d-%02d", aTm.tm_year+1900, aTm.tm_mon+1, aTm.tm_mday, aTm.tm_hour, aTm.tm_min, aTm.tm_sec); - return std::string(buf); + return Trinity::StringFormat("%04d-%02d-%02d_%02d-%02d-%02d", + aTm.tm_year + 1900, aTm.tm_mon + 1, aTm.tm_mday, aTm.tm_hour, aTm.tm_min, aTm.tm_sec); } bool Log::SetLogLevel(std::string const& name, const char* newLevelc, bool isLogger /* = true */) -- cgit v1.2.3