From a4ecb2dfae8bb4a1eeccf9f97af5948078266a5c Mon Sep 17 00:00:00 2001 From: Shauren Date: Mon, 5 Aug 2024 14:13:17 +0200 Subject: Core/PacketIO: Fixed handling CMSG_UPDATE_ACCOUNT_DATA - compressed value is not a null-terminated string --- src/server/shared/Packets/ByteBuffer.h | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) (limited to 'src/server/shared') diff --git a/src/server/shared/Packets/ByteBuffer.h b/src/server/shared/Packets/ByteBuffer.h index 9233c4f5150..e7fa67d632f 100644 --- a/src/server/shared/Packets/ByteBuffer.h +++ b/src/server/shared/Packets/ByteBuffer.h @@ -633,16 +633,13 @@ class TC_SHARED_API ByteBuffer /// @todo Make a ByteBuffer.cpp and move all this inlining to it. template<> inline std::string ByteBuffer::read() { - std::string tmp; - *this >> tmp; - return tmp; + return std::string(ReadCString()); } template<> inline void ByteBuffer::read_skip() { - std::string temp; - *this >> temp; + (void)ReadCString(); } template<> -- cgit v1.2.3