From 192f08824863d8ac5db9051fa848908a6eafdde4 Mon Sep 17 00:00:00 2001 From: xinef1 Date: Sun, 29 Jan 2017 16:10:03 +0100 Subject: Core/Achievements: Mountain o' Mounts and similar achievement will be properly awarded when you have required amount of mounts, not earlier (#19002) (cherrypicked from 8646e72f18172062e98b449478d3f8e1d554d4b9) --- src/server/game/Achievements/CriteriaHandler.cpp | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'src/server') diff --git a/src/server/game/Achievements/CriteriaHandler.cpp b/src/server/game/Achievements/CriteriaHandler.cpp index 04c8ec200ef..39aaf2adfcd 100644 --- a/src/server/game/Achievements/CriteriaHandler.cpp +++ b/src/server/game/Achievements/CriteriaHandler.cpp @@ -641,7 +641,11 @@ void CriteriaHandler::UpdateCriteria(CriteriaTypes type, uint64 miscValue1 /*= 0 for (SkillLineAbilityMap::const_iterator skillIter = bounds.first; skillIter != bounds.second; ++skillIter) { if (skillIter->second->SkillLine == int32(criteria->Entry->Asset.SkillID)) - spellCount++; + { + // do not add couter twice if by any chance skill is listed twice in dbc (eg. skill 777 and spell 22717) + ++spellCount; + break; + } } } SetCriteriaProgress(criteria, spellCount, referencePlayer); -- cgit v1.2.3