From 55d0adf15e310e95576fdc4ec406ec154c23ffbb Mon Sep 17 00:00:00 2001 From: Ghaster Date: Sat, 6 Aug 2022 15:08:42 +0200 Subject: Core/Players: Prevent sending QuestUpdateAddCredit on QUEST_OBJECTIVE_ITEM (#28170) --- src/server/game/Entities/Player/Player.cpp | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) (limited to 'src/server') diff --git a/src/server/game/Entities/Player/Player.cpp b/src/server/game/Entities/Player/Player.cpp index 39ca623c91e..1dab0e4b99c 100644 --- a/src/server/game/Entities/Player/Player.cpp +++ b/src/server/game/Entities/Player/Player.cpp @@ -16474,10 +16474,17 @@ void Player::UpdateQuestObjectiveProgress(QuestObjectiveType objectiveType, int3 SetQuestObjectiveData(objective, newProgress); if (addCount > 0 && !(objective.Flags & QUEST_OBJECTIVE_FLAG_HIDE_CREDIT_MSG)) { - if (objectiveType != QUEST_OBJECTIVE_PLAYERKILLS) - SendQuestUpdateAddCredit(quest, victimGuid, objective, newProgress); - else - SendQuestUpdateAddPlayer(quest, newProgress); + switch (objectiveType) + { + case QUEST_OBJECTIVE_ITEM: + break; // case handled by SMSG_ITEM_PUSH_RESULT + case QUEST_OBJECTIVE_PLAYERKILLS: + SendQuestUpdateAddPlayer(quest, newProgress); + break; + default: + SendQuestUpdateAddCredit(quest, victimGuid, objective, newProgress); + break; + } } objectiveIsNowComplete = IsQuestObjectiveComplete(logSlot, quest, objective); -- cgit v1.2.3